From 9f508c8f2f801a8a144e6620f9db550a623e591d Mon Sep 17 00:00:00 2001 From: Steve Karg Date: Thu, 12 Feb 2026 14:46:37 -0600 Subject: [PATCH] Refactor comments in Device_Write_Property_Local() for clarity and consistency --- src/bacnet/basic/object/device.c | 3 +-- src/bacnet/basic/server/bacnet_device.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/bacnet/basic/object/device.c b/src/bacnet/basic/object/device.c index bb34d044..9d9250ca 100644 --- a/src/bacnet/basic/object/device.c +++ b/src/bacnet/basic/object/device.c @@ -2381,8 +2381,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data) if ((value.type.Object_Id.type == OBJECT_DEVICE) && (Device_Set_Object_Instance_Number( value.type.Object_Id.instance))) { - /* FIXME: we could send an I-Am broadcast to let the world - * know */ + /* success! */ } else { status = false; wp_data->error_class = ERROR_CLASS_PROPERTY; diff --git a/src/bacnet/basic/server/bacnet_device.c b/src/bacnet/basic/server/bacnet_device.c index 6d9ad27b..d3b7e40d 100644 --- a/src/bacnet/basic/server/bacnet_device.c +++ b/src/bacnet/basic/server/bacnet_device.c @@ -2201,7 +2201,7 @@ int Device_Configuration_File_Encode( return apdu_len; } -#if defined BACNET_BACKUP_RESTORE +#if defined(BACNET_BACKUP_RESTORE) /** * @brief Decode a BACnetLIST property element to determine the element length * @param object_instance [in] BACnet object instance number @@ -2707,7 +2707,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data) if ((value.type.Object_Id.type == OBJECT_DEVICE) && (Device_Set_Object_Instance_Number( value.type.Object_Id.instance))) { - /* we could send an I-Am broadcast to let the world know */ + /* success! */ } else { status = false; wp_data->error_class = ERROR_CLASS_PROPERTY;