Prepere repo so we can run auto formatters (#747)

* clang-format: Ignore javascript files

Ignore javascript files. Clang-format is not very good formatter for
javascript files anyway. If we ever need javascript formatter we should
use Prettier.

* clang-format: Ignore some lines in sources

Couple things get formatted really funky if we let clang-format format
those. Just ignore those locally.

* zephyr/tescase.yaml: Fix yaml syntax

pre-commit hook check-yaml did found out that there are two skips.
Remove another as this is not right syntax.

* Fix repo contains unicode replacement chars

When running pre-commit text-unicode-replacement-char it founds that
there is couple unicode replacemnt chars. Remove and replace these.

* Convert some tabs to spaces manually

We will soon auto format tabs to spaces. How ever it could not do couple
thing so fix those by hand first.

* Make files with shebang executables

It is good habit that if file has shebang then it is marked executable.
These where found with pre-commit check-shebang-scripts-are-executable
checker.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>

.clang-format

@@ -18,4 +18,7 @@ IndentWidth: 4
 UseTab: Never
 SortIncludes: false
 ColumnLimit: 80
+---
+Language: JavaScript
+DisableFormat: true
 ...

CMakeLists.txt

@@ -39,7 +39,7 @@ option(
   "compile the bacpoll app"
   ON)
 
-  option(
+option(
   BACNET_BUILD_BACDISCOVER_APP
   "compile the bacdiscover app"
   ON)

ports/pic18f6720/hardware.h

@@ -22,9 +22,9 @@ enum INT_STATE { INT_DISABLED, INT_ENABLED, INT_RESTORE };
 #define RESTART_WDT()       { _asm CLRWDT _endasm }
 
 /* *************************************************************************
-  define ENABLE_GLOBAL_INT() INTCONbits.GIE = 1 �
+  define ENABLE_GLOBAL_INT() INTCONbits.GIE = 1
-  #define DISABLE_GLOBAL_INT() INTCONbits.GIE = 0 �
+  #define DISABLE_GLOBAL_INT() INTCONbits.GIE = 0
-  #define ENABLE_PERIPHERAL_INT() INTCONbits.PEIE = 1 �
+  #define ENABLE_PERIPHERAL_INT() INTCONbits.PEIE = 1
   #define DISABLE_PERIPHERAL_INT() INTCONbits.PEIE = 0
  *************************************************************************** */
 #define ENABLE_HIGH_INT()     INTCONbits.GIE = 1

ports/pic18f97j60/hardware.h

@@ -45,9 +45,9 @@ enum INT_STATE { INT_DISABLED, INT_ENABLED, INT_RESTORE };
 #define RESTART_WDT()       { _asm CLRWDT _endasm }
 
 /* *************************************************************************
-  define ENABLE_GLOBAL_INT() INTCONbits.GIE = 1 �
+  define ENABLE_GLOBAL_INT() INTCONbits.GIE = 1
-  #define DISABLE_GLOBAL_INT() INTCONbits.GIE = 0 �
+  #define DISABLE_GLOBAL_INT() INTCONbits.GIE = 0
-  #define ENABLE_PERIPHERAL_INT() INTCONbits.PEIE = 1 �
+  #define ENABLE_PERIPHERAL_INT() INTCONbits.PEIE = 1
   #define DISABLE_PERIPHERAL_INT() INTCONbits.PEIE = 0
  *************************************************************************** */
 #define ENABLE_HIGH_INT()     INTCONbits.GIE = 1

src/bacnet/basic/sys/ringbuf.h

@@ -19,12 +19,14 @@
 * @{
 */
 #ifndef NEXT_POWER_OF_2
+/* clang-format off */
 #define B2(x)    (   (x) | (   (x) >> 1) )
 #define B4(x)    ( B2(x) | ( B2(x) >> 2) )
 #define B8(x)    ( B4(x) | ( B4(x) >> 4) )
 #define B16(x)   ( B8(x) | ( B8(x) >> 8) )
 #define B32(x)   (B16(x) | (B16(x) >>16) )
 #define NEXT_POWER_OF_2(x) (B32((x)-1) + 1)
+/* clang-format on */
 #endif
 /** @} */
 

src/bacnet/config.h

@@ -130,7 +130,9 @@
 
 /* BACAPP decodes WriteProperty service requests
    Choose the datatypes that your application supports */
-#if !(defined(BACAPP_ALL) || \
+/* clang-format off */
+#if !( \
+    defined(BACAPP_ALL) || \
     defined(BACAPP_MINIMAL) || \
     defined(BACAPP_NULL) || \
     defined(BACAPP_BOOLEAN) || \
@@ -166,6 +168,7 @@
     defined(BACAPP_TYPES_EXTRA))
 #define BACAPP_ALL
 #endif
+/* clang-format on */
 
 #if defined (BACAPP_ALL)
 #define BACAPP_MINIMAL
@@ -210,6 +213,7 @@
 #define BACAPP_SHED_LEVEL
 #endif
 
+/* clang-format off */
 #if defined(BACAPP_DOUBLE) || \
     defined(BACAPP_DATETIME) || \
     defined(BACAPP_DATERANGE) || \
@@ -231,6 +235,7 @@
     defined(BACAPP_SHED_LEVEL)
 #define BACAPP_COMPLEX_TYPES
 #endif
+/* clang-format on */
 
 /*
 ** Set the maximum vector type sizes

src/bacnet/datalink/bvlc6.c

@@ -1465,9 +1465,9 @@ int bvlc6_decode_secure_bvll(uint8_t *pdu,
  *
  * This message provides a mechanism whereby a foreign device
  * shall cause a BBMD to distribute a Forwarded-NPDU
- * BVLC to the local multicast domain, to all BBMD�s configured
+ * BVLC to the local multicast domain, to all BBMD's configured
- * in the BBMD�s BDT, and to all foreign devices in the
+ * in the BBMD's BDT, and to all foreign devices in the
- * BBMD�s FDT.
+ * BBMD's FDT.
  *
  * @param pdu - buffer to store the encoding
  * @param pdu_size - size of the buffer to store encoding

src/bacnet/readrange.c

@@ -393,7 +393,7 @@ int rr_decode_service_request(
  * ReadRange-ACK ::= SEQUENCE {
  *     objectIdentifier    [0] BACnetObjectIdentifier,
  *     propertyIdentifier  [1] BACnetPropertyIdentifier,
- *     propertyArrayIndex  [2] Unsigned OPTIONAL	,  -- used only with
+ *     propertyArrayIndex  [2] Unsigned OPTIONAL,  -- used only with
  * array datatype resultFlags         [3] BACnetResultFlags, itemCount [4]
  * Unsigned, itemData            [5] SEQUENCE OF ABSTRACT-SYNTAX.&TYPE,
  *     firstSequenceNumber [6] Unsigned32 OPTIONAL -- used only if 'Item

zephyr/subsys/Kconfig

@@ -22,5 +22,3 @@ config BACNET_SHELL
         select LOG
     help
         Enable BACnet Shell support
-
-

zephyr/tests/bacnet/datalink/bvlc/testcase.yaml

@@ -1,6 +1,5 @@
 common:
   skip: true  # TODO: Remove skip when zephyr v3.0.0 nested <time.h> conflicting definitions resolved.
-  skip: true  #TODO: debug test for Zephyr v3.2.0
 tests:
   bacnet.datalink.bvlc.unit:
     tags: bacnet