Fix bacdevobjpropref module decode buffer overflow reads (#541)

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
2023-11-29 15:44:58 -06:00
parent 241cd2994f
commit 9780f52640
7 changed files with 645 additions and 448 deletions
@@ -849,7 +849,7 @@ bool decode_is_opening_tag_number(uint8_t *apdu, uint8_t tag_number)
 * @param tag_length  Pointer to a variable, or NULL.
 *  Returns the length of the tag in bytes if not NULL.
 *
- * @return true if the tag number matches is an opening tag.
+ * @return true if the tag number matches and is an opening tag.
 */
 bool bacnet_is_opening_tag_number(
    uint8_t *apdu, uint32_t apdu_size, uint8_t tag_number, int *tag_length)