From 9137531eb0807c961c4f0049209629d0e4bc0b39 Mon Sep 17 00:00:00 2001 From: Carlos Gomes Martinho Date: Thu, 28 May 2020 15:56:58 +0200 Subject: [PATCH] fix: compiler warnings Wtautological-pointer-compare (#93) warning: comparison of array 'wp_data->application_data' equal to a null pointer is always false [-Wtautological-pointer-compare] --- src/bacnet/basic/object/av.c | 3 +-- src/bacnet/basic/object/bv.c | 3 +-- src/bacnet/basic/object/csv.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/bacnet/basic/object/av.c b/src/bacnet/basic/object/av.c index 9e7b697b..65f43156 100644 --- a/src/bacnet/basic/object/av.c +++ b/src/bacnet/basic/object/av.c @@ -683,8 +683,7 @@ bool Analog_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data) if (wp_data == NULL) { return false; } - if ((wp_data->application_data == NULL) || - (wp_data->application_data_len == 0)) { + if (wp_data->application_data_len == 0) { return false; } diff --git a/src/bacnet/basic/object/bv.c b/src/bacnet/basic/object/bv.c index d5f38699..186be9ba 100644 --- a/src/bacnet/basic/object/bv.c +++ b/src/bacnet/basic/object/bv.c @@ -422,8 +422,7 @@ bool Binary_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data) if (wp_data == NULL) { return false; } - if ((wp_data->application_data == NULL) || - (wp_data->application_data_len == 0)) { + if (wp_data->application_data_len == 0) { return false; } diff --git a/src/bacnet/basic/object/csv.c b/src/bacnet/basic/object/csv.c index 66bfd017..53b0c33a 100644 --- a/src/bacnet/basic/object/csv.c +++ b/src/bacnet/basic/object/csv.c @@ -488,8 +488,7 @@ bool CharacterString_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data) if (wp_data == NULL) { return false; } - if ((wp_data->application_data == NULL) || - (wp_data->application_data_len == 0)) { + if (wp_data->application_data_len == 0) { return false; }