Issue 187 enable skipped ztest suites (#189)

* Fix some ztests that were skipped

* Expose bacapp_same_value()

* Fix bacapp, ptransfer tests

* Fix bugs in Load_Control object & tests

* refactor days functions from datetime module

* fix legacy ctests

* Add bacnet/basic/sys/days.[ch] to Zephyr build

* Update ztest to match from Zephyr v2.6.0; update ringbuf, datetime to build

* Fixup ztest test for object/acc

* Fix bvlc_address_from_ascii; enable/fix bvlc test

* Comment cleanup

* test/bacnet/basic/object/lc partially enabled

* Fix bacapp_decode_data_len return status on erroneous input

* fix ztest include fatal error

* fix ztest strsignal reference fatal error

* fix zassert_mem_equal reference syntax error

* fix zassert_mem_equal reference syntax error

Co-authored-by: Gregory Shue <gregory.shue@legrand.us>
Co-authored-by: Steve Karg <skarg@users.sourceforge.net>

zephyr/CMakeLists.txt

@@ -29,6 +29,7 @@ message(STATUS "BACNETSTACK: BACDL_ARCNET \"${CONFIG_BACDL_ARCNET}\"")
 message(STATUS "BACNETSTACK: BACDL_MSTP \"${CONFIG_BACDL_MSTP}\"")
 message(STATUS "BACNETSTACK: BACDL_ETHERNET \"${CONFIG_BACDL_ETHERNET}\"")
 message(STATUS "BACNETSTACK: BACDL_NONE \"${CONFIG_BACDL_NONE}\"")
+message(STATUS "BACNETSTACK: BACNET_ADDRESS_CACHE_FILE \"${CONFIG_BACNET_ADDRESS_CACHE_FILE}\"")
 
 #Do not allow in source builds
 set(CMAKE_DISABLE_SOURCE_CHANGES ON)
@@ -205,6 +206,8 @@ set(BACNETSTACK_SRCS
     ${BACNETSTACK_SRC}/bacnet/basic/services.h
     ${BACNETSTACK_SRC}/bacnet/basic/sys/bigend.c
     ${BACNETSTACK_SRC}/bacnet/basic/sys/bigend.h
+    ${BACNETSTACK_SRC}/bacnet/basic/sys/days.c
+    ${BACNETSTACK_SRC}/bacnet/basic/sys/days.h
     ${BACNETSTACK_SRC}/bacnet/basic/sys/debug.c
     ${BACNETSTACK_SRC}/bacnet/basic/sys/debug.h
     ${BACNETSTACK_SRC}/bacnet/basic/sys/fifo.c
@@ -316,7 +319,7 @@ set(BACNETSTACK_BASIC_SRCS
     ${BACNETSTACK_SRC}/bacnet/basic/object/access_zone.c
     ${BACNETSTACK_SRC}/bacnet/basic/object/acc.c
     ${BACNETSTACK_SRC}/bacnet/basic/object/ao.c
-    ${BACNETSTACK_SRC}/bacnet/basic/object/bacfile.c # Build error: fseek not supported in Zephyr
+    ${BACNETSTACK_SRC}/bacnet/basic/object/bacfile.c
     ${BACNETSTACK_SRC}/bacnet/basic/object/bi.c
     ${BACNETSTACK_SRC}/bacnet/basic/object/bo.c
     ${BACNETSTACK_SRC}/bacnet/basic/object/bv.c
@@ -424,6 +427,7 @@ zephyr_library_compile_definitions(
   $<$<BOOL:${CONFIG_BACNET_ROUTING}>:BACNET_ROUTING>
   $<$<BOOL:${CONFIG_BACAPP_PRINT_ENABLED}>:BACAPP_PRINT_ENABLED=1>
   $<$<BOOL:${CONFIG_BACAPP_SNPRINTF_ENABLED}>:BACAPP_SNPRINTF_ENABLED=1>
+  $<$<BOOL:${CONFIG_BACNET_ADDRESS_CACHE_FILE}>:BACNET_ADDRESS_CACHE_FILE=1>
   )
 
 zephyr_library_sources(
@@ -448,6 +452,7 @@ target_compile_definitions(
   $<$<BOOL:${CONFIG_BACNET_ROUTING}>:BACNET_ROUTING>
   $<$<BOOL:${CONFIG_BACAPP_PRINT_ENABLED}>:BACAPP_PRINT_ENABLED=1>
   $<$<BOOL:${CONFIG_BACAPP_SNPRINTF_ENABLED}>:BACAPP_SNPRINTF_ENABLED=1>
+  $<$<BOOL:${CONFIG_BACNET_ADDRESS_CACHE_FILE}>:BACNET_ADDRESS_CACHE_FILE=1>
   BACNET_STACK_STATIC_DEFINE
   PRINT_ENABLED=1
   )

zephyr/Kconfig

@@ -101,6 +101,11 @@ config BACDL_BIP6_PORT
 	help
 		UDP port to listen on (default=47808)
 
+config BACNET_ADDRESS_CACHE_FILE
+	bool "BACnet Address Cache file functionality"
+	help
+		BACnet Address Cache file functionality
+
 rsource "subsys/Kconfig"
 
 endif # BACNETSTACK

zephyr/tests/bacnet/basic/binding/address/prj.conf

@@ -1,2 +1,3 @@
 CONFIG_ZTEST=y
 CONFIG_BACNETSTACK=y
+CONFIG_BACNET_ADDRESS_CACHE_FILE=y

zephyr/tests/bacnet/datalink/bvlc/prj.conf

@@ -1,2 +1,25 @@
 CONFIG_ZTEST=y
 CONFIG_BACNETSTACK=y
+
+# BIP Options
+CONFIG_BACDL_BIP=y
+CONFIG_BACDL_BIP_PORT=47808
+CONFIG_BACDL_BIP_ADDRESS_INDEX=0
+
+# pthreads
+CONFIG_POSIX_API=y
+CONFIG_PTHREAD_IPC=y
+CONFIG_POSIX_MQUEUE=y
+
+# networking
+CONFIG_NETWORKING=y
+CONFIG_NET_IPV4=y
+CONFIG_NET_ARP=y
+CONFIG_NET_TCP=y
+CONFIG_NET_UDP=y
+CONFIG_NET_DHCPV4=y
+
+CONFIG_NET_MGMT=y
+CONFIG_NET_MGMT_EVENT=y
+
+CONFIG_LOG=y