Issue 187 enable skipped ztest suites (#189)

* Fix some ztests that were skipped

* Expose bacapp_same_value()

* Fix bacapp, ptransfer tests

* Fix bugs in Load_Control object & tests

* refactor days functions from datetime module

* fix legacy ctests

* Add bacnet/basic/sys/days.[ch] to Zephyr build

* Update ztest to match from Zephyr v2.6.0; update ringbuf, datetime to build

* Fixup ztest test for object/acc

* Fix bvlc_address_from_ascii; enable/fix bvlc test

* Comment cleanup

* test/bacnet/basic/object/lc partially enabled

* Fix bacapp_decode_data_len return status on erroneous input

* fix ztest include fatal error

* fix ztest strsignal reference fatal error

* fix zassert_mem_equal reference syntax error

* fix zassert_mem_equal reference syntax error

Co-authored-by: Gregory Shue <gregory.shue@legrand.us>
Co-authored-by: Steve Karg <skarg@users.sourceforge.net>

test/ztest/include/ztest.h

@@ -2,34 +2,29 @@
  * Copyright (c) 2016 Intel Corporation
  *
  * SPDX-License-Identifier: Apache-2.0
- *
- * Modified from zephyr_v2.2.0 subsys/testsuite/ztest/include/ztest.h
- * because:
- *   1. This port will never be run in the Zephyr kernel.
- *      This repository is extended to be a Zephyr module for that.
- *   2. This port will not support multiple CPUs or toolchains.
- *
- * Modifications:
- *   a. Code conditionally compiled on the following CPP symbols were deleted
- *      (as they were kernel-specific):
- *        KERNEL
  */
 
 /**
  * @file
  *
- * @brief Zephyr testing suite
+ * @brief Zephyr Testsuite
+ *
+ * From zephyr_v2.6.0 subsys/testsuite/ztest/include/ztest.h
+ * Note:
+ *   1. This port will never be run in the Zephyr kernel.
+ *      This repository is extended to be a Zephyr module for that.
+ *   2. This port will not support multiple CPUs or toolchains.
  */
 
 /**
- * @brief Zephyr Tests
+ * @brief Zephyr Tests (ZTest)
  * @defgroup all_tests Zephyr Tests
  * @{
  * @}
  */
 
-#ifndef __ZTEST_H__
-#define __ZTEST_H__
+#ifndef ZEPHYR_TESTSUITE_INCLUDE_ZTEST_H_
+#define ZEPHYR_TESTSUITE_INCLUDE_ZTEST_H_
 
 /**
  * @defgroup ztest Zephyr testing suite
@@ -39,6 +34,7 @@
 #error "You need to add CONFIG_ZTEST to your config file."
 #endif
 
+#ifndef KERNEL
 #define CONFIG_STDOUT_CONSOLE 1
 #define CONFIG_ZTEST_ASSERT_VERBOSE 1
 #define CONFIG_ZTEST_MOCKING
@@ -48,6 +44,7 @@
 #define CONFIG_MP_NUM_CPUS 1
 #define CONFIG_SYS_CLOCK_TICKS_PER_SEC 100
 #define CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC 10000000
+#define ARCH_STACK_PTR_ALIGN 8
 /* FIXME: Properly integrate with Zephyr's arch specific code */
 #define CONFIG_X86 1
 #define CONFIG_PRINTK 1
@@ -59,6 +56,7 @@ typedef struct esf z_arch_esf_t;
 #ifdef __cplusplus
 }
 #endif
+#endif /* KERNEL */
 
 #include <sys/printk.h>
 #define PRINT printk
@@ -80,4 +78,4 @@ void test_main(void);
 }
 #endif
 
-#endif /* __ZTEST_H__ */
+#endif /* ZEPHYR_TESTSUITE_INCLUDE_ZTEST_H_ */