Issue 187 enable skipped ztest suites (#189)

* Fix some ztests that were skipped

* Expose bacapp_same_value()

* Fix bacapp, ptransfer tests

* Fix bugs in Load_Control object & tests

* refactor days functions from datetime module

* fix legacy ctests

* Add bacnet/basic/sys/days.[ch] to Zephyr build

* Update ztest to match from Zephyr v2.6.0; update ringbuf, datetime to build

* Fixup ztest test for object/acc

* Fix bvlc_address_from_ascii; enable/fix bvlc test

* Comment cleanup

* test/bacnet/basic/object/lc partially enabled

* Fix bacapp_decode_data_len return status on erroneous input

* fix ztest include fatal error

* fix ztest strsignal reference fatal error

* fix zassert_mem_equal reference syntax error

* fix zassert_mem_equal reference syntax error

Co-authored-by: Gregory Shue <gregory.shue@legrand.us>
Co-authored-by: Steve Karg <skarg@users.sourceforge.net>

src/bacnet/datalink/bvlc.c

@@ -2140,7 +2140,7 @@ bool bvlc_address_get(BACNET_IP_ADDRESS *addr,
  */
 bool bvlc_address_from_ascii(BACNET_IP_ADDRESS *addr, const char *addrstr)
 {
-    unsigned char tmp = 0;
+    uint16_t tmp = 0;
     char c = 0;
     unsigned char i = 0, j = 0;
     uint8_t charsread = 0;
@@ -2151,6 +2151,7 @@ bool bvlc_address_from_ascii(BACNET_IP_ADDRESS *addr, const char *addrstr)
     if (!addrstr) {
         return false;
     }
+
     for (i = 0; i < 4; ++i) {
         j = 0;
         do {
@@ -2160,10 +2161,13 @@ bool bvlc_address_from_ascii(BACNET_IP_ADDRESS *addr, const char *addrstr)
                 return false;
             }
             if ((c == '.') || (c == 0) || (c == ' ')) {
-                addr->address[i] = tmp;
+                addr->address[i] = (uint8_t) tmp;
                 tmp = 0;
             } else if ((c >= '0') && (c <= '9')) {
                 tmp = (tmp * 10) + (c - '0');
+		if (tmp > UINT8_MAX) {
+                    return false;
+		}
             } else {
                 return false;
             }