dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed copy and compare API of BACnetObjectPropertyReference structure. (#1171)

Browse Source
This commit is contained in:
Steve Karg
2025-12-02 16:54:10 -06:00
committed by GitHub
parent e7f1101808
commit 8991c56b70
3 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+1
View File
@@ -43,6 +43,7 @@ The git repositories are hosted at the following sites:
### Fixed ### Fixed
* Fixed copy and compare API of BACnetObjectPropertyReference structure. (#1171)
* Fixed array-bounds on BACnetObjectPropertyReference parsing. (#1167) * Fixed array-bounds on BACnetObjectPropertyReference parsing. (#1167)
* Fixed the missing BACnetObjectPropertyReference, * Fixed the missing BACnetObjectPropertyReference,
BACnetSCFailedConnectionRequest, BACnetSCHubFunctionConnection, BACnetSCFailedConnectionRequest, BACnetSCHubFunctionConnection,
src/bacnet/bacdevobjpropref.c
+3 -1
View File
@@ -862,7 +862,8 @@ bool bacnet_object_property_reference_same(
(value1->object_identifier.instance == (value1->object_identifier.instance ==
value2->object_identifier.instance) && value2->object_identifier.instance) &&
(value1->object_identifier.type == (value1->object_identifier.type ==
value2->object_identifier.type)) { value2->object_identifier.type) &&
(value1->property_array_index == value2->property_array_index)) {
status = true; status = true;
} }
} }
@@ -886,6 +887,7 @@ bool bacnet_object_property_reference_copy(
dest->property_identifier = src->property_identifier; dest->property_identifier = src->property_identifier;
dest->object_identifier.instance = src->object_identifier.instance; dest->object_identifier.instance = src->object_identifier.instance;
dest->object_identifier.type = src->object_identifier.type; dest->object_identifier.type = src->object_identifier.type;
dest->property_array_index = src->property_array_index;
status = true; status = true;
} }
src/bacnet/basic/object/loop.c
+5 -6
View File
@@ -1432,13 +1432,12 @@ bool Loop_COV_Increment_Set(uint32_t object_instance, float value)
int Loop_Read_Property(BACNET_READ_PROPERTY_DATA *rpdata) int Loop_Read_Property(BACNET_READ_PROPERTY_DATA *rpdata)
{ {
int apdu_len = 0; /* return value */ int apdu_len = 0; /* return value */
BACNET_BIT_STRING bit_string; BACNET_BIT_STRING bit_string = { 0 };
BACNET_CHARACTER_STRING char_string; BACNET_CHARACTER_STRING char_string = { 0 };
BACNET_UNSIGNED_INTEGER unsigned_value; BACNET_UNSIGNED_INTEGER unsigned_value = 0;
BACNET_OBJECT_PROPERTY_REFERENCE reference_value; BACNET_OBJECT_PROPERTY_REFERENCE reference_value = { 0 };
float real_value; float real_value = 0.0f;
uint8_t *apdu = NULL; uint8_t *apdu = NULL;
uint32_t enum_value = 0; uint32_t enum_value = 0;
bool state = false; bool state = false;