dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed Device_Write_Property_Object_Name() to return WRITE_ACCESS_DENIED in case where an object name is not writable using BACnet protocol. (#927)

Browse Source
This commit is contained in:
Steve Karg
2025-02-26 17:00:51 -06:00
committed by GitHub
parent 2f5b45c542
commit 849cbb238b
7 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/blinkt/device.c
+2 -2
View File
@@ -1720,8 +1720,8 @@ static bool Device_Write_Property_Object_Name(
if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) { if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) {
if ((object_type == wp_data->object_type) && if ((object_type == wp_data->object_type) &&
(object_instance == wp_data->object_instance)) { (object_instance == wp_data->object_instance)) {
/* writing same name to same object */ /* writing same name to same object - but is it writable? */
status = true; status = Object_Write_Property(wp_data);
} else { } else {
/* name already exists in some object */ /* name already exists in some object */
wp_data->error_class = ERROR_CLASS_PROPERTY; wp_data->error_class = ERROR_CLASS_PROPERTY;
apps/piface/device.c
+2 -2
View File
@@ -1672,8 +1672,8 @@ static bool Device_Write_Property_Object_Name(
if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) { if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) {
if ((object_type == wp_data->object_type) && if ((object_type == wp_data->object_type) &&
(object_instance == wp_data->object_instance)) { (object_instance == wp_data->object_instance)) {
/* writing same name to same object */ /* writing same name to same object - but is it writable? */
status = true; status = Object_Write_Property(wp_data);
} else { } else {
/* name already exists in some object */ /* name already exists in some object */
wp_data->error_class = ERROR_CLASS_PROPERTY; wp_data->error_class = ERROR_CLASS_PROPERTY;
ports/at91sam7s/device.c
+2 -2
View File
@@ -238,8 +238,8 @@ static bool Device_Write_Property_Object_Name(
if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) { if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) {
if ((object_type == wp_data->object_type) && if ((object_type == wp_data->object_type) &&
(object_instance == wp_data->object_instance)) { (object_instance == wp_data->object_instance)) {
/* writing same name to same object */ /* writing same name to same object - but is it writable? */
status = true; status = Object_Write_Property(wp_data);
} else { } else {
/* name already exists in some object */ /* name already exists in some object */
wp_data->error_class = ERROR_CLASS_PROPERTY; wp_data->error_class = ERROR_CLASS_PROPERTY;
ports/bdk-atxx4-mstp/device.c
+2 -2
View File
@@ -205,8 +205,8 @@ static bool Device_Write_Property_Object_Name(
if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) { if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) {
if ((object_type == wp_data->object_type) && if ((object_type == wp_data->object_type) &&
(object_instance == wp_data->object_instance)) { (object_instance == wp_data->object_instance)) {
/* writing same name to same object */ /* writing same name to same object - but is it writable? */
status = true; status = Object_Write_Property(wp_data);
} else { } else {
/* name already exists in some object */ /* name already exists in some object */
wp_data->error_class = ERROR_CLASS_PROPERTY; wp_data->error_class = ERROR_CLASS_PROPERTY;
ports/stm32f4xx/device.c
+2 -2
View File
@@ -1173,8 +1173,8 @@ static bool Device_Write_Property_Object_Name(
if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) { if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) {
if ((object_type == wp_data->object_type) && if ((object_type == wp_data->object_type) &&
(object_instance == wp_data->object_instance)) { (object_instance == wp_data->object_instance)) {
/* writing same name to same object */ /* writing same name to same object - but is it writable? */
status = true; status = Object_Write_Property(wp_data);
} else { } else {
/* name already exists in some object */ /* name already exists in some object */
wp_data->error_class = ERROR_CLASS_PROPERTY; wp_data->error_class = ERROR_CLASS_PROPERTY;
src/bacnet/basic/object/client/device-client.c
+2 -2
View File
@@ -1282,8 +1282,8 @@ static bool Device_Write_Property_Object_Name(
if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) { if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) {
if ((object_type == wp_data->object_type) && if ((object_type == wp_data->object_type) &&
(object_instance == wp_data->object_instance)) { (object_instance == wp_data->object_instance)) {
/* writing same name to same object */ /* writing same name to same object - but is it writable? */
status = true; status = Object_Write_Property(wp_data);
} else { } else {
/* name already exists in some object */ /* name already exists in some object */
wp_data->error_class = ERROR_CLASS_PROPERTY; wp_data->error_class = ERROR_CLASS_PROPERTY;
src/bacnet/basic/object/device.c
+2 -2
View File
@@ -1954,8 +1954,8 @@ static bool Device_Write_Property_Object_Name(
if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) { if (Device_Valid_Object_Name(&value, &object_type, &object_instance)) {
if ((object_type == wp_data->object_type) && if ((object_type == wp_data->object_type) &&
(object_instance == wp_data->object_instance)) { (object_instance == wp_data->object_instance)) {
/* writing same name to same object */ /* writing same name to same object - but is it writable? */
status = true; status = Object_Write_Property(wp_data);
} else { } else {
/* name already exists in some object */ /* name already exists in some object */
wp_data->error_class = ERROR_CLASS_PROPERTY; wp_data->error_class = ERROR_CLASS_PROPERTY;