diff --git a/apps/mstpcap/main.c b/apps/mstpcap/main.c index db664a20..4da985a0 100644 --- a/apps/mstpcap/main.c +++ b/apps/mstpcap/main.c @@ -513,7 +513,7 @@ static size_t data_write(const void *ptr, size_t size, size_t nitems) ssize_t bytes = 0; if (FD_Pipe != -1) { bytes = write(FD_Pipe, ptr, size * nitems); - bytes = bytes; + (void)bytes; } return fwrite(ptr, size, nitems, pFile); } @@ -524,7 +524,7 @@ static size_t data_write_header( ssize_t bytes = 0; if (pipe_enable && (FD_Pipe != -1)) { bytes = write(FD_Pipe, ptr, size * nitems); - bytes = bytes; + (void)bytes; } return fwrite(ptr, size, nitems, pFile); } @@ -1181,8 +1181,8 @@ int main(int argc, char *argv[]) } if (!Wireshark_Capture) { if (!(packet_count % 100)) { - fprintf(stdout, "\r%hu packets, %hu invalid frames", - packet_count, Invalid_Frame_Count); + fprintf(stdout, "\r%u packets, %u invalid frames", + (unsigned)packet_count, (unsigned)Invalid_Frame_Count); } if (packet_count >= 65535) { packet_statistics_print(); diff --git a/apps/whois/main.c b/apps/whois/main.c index b795615a..fb8d90e3 100644 --- a/apps/whois/main.c +++ b/apps/whois/main.c @@ -252,7 +252,7 @@ static void print_address_cache(void) } else { print_macaddr(&local_sadr, 1); } - printf(" %-4hu ", addr->max_apdu); + printf(" %-4u ", (unsigned)addr->max_apdu); printf("\n"); addr = addr->next; diff --git a/src/bacnet/alarm_ack.c b/src/bacnet/alarm_ack.c index 47072b6a..1ded3d89 100644 --- a/src/bacnet/alarm_ack.c +++ b/src/bacnet/alarm_ack.c @@ -114,9 +114,7 @@ int alarm_ack_decode_service_request( int section_len; uint32_t enumValue; - /* unused parameter */ - apdu_len = apdu_len; - + (void)apdu_len; if (-1 == (section_len = decode_context_unsigned( &apdu[len], 0, &data->ackProcessIdentifier))) { diff --git a/src/bacnet/basic/binding/address.c b/src/bacnet/basic/binding/address.c index 872005f5..9f7ad2fd 100644 --- a/src/bacnet/basic/binding/address.c +++ b/src/bacnet/basic/binding/address.c @@ -760,7 +760,7 @@ int address_list_encode(uint8_t *apdu, unsigned apdu_len) /* FIXME: I really shouild check the length remaining here but it is fairly pointless until we have the true length remaining in the packet to work with as at the moment it is just MAX_APDU */ - apdu_len = apdu_len; + (void)apdu_len; /* look for matching address */ pMatch = Address_Cache; while (pMatch <= &Address_Cache[MAX_ADDRESS_CACHE - 1]) { diff --git a/src/bacnet/basic/object/client/device-client.c b/src/bacnet/basic/object/client/device-client.c index f20f70ef..dfe5a978 100644 --- a/src/bacnet/basic/object/client/device-client.c +++ b/src/bacnet/basic/object/client/device-client.c @@ -263,7 +263,7 @@ unsigned Device_Count(void) uint32_t Device_Index_To_Instance(unsigned index) { - index = index; + (void)index; return Object_Instance_Number; } diff --git a/src/bacnet/basic/object/device.c b/src/bacnet/basic/object/device.c index 666d97e3..342ae04a 100644 --- a/src/bacnet/basic/object/device.c +++ b/src/bacnet/basic/object/device.c @@ -523,7 +523,7 @@ unsigned Device_Count(void) uint32_t Device_Index_To_Instance(unsigned index) { - index = index; + (void)index; return Object_Instance_Number; } diff --git a/src/bacnet/basic/object/trendlog.c b/src/bacnet/basic/object/trendlog.c index b18888a6..c1387d5d 100644 --- a/src/bacnet/basic/object/trendlog.c +++ b/src/bacnet/basic/object/trendlog.c @@ -1726,8 +1726,7 @@ void trend_log_timer(uint16_t uSeconds) int iCount = 0; time_t tNow = 0; - /* unused parameter */ - uSeconds = uSeconds; + (void)uSeconds; /* use OS to get the current time */ tNow = time(NULL); for (iCount = 0; iCount < MAX_TREND_LOGS; iCount++) { diff --git a/src/bacnet/basic/service/h_cov.c b/src/bacnet/basic/service/h_cov.c index 111e05a8..3355a3a1 100644 --- a/src/bacnet/basic/service/h_cov.c +++ b/src/bacnet/basic/service/h_cov.c @@ -212,8 +212,7 @@ static int cov_encode_subscription( BACNET_OCTET_STRING octet_string; BACNET_ADDRESS *dest = NULL; - /* FIXME: unused parameter */ - max_apdu = max_apdu; + (void)max_apdu; if (!cov_subscription) { return 0; } diff --git a/src/bacnet/basic/service/h_ucov.c b/src/bacnet/basic/service/h_ucov.c index a890898e..f789e505 100644 --- a/src/bacnet/basic/service/h_ucov.c +++ b/src/bacnet/basic/service/h_ucov.c @@ -65,7 +65,7 @@ void handler_ucov_notification( int len = 0; /* src not needed for this application */ - src = src; + (void)src; /* create linked list to store data if more than one property value is expected */ bacapp_property_value_list_init(&property_value[0], MAX_COV_PROPERTIES); diff --git a/src/bacnet/basic/sys/debug.c b/src/bacnet/basic/sys/debug.c index 0262d6d0..ebc9b134 100644 --- a/src/bacnet/basic/sys/debug.c +++ b/src/bacnet/basic/sys/debug.c @@ -56,6 +56,6 @@ void debug_printf(const char *format, ...) #else void debug_printf(const char *format, ...) { - format = format; + (void)format; } #endif diff --git a/src/bacnet/datalink/mstp.c b/src/bacnet/datalink/mstp.c index 1482b14c..f71b7922 100644 --- a/src/bacnet/datalink/mstp.c +++ b/src/bacnet/datalink/mstp.c @@ -72,7 +72,7 @@ #else static inline void printf_receive(const char *format, ...) { - format = format; + (void)format; } #endif @@ -81,7 +81,7 @@ static inline void printf_receive(const char *format, ...) #else static inline void printf_receive_data(const char *format, ...) { - format = format; + (void)format; } #endif @@ -90,7 +90,7 @@ static inline void printf_receive_data(const char *format, ...) #else static inline void printf_receive_error(const char *format, ...) { - format = format; + (void)format; } #endif @@ -99,7 +99,7 @@ static inline void printf_receive_error(const char *format, ...) #else static inline void printf_master(const char *format, ...) { - format = format; + (void)format; } #endif diff --git a/src/bacnet/getevent.c b/src/bacnet/getevent.c index a95aff5c..c0f780fe 100644 --- a/src/bacnet/getevent.c +++ b/src/bacnet/getevent.c @@ -111,8 +111,7 @@ int getevent_ack_encode_apdu_data(uint8_t *apdu, BACNET_GET_EVENT_INFORMATION_DATA *event_data; unsigned i = 0; /* counter */ - /* unused parameter */ - max_apdu = max_apdu; + (void)max_apdu; if (apdu) { event_data = get_event_data; while (event_data) { @@ -158,8 +157,7 @@ int getevent_ack_encode_apdu_end( { int apdu_len = 0; /* total length of the apdu, return value */ - /* unused parameter */ - max_apdu = max_apdu; + (void)max_apdu; if (apdu) { apdu_len += encode_closing_tag(&apdu[apdu_len], 0); apdu_len += encode_context_boolean(&apdu[apdu_len], 1, moreEvents); diff --git a/src/bacnet/lighting.c b/src/bacnet/lighting.c index 783e2571..9f2627eb 100644 --- a/src/bacnet/lighting.c +++ b/src/bacnet/lighting.c @@ -129,7 +129,7 @@ int lighting_command_decode( uint32_t unsigned_value = 0; float real_value = 0.0; - apdu_max_len = apdu_max_len; + (void)apdu_max_len; /* check for value pointers */ if (apdu_max_len && data) { /* Tag 0: operation */ diff --git a/src/bacnet/ptransfer.c b/src/bacnet/ptransfer.c index 93aea2c0..00e89ca9 100644 --- a/src/bacnet/ptransfer.c +++ b/src/bacnet/ptransfer.c @@ -54,7 +54,7 @@ static int pt_encode_apdu(uint8_t *apdu, } */ /* unused parameter */ - max_apdu = max_apdu; + (void)max_apdu; if (apdu) { len = encode_context_unsigned(&apdu[apdu_len], 0, private_data->vendorID);