dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed lines marked with "dangerous cast" to use memcpy.

Browse Source
This commit is contained in:
skarg
2010-11-06 01:27:11 +00:00
parent d50eb7fef7
commit 80185c6a63
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bacnet-stack/src/bvlc.c
+4 -4
View File
@@ -533,13 +533,13 @@ static bool bvlc_create_bdt(
for (i = 0; i < MAX_BBMD_ENTRIES; i++) { for (i = 0; i < MAX_BBMD_ENTRIES; i++) {
if (npdu_length >= 10) { if (npdu_length >= 10) {
BBMD_Table[i].valid = true; BBMD_Table[i].valid = true;
BBMD_Table[i].dest_address.s_addr = *(long *) &npdu[pdu_offset]; /* FIXME: dangerous casting */ memcpy(&BBMD_Table[i].dest_address.s_addr, &npdu[pdu_offset], 4);
pdu_offset += 4; pdu_offset += 4;
BBMD_Table[i].dest_port = *(short *) &npdu[pdu_offset]; /* FIXME: dangerous casting */ memcpy(&BBMD_Table[i].dest_port, &npdu[pdu_offset], 2);
pdu_offset += 2; pdu_offset += 2;
BBMD_Table[i].broadcast_mask.s_addr = *(long *) &npdu[pdu_offset]; /* FIXME: dangerous casting */ memcpy(&BBMD_Table[i].broadcast_mask.s_addr, &npdu[pdu_offset], 4);
pdu_offset += 4; pdu_offset += 4;
npdu_length -= 10; npdu_length -= (4+2+4);
} else { } else {
BBMD_Table[i].valid = false; BBMD_Table[i].valid = false;
BBMD_Table[i].dest_address.s_addr = 0; BBMD_Table[i].dest_address.s_addr = 0;