Schedule encoding/decoding (#319)

* schedule: add decode_daily_schedule() and encode_daily_schedule() * schedule: encode/decode implemented + add to bacapp * add safe encode/decode functions for timevalue, schedule function renaming * fix unit tests build failing * add IDEA and test temporary files to .gitignore * try to make "deprecated" work in MSVC * add WeeklySchedule compare function * add bacnet_weeklyschedule_context_decode() * Add basic test for WeeklySchedule * Fix WeeklySchedule parsing and snprintf, decoder verified with real hardware * try to fix windows build * improve boolean parsing in 'bacapp_parse_application_data' * add parse function for weekly schedule * allow types > 16 in bacwp, show the decoded value before sending * add bacapp binaries to gitignore * remove bacwp logging * Add error checking to bacapp_parse_application_data * try to fix windows build * fix avr build * Fix error handling in RP Ack * add singleDay flag * show day name in single day weeklyschedule snprintf * show weeklyschedule inner tag in snprintf * improve weeklyschedule parsing and printing, supports type names now * add weekly schedule to bacapp_decode_data * move bacnet/bacnet_plat_compat.h to bacnet/basic/sys/platform.h * disable tag limit also in bacwpm * add ifdef's around strtoX helper functions in bacapp * move strtox to BACAPP_PRINT_ENABLED ifdef in bacapp * fix stm32 makefiles * fix at91sam7s build * use BACNET_UNSIGNED_INTEGER in BACnet_Short_Application_Data_Value * fix capitalization in BACnet_Daily_Schedule * add name to BACNET_TIME_VALUE struct * change bacwp bacwpm to use bacapp_known_property_tag() * fix some macros in bacdcode missing parentheses * Remove dummy fields from BACNET_SHORT_APPLICATION_DATA_VALUE, replace remaining uses of upcasting (adds extra overhead but is maybe safer), rename short DV to Primitive * fix new ci warnings * more fixes for ancient C * fix tests no longer building * primitive value renamed to shorter name
2022-09-05 16:27:15 +02:00
parent bd40c51e19
commit 7cdab61d72
66 changed files with 1800 additions and 108 deletions
@@ -0,0 +1,103 @@
+/**
+ * @file
+ * @brief Unit test for BACnetWeeklySchedule
+ * @author Ondřej Hruška <ondra@ondrovo.com>
+ * @date Aug 2022
+ *
+ * SPDX-License-Identifier: MIT
+ */
+
+#include <stdint.h>
+#include <stdbool.h>
+#include <string.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <ctype.h>
+#include <ztest.h>
+#include "bacnet/bactimevalue.h"
+#include "bacnet/weeklyschedule.h"
+#include "bacnet/dailyschedule.h"
+#include "bacnet/datetime.h"
+#include "bacnet/bacapp.h"
+
+
+/**
+ * @addtogroup bacnet_tests
+ * @{
+ */
+
+/**
+ * @brief Test encode/decode API
+ */
+static void test_BACnetWeeklySchedule()
+{
+    int len, apdu_len;
+    uint8_t apdu[MAX_APDU] = { 0 };
+    BACNET_WEEKLY_SCHEDULE empty_value = { 0 };
+    BACNET_WEEKLY_SCHEDULE value = { 0 };
+    BACNET_WEEKLY_SCHEDULE decoded = { 0 };
+    int diff = 0;
+    bool status = false;
+    uint8_t tag_number = 0;
+
+    value.weeklySchedule[0].TV_Count = 2;
+
+    value.weeklySchedule[0].Time_Values[0].Time = (BACNET_TIME) {
+        .hour = 5,
+        .min = 30
+    };
+    value.weeklySchedule[0].Time_Values[0].Value = (BACNET_PRIMITIVE_DATA_VALUE) {
+        .tag = BACNET_APPLICATION_TAG_UNSIGNED_INT,
+        .type.Unsigned_Int = 123,
+    };
+
+    value.weeklySchedule[0].Time_Values[1].Time = (BACNET_TIME) {
+        .hour = 15,
+        .min = 0
+    };
+    value.weeklySchedule[0].Time_Values[1].Value = (BACNET_PRIMITIVE_DATA_VALUE) {
+        .tag = BACNET_APPLICATION_TAG_UNSIGNED_INT,
+        .type.Unsigned_Int = 456,
+    };
+
+    value.weeklySchedule[6].TV_Count = 1;
+    value.weeklySchedule[6].Time_Values[0].Value = (BACNET_PRIMITIVE_DATA_VALUE) {
+        .tag = BACNET_APPLICATION_TAG_UNSIGNED_INT,
+        .type.Unsigned_Int = 777,
+    };
+
+
+    len = bacnet_weeklyschedule_encode(apdu, &value);
+    apdu_len = bacnet_weeklyschedule_decode(apdu, len, &decoded);
+    zassert_true(len > 0, NULL);
+    zassert_true(apdu_len > 0, NULL);
+    status = bacnet_weeklyschedule_same(&value, &decoded);
+    zassert_true(status, NULL);
+    // Check that the compare function really compares:
+    status = bacnet_weeklyschedule_same(&empty_value, &decoded);
+    zassert_false(status, NULL);
+
+    len = bacnet_weeklyschedule_context_encode(apdu, tag_number, &value);
+    apdu_len = bacnet_weeklyschedule_context_decode(apdu, len, tag_number, &decoded);
+    zassert_true(len > 0, NULL);
+    zassert_true(apdu_len > 0, NULL);
+    status = bacnet_weeklyschedule_same(&value, &decoded);
+    zassert_true(status, NULL);
+
+    /* negative testing - the tag differs */
+    tag_number++;
+    apdu_len = bacnet_weeklyschedule_context_decode(apdu, len, tag_number, &decoded);
+    zassert_true(apdu_len < 0, NULL);
+}
+
+/**
+ * @}
+ */
+void test_main(void)
+{
+    ztest_test_suite(BACnetWeeklySchedule_tests,
+     ztest_unit_test(test_BACnetWeeklySchedule)
+     );
+
+    ztest_run_test_suite(BACnetWeeklySchedule_tests);
+}