dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed usage of 8-bit modulo operator off-by-one maximum. (#901)

Browse Source
This commit is contained in:
Steve Karg
2025-02-04 13:56:53 -06:00
committed by GitHub
parent 19ef7f74cd
commit 77bdaaf853
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/bacnet/basic/sys/ringbuf/src/main.c
+2 -2
View File
@@ -45,7 +45,7 @@ static void testRingAroundBuffer(
/* test the ring around the buffer */
for (index = 0; index < element_count; index++) {
for (count = 1; count < 4; count++) {
value = (index * count) % 255;
value = (index * count) % 256;
for (data_index = 0; data_index < element_size; data_index++) {
data_element[data_index] = value;
}
@@ -54,7 +54,7 @@ static void testRingAroundBuffer(
zassert_equal(Ringbuf_Count(test_buffer), count, NULL);
}
for (count = 1; count < 4; count++) {
value = (index * count) % 255;
value = (index * count) % 256;
test_data = Ringbuf_Peek(test_buffer);
zassert_not_null(test_data, NULL);
if (test_data) {
test/bacnet/datalink/cobs/src/main.c
+1 -1
View File
@@ -38,7 +38,7 @@ static void test_COBS_Encode_Decode(void)
size_t encoded_buffer_length, test_buffer_length;
for (i = 2; i < sizeof(buffer); i++) {
buffer[i] = i % 0xff;
buffer[i] = i % 256;
}
encoded_buffer_length = cobs_frame_encode(
encoded_buffer, sizeof(encoded_buffer), buffer, sizeof(buffer));