Fixed usage of 8-bit modulo operator off-by-one maximum. (#901)

src/bacnet/datalink/bsc/bsc-util.c

@@ -97,7 +97,7 @@ void bsc_generate_random_vmac(BACNET_SC_VMAC_ADDRESS *p)
     int i;
 
     for (i = 0; i < BVLC_SC_VMAC_SIZE; i++) {
-        p->address[i] = rand() % 255;
+        p->address[i] = rand() % 256;
         if (i == 0) {
             /* According H.7.3 EUI-48 and Random-48 VMAC Address:
                The Random-48 VMAC is a 6-octet VMAC address in which the least
@@ -120,7 +120,7 @@ void bsc_generate_random_uuid(BACNET_SC_UUID *p)
     int i;
 
     for (i = 0; i < BVLC_SC_UUID_SIZE; i++) {
-        p->uuid[i] = rand() % 255;
+        p->uuid[i] = rand() % 256;
     }
     debug_printf_hex(0, p->uuid, BVLC_SC_UUID_SIZE, "bsc_generate_random_uuid");
 }

src/bacnet/datalink/mstp.c

@@ -1352,7 +1352,7 @@ void MSTP_Zero_Config_UUID_Init(struct mstp_port_struct_t *mstp_port)
     }
     /* 1. Generate 16 random bytes = 128 bits */
     for (i = 0; i < MSTP_UUID_SIZE; i++) {
-        mstp_port->UUID[i] = rand() % 255;
+        mstp_port->UUID[i] = rand() % 256;
     }
     /* 2. Adjust certain bits according to RFC 4122 section 4.4.
        This just means do the following