dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix receive BVLL Forwarded-NPDU message: the received source address is in network data format and it has to be stored in the same format.

Browse Source 
Note: the encode_ and decode_ functions are broken; they ignore host's endianness.
This commit is contained in:
bacpack
2010-10-27 14:50:52 +00:00
parent feb44efb87
commit 76260a994d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bacnet-stack/src/bip.c
+3 -2
View File
@@ -312,8 +312,9 @@ uint16_t bip_receive(
} }
} }
} else if (pdu[1] == BVLC_FORWARDED_NPDU) { } else if (pdu[1] == BVLC_FORWARDED_NPDU) {
(void) decode_unsigned32(&pdu[4], (uint32_t *) & sin.sin_addr.s_addr); // next 2 lines - moved data is always in the network format
(void) decode_unsigned16(&pdu[8], &sin.sin_port); *(uint32_t *)&sin.sin_addr.s_addr = *(uint32_t *)&pdu[4];
*(uint16_t *)&sin.sin_port = *(uint16_t *)&pdu[8];
if ((sin.sin_addr.s_addr == htonl(BIP_Address.s_addr)) && if ((sin.sin_addr.s_addr == htonl(BIP_Address.s_addr)) &&
(sin.sin_port == htons(BIP_Port))) { (sin.sin_port == htons(BIP_Port))) {
/* ignore messages from me */ /* ignore messages from me */