Bugfix/confirmed request service decode error (#259)

* Fix confirmed service decode error handling. Thank you, Bryan! Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
2022-05-04 15:33:46 -05:00
parent 3c64869dca
commit 6cd58f469d
5 changed files with 23 additions and 3 deletions
@@ -171,6 +171,10 @@ void apdu_handler(BACNET_ADDRESS *src,
                    &apdu[0], /* APDU data */
                    apdu_len, &service_data, &service_choice, &service_request,
                    &service_request_len);
+                if (len == 0) {
+                    /* service data unable to be decoded - simply drop */
+                    break;
+                }
                if (apdu_confirmed_dcc_disabled(service_choice)) {
                    /* When network communications are completely disabled,
                       only DeviceCommunicationControl and ReinitializeDevice