dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bugfix/confirmed request service decode error (#259)

Browse Source 
* Fix confirmed service decode error handling. Thank you, Bryan!

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
This commit is contained in:
Steve Karg
2022-05-04 15:33:46 -05:00
committed by GitHub
parent 3c64869dca
commit 6cd58f469d
5 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ports/arduino_uno/apdu.c
+4
View File
@@ -108,6 +108,10 @@ void apdu_handler(BACNET_ADDRESS *src,
&apdu[0], /* APDU data */
apdu_len, &service_data, &service_choice, &service_request,
&service_request_len);
if (len == 0) {
/* service data unable to be decoded - simply drop */
break;
}
if (service_choice == SERVICE_CONFIRMED_READ_PROPERTY) {
handler_read_property(service_request, service_request_len,
src, &service_data);
ports/atmega168/apdu.c
+4
View File
@@ -106,6 +106,10 @@ void apdu_handler(BACNET_ADDRESS *src,
&apdu[0], /* APDU data */
apdu_len, &service_data, &service_choice, &service_request,
&service_request_len);
if (len == 0) {
/* service data unable to be decoded - simply drop */
break;
}
if (service_choice == SERVICE_CONFIRMED_READ_PROPERTY) {
handler_read_property(service_request, service_request_len,
src, &service_data);
ports/pic18f6720/apdu.c
+4
View File
@@ -171,6 +171,10 @@ void apdu_handler(BACNET_ADDRESS *src,
&apdu[0], /* APDU data */
apdu_len, &service_data, &service_choice, &service_request,
&service_request_len);
if (len == 0) {
/* service data unable to be decoded - simply drop */
break;
}
if (apdu_confirmed_dcc_disabled(service_choice)) {
/* When network communications are completely disabled,
only DeviceCommunicationControl and ReinitializeDevice
ports/pic18f97j60/apdu.c
+4
View File
@@ -171,6 +171,10 @@ void apdu_handler(BACNET_ADDRESS *src,
&apdu[0], /* APDU data */
apdu_len, &service_data, &service_choice, &service_request,
&service_request_len);
if (len == 0) {
/* service data unable to be decoded - simply drop */
break;
}
if (apdu_confirmed_dcc_disabled(service_choice)) {
/* When network communications are completely disabled,
only DeviceCommunicationControl and ReinitializeDevice