Fixed WriteProperty error code for FD_BBMD_ADDRESS and FD_SUBSCRIPTION_LIFETIME (#925)

* Fixed WriteProperty error code for PROP_FD_BBMD_ADDRESS and PROP_FD_SUBSCRIPTION_LIFETIME properties.  

* Fixed dead-code warning after enabling all datalinks for basic network port object using the property list as the R/W checking for the port type.

src/bacnet/datalink/bvlc6.c

@@ -520,6 +520,30 @@ bool bvlc6_address_different(
     return status;
 }
 
+/**
+ * @brief Set the IPv6 address and port number
+ * @param addr - B/IPv6 address that be set
+ * @param address - B/IPv6 address bytes
+ * @param port - B/IPv6 address port
+ * @return true if the address is set
+ */
+bool bvlc6_address_n_port_set(
+    BACNET_IP6_ADDRESS *addr, uint8_t *address, uint16_t port)
+{
+    bool status = false;
+    unsigned i;
+
+    if (addr) {
+        for (i = 0; i < IP6_ADDRESS_MAX; i += 2) {
+            addr->address[i] = address[i];
+        }
+        addr->port = port;
+        status = true;
+    }
+
+    return status;
+}
+
 /** Set a BVLC Address from 16-bit group chunks
  *
  * Data link layer addressing between B/IPv6 nodes consists of a 128-bit
@@ -1402,7 +1426,6 @@ int bvlc6_decode_delete_foreign_device(
     if (pdu && (pdu_len >= length)) {
         if (vmac_src) {
             decode_unsigned24(&pdu[offset], vmac_src);
-            bytes_consumed = 3;
         }
         offset += 3;
         if (bip6_address) {
@@ -1707,8 +1730,6 @@ int bvlc6_broadcast_distribution_table_list_encode(
             if (apdu) {
                 apdu += len;
             }
-        } else {
-            len = 0;
         }
         /* next entry */
         bdt_entry = bdt_entry->next;