dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added basic timer object, internal state machine, and unit tests (#1123)

Browse Source 
* Added basic timer object, internal state machine, and unit tests

* Added BACnetTimerStateChangeValue encode, decode, parse, print, and diff with unit tests

* Changed handler of add/remove list element to check if the property is a BACnetLIST

* Added BACnetLIST utility for handling WriteProperty to a list.

* Fixed outlier ReadProperty object handlers to return zero when the RP parameter is NULL.
This commit is contained in:
Steve Karg
2025-11-05 15:11:45 -06:00
committed by GitHub
parent 17259b37f3
commit 4dd13cf199
126 changed files with 5509 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/bacnet/basic/binding/address/CMakeLists.txt
+1
View File
@@ -52,6 +52,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/indtext.c
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/weeklyschedule.c
${SRC_DIR}/bacnet/bactimevalue.c
test/bacnet/basic/object/acc/CMakeLists.txt
+1
View File
@@ -52,6 +52,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/access_credential/CMakeLists.txt
+1
View File
@@ -56,6 +56,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/access_door/CMakeLists.txt
+1
View File
@@ -53,6 +53,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/access_point/CMakeLists.txt
+1
View File
@@ -53,6 +53,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/weeklyschedule.c
${SRC_DIR}/bacnet/bactimevalue.c
test/bacnet/basic/object/access_rights/CMakeLists.txt
+1
View File
@@ -55,6 +55,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/property.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/access_user/CMakeLists.txt
+1
View File
@@ -53,6 +53,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/access_zone/CMakeLists.txt
+1
View File
@@ -57,6 +57,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/ai/CMakeLists.txt
+1
View File
@@ -54,6 +54,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/wp.c
test/bacnet/basic/object/ao/CMakeLists.txt
+1
View File
@@ -53,6 +53,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/auditlog/CMakeLists.txt
+1
View File
@@ -57,6 +57,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/indtext.c
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/av/CMakeLists.txt
+1
View File
@@ -54,6 +54,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/wp.c
test/bacnet/basic/object/bacfile/CMakeLists.txt
+1
View File
@@ -60,6 +60,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/bi/CMakeLists.txt
+1
View File
@@ -55,6 +55,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/wp.c
test/bacnet/basic/object/bitstring_value/CMakeLists.txt
+1
View File
@@ -57,6 +57,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/property.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/blo/CMakeLists.txt
+1
View File
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/bo/CMakeLists.txt
+1
View File
@@ -54,6 +54,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/bv/CMakeLists.txt
+1
View File
@@ -55,6 +55,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/calendar/CMakeLists.txt
+1
View File
@@ -55,6 +55,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/wp.c
test/bacnet/basic/object/channel/CMakeLists.txt
+1
View File
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/property.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/color_object/CMakeLists.txt
+1
View File
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/wp.c
test/bacnet/basic/object/color_temperature/CMakeLists.txt
+1
View File
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/wp.c
test/bacnet/basic/object/command/CMakeLists.txt
+1
View File
@@ -54,6 +54,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/credential_data_input/CMakeLists.txt
+1
View File
@@ -57,6 +57,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/csv/CMakeLists.txt
+1
View File
@@ -54,6 +54,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/device/CMakeLists.txt
+2
View File
@@ -80,6 +80,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/basic/object/schedule.c
${SRC_DIR}/bacnet/basic/object/structured_view.c
${SRC_DIR}/bacnet/basic/object/time_value.c
${SRC_DIR}/bacnet/basic/object/timer.c
${SRC_DIR}/bacnet/basic/object/trendlog.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
@@ -100,6 +101,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/property.c
${SRC_DIR}/bacnet/reject.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/iv/CMakeLists.txt
+1
View File
@@ -53,6 +53,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/lc/CMakeLists.txt
+1
View File
@@ -63,6 +63,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/rp.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/lo/CMakeLists.txt
+1
View File
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/lsp/CMakeLists.txt
+1
View File
@@ -54,6 +54,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/lsz/CMakeLists.txt
+1
View File
@@ -55,6 +55,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/ms-input/CMakeLists.txt
+1
View File
@@ -53,6 +53,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/mso/CMakeLists.txt
+1
View File
@@ -54,6 +54,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/msv/CMakeLists.txt
+1
View File
@@ -53,6 +53,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/nc/CMakeLists.txt
+1
View File
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/list_element.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/nc/src/main.c
+4 -4
View File
@@ -285,9 +285,9 @@ static void test_Notification_Class_Recipient_List(void)
list_element.first_failed_element_number = 0;
err = Notification_Class_Add_List_Element(&list_element);
zassert_equal(err, BACNET_STATUS_ERROR, NULL);
zassert_equal(list_element.error_class, ERROR_CLASS_SERVICES, NULL);
zassert_equal(list_element.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(
list_element.error_code, ERROR_CODE_PROPERTY_IS_NOT_A_LIST, NULL);
list_element.error_code, ERROR_CODE_WRITE_ACCESS_DENIED, NULL);
/* valid element, valid property, array element (object is not an array) */
list_element.object_property = PROP_RECIPIENT_LIST;
list_element.array_index = 0;
@@ -346,9 +346,9 @@ static void test_Notification_Class_Recipient_List(void)
list_element.object_property = PROP_ALL;
err = Notification_Class_Remove_List_Element(&list_element);
zassert_equal(err, BACNET_STATUS_ERROR, NULL);
zassert_equal(list_element.error_class, ERROR_CLASS_SERVICES, NULL);
zassert_equal(list_element.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(
list_element.error_code, ERROR_CODE_PROPERTY_IS_NOT_A_LIST, NULL);
list_element.error_code, ERROR_CODE_WRITE_ACCESS_DENIED, NULL);
/* invalid array */
list_element.object_property = PROP_RECIPIENT_LIST;
list_element.array_index = 0;
test/bacnet/basic/object/netport/CMakeLists.txt
+1
View File
@@ -70,6 +70,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/property.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/osv/CMakeLists.txt
+1
View File
@@ -53,6 +53,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/piv/CMakeLists.txt
+1
View File
@@ -53,6 +53,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/program/CMakeLists.txt
+1
View File
@@ -53,6 +53,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/schedule/CMakeLists.txt
+1
View File
@@ -56,6 +56,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/structured_view/CMakeLists.txt
+1
View File
@@ -55,6 +55,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/property.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/object/test/property_test.c
+19 -1
View File
@@ -227,7 +227,9 @@ int bacnet_object_property_read_test(
apdu_len = read_len;
len =
bacnet_unsigned_application_decode(apdu, apdu_len, &array_size);
zassert_true(len > 0, NULL);
zassert_true(
len > 0, "property '%s' array_index=0\n",
bactext_property_name(rpdata->object_property));
zassert_true(
len == read_len, "property '%s' array_index=0.\n",
bactext_property_name(rpdata->object_property));
@@ -243,6 +245,19 @@ int bacnet_object_property_read_test(
}
}
}
/* test an array index that is likely out of range */
rpdata->array_index = BACNET_ARRAY_ALL - 1;
read_len = read_property(rpdata);
zassert_equal(
read_len, BACNET_STATUS_ERROR,
"property '%s' array_index=%u: error code is %s.\n",
bactext_property_name(rpdata->object_property), rpdata->array_index,
bactext_error_code_name(rpdata->error_code));
zassert_equal(
rpdata->error_code, ERROR_CODE_INVALID_ARRAY_INDEX,
"property '%s' array_index=%u: error code is %s.\n",
bactext_property_name(rpdata->object_property), rpdata->array_index,
bactext_error_code_name(rpdata->error_code));
}
return len;
@@ -278,6 +293,9 @@ void bacnet_object_properties_read_write_test(
bool commandable = false;
bool status = false;
/* negative test */
len = read_property(NULL);
zassert_equal(len, 0, NULL);
/* ReadProperty parameters */
rpdata.application_data = &apdu[0];
rpdata.application_data_len = sizeof(apdu);
test/bacnet/basic/object/time_value/CMakeLists.txt
+1
View File
@@ -56,6 +56,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/memcopy.c
${SRC_DIR}/bacnet/wp.c
test/bacnet/basic/object/timer/CMakeLists.txt
+77
View File
@@ -0,0 +1,77 @@
# SPDX-License-Identifier: MIT
cmake_minimum_required(VERSION 3.10 FATAL_ERROR)
get_filename_component(basename ${CMAKE_CURRENT_SOURCE_DIR} NAME)
project(test_${basename}
VERSION 1.0.0
LANGUAGES C)
string(REGEX REPLACE
"/test/bacnet/[a-zA-Z_/-]*$"
"/src"
SRC_DIR
${CMAKE_CURRENT_SOURCE_DIR})
string(REGEX REPLACE
"/test/bacnet/[a-zA-Z_/-]*$"
"/test"
TST_DIR
${CMAKE_CURRENT_SOURCE_DIR})
set(ZTST_DIR "${TST_DIR}/ztest/src")
add_compile_definitions(
BIG_ENDIAN=0
CONFIG_ZTEST=1
)
include_directories(
${SRC_DIR}
${TST_DIR}/bacnet/basic/object/test
${TST_DIR}/ztest/include
)
add_executable(${PROJECT_NAME}
# File(s) under test
${SRC_DIR}/bacnet/basic/object/timer.c
# Support files and stubs (pathname alphabetical)
${SRC_DIR}/bacnet/access_rule.c
${SRC_DIR}/bacnet/bacaction.c
${SRC_DIR}/bacnet/bacaddr.c
${SRC_DIR}/bacnet/bacapp.c
${SRC_DIR}/bacnet/bacdcode.c
${SRC_DIR}/bacnet/bacdest.c
${SRC_DIR}/bacnet/bacdevobjpropref.c
${SRC_DIR}/bacnet/bacint.c
${SRC_DIR}/bacnet/baclog.c
${SRC_DIR}/bacnet/bacreal.c
${SRC_DIR}/bacnet/bacstr.c
${SRC_DIR}/bacnet/bactext.c
${SRC_DIR}/bacnet/bactimevalue.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
${SRC_DIR}/bacnet/basic/sys/keylist.c
${SRC_DIR}/bacnet/datetime.c
${SRC_DIR}/bacnet/indtext.c
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/property.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/secure_connect.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/datetime_local.c
${TST_DIR}/bacnet/basic/object/test/device_mock.c
${TST_DIR}/bacnet/basic/object/test/property_test.c
${ZTST_DIR}/ztest_mock.c
${ZTST_DIR}/ztest.c
)
test/bacnet/basic/object/timer/src/main.c
+722
View File
@@ -0,0 +1,722 @@
/**
* @file
* @brief Unit test for Timer object
* @author Steve Karg <skarg@users.sourceforge.net>
* @date October 2025
* @copyright SPDX-License-Identifier: MIT
*/
#include <zephyr/ztest.h>
#include <bacnet/basic/object/timer.h>
#include <bacnet/timer_value.h>
#include <bacnet/bactext.h>
#include <bacnet/list_element.h>
#include <property_test.h>
/**
* @addtogroup bacnet_tests
* @{
*/
static BACNET_WRITE_PROPERTY_DATA Write_Property_Internal_Data;
static bool Write_Property_Internal(BACNET_WRITE_PROPERTY_DATA *wp_data)
{
memcpy(
&Write_Property_Internal_Data, wp_data,
sizeof(BACNET_WRITE_PROPERTY_DATA));
return true;
}
/**
* @brief Test
*/
static void test_Timer_Read_Write(void)
{
const uint32_t instance = 123;
unsigned count = 0, test_count = 0;
unsigned index = 0;
const char *sample_name = "Timer:0";
char *sample_context = "context";
const char *sample_description = "Timer Description";
const char *test_name = NULL;
uint32_t test_instance = 0;
bool status = false;
const int skip_fail_property_list[] = { -1 };
BACNET_WRITE_PROPERTY_DATA wp_data = { 0 };
BACNET_DEVICE_OBJECT_PROPERTY_REFERENCE member = { 0 }, *test_member = NULL;
BACNET_APPLICATION_DATA_VALUE value = { 0 };
BACNET_CHARACTER_STRING cstring = { 0 };
uint8_t apdu[MAX_APDU] = { 0 };
BACNET_LIST_ELEMENT_DATA list_element = {
.application_data = apdu,
.application_data_len = sizeof(apdu),
.array_index = BACNET_ARRAY_ALL,
.error_class = ERROR_CLASS_PROPERTY,
.error_code = ERROR_CODE_SUCCESS,
.first_failed_element_number = 0,
.object_instance = instance,
.object_type = OBJECT_TIMER,
.object_property = PROP_LIST_OF_OBJECT_PROPERTY_REFERENCES
};
int err = 0;
Timer_Init();
Timer_Create(instance);
status = Timer_Valid_Instance(instance);
zassert_true(status, NULL);
status = Timer_Valid_Instance(instance - 1);
zassert_false(status, NULL);
index = Timer_Instance_To_Index(instance);
zassert_equal(index, 0, NULL);
test_instance = Timer_Index_To_Instance(index);
zassert_equal(instance, test_instance, NULL);
count = Timer_Count();
zassert_true(count > 0, NULL);
/* configure the instance property values and test API for lists */
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_ANALOG_OUTPUT;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
status = Timer_Reference_List_Member_Element_Set(instance, index, &member);
zassert_true(status, NULL);
count = Timer_Reference_List_Member_Element_Count(instance);
zassert_equal(count, 1, NULL);
/* add the same element - should be success without actually adding */
status = Timer_Reference_List_Member_Element_Add(instance, &member);
zassert_true(status, NULL);
count = Timer_Reference_List_Member_Element_Count(instance);
zassert_equal(count, 1, NULL);
/* next */
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_BINARY_OUTPUT;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
status = Timer_Reference_List_Member_Element_Add(instance, &member);
zassert_true(status, NULL);
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_MULTI_STATE_OUTPUT;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
status = Timer_Reference_List_Member_Element_Add(instance, &member);
zassert_true(status, NULL);
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_LIGHTING_OUTPUT;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
status = Timer_Reference_List_Member_Element_Add(instance, &member);
zassert_true(status, NULL);
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_COLOR;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
status = Timer_Reference_List_Member_Element_Add(instance, &member);
zassert_true(status, NULL);
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_COLOR_TEMPERATURE;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
status = Timer_Reference_List_Member_Element_Add(instance, &member);
zassert_true(status, NULL);
count = Timer_Reference_List_Member_Element_Count(instance);
status = Timer_Reference_List_Member_Element_Remove(instance, &member);
test_count = Timer_Reference_List_Member_Element_Count(instance);
zassert_true(
count > test_count, "count=%u test_count=%u", count, test_count);
/* reliability and status flags */
status = Timer_Reliability_Set(instance, RELIABILITY_PROCESS_ERROR);
zassert_true(status, NULL);
/* perform a general test for RP/WP */
bacnet_object_properties_read_write_test(
OBJECT_TIMER, instance, Timer_Property_Lists, Timer_Read_Property,
Timer_Write_Property, skip_fail_property_list);
/* test the ASCII name get/set */
status = Timer_Name_Set(instance, sample_name);
zassert_true(status, NULL);
test_name = Timer_Name_ASCII(instance);
zassert_equal(test_name, sample_name, NULL);
status = Timer_Object_Name(instance, &cstring);
zassert_true(status, NULL);
status = characterstring_ansi_same(&cstring, sample_name);
zassert_true(status, NULL);
status = Timer_Name_Set(instance, NULL);
zassert_true(status, NULL);
test_name = Timer_Name_ASCII(instance);
zassert_equal(test_name, NULL, NULL);
/* test specific WriteProperty values - common configuration */
wp_data.object_type = OBJECT_TIMER;
wp_data.object_instance = instance;
wp_data.array_index = BACNET_ARRAY_ALL;
wp_data.priority = BACNET_MAX_PRIORITY;
zassert_true(status, NULL);
/* out-of-service */
wp_data.object_property = PROP_OUT_OF_SERVICE;
value.tag = BACNET_APPLICATION_TAG_BOOLEAN;
value.type.Boolean = true;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
value.type.Boolean = false;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 123;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
/* write present-value */
wp_data.object_property = PROP_PRESENT_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 0;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
/* configure min-pres-value and max-pres-value to max limits */
wp_data.object_property = PROP_MIN_PRES_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 1;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
wp_data.object_property = PROP_MAX_PRES_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = UINT32_MAX;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
wp_data.object_property = PROP_PRESENT_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 1;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
wp_data.object_property = PROP_PRESENT_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = UINT32_MAX;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
/* configure min-pres-value and max-pres-value to elicit out-of-range */
wp_data.object_property = PROP_MIN_PRES_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 100;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
wp_data.object_property = PROP_MAX_PRES_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = UINT32_MAX - 100;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
wp_data.object_property = PROP_PRESENT_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 1;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_VALUE_OUT_OF_RANGE, NULL);
wp_data.object_property = PROP_PRESENT_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = UINT32_MAX;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_VALUE_OUT_OF_RANGE, NULL);
/* list-of-object-property-references - single element list */
wp_data.object_property = PROP_LIST_OF_OBJECT_PROPERTY_REFERENCES;
value.tag = BACNET_APPLICATION_TAG_DEVICE_OBJECT_PROPERTY_REFERENCE;
value.type.Device_Object_Property_Reference.arrayIndex = BACNET_ARRAY_ALL;
value.type.Device_Object_Property_Reference.deviceIdentifier.type =
OBJECT_DEVICE;
value.type.Device_Object_Property_Reference.deviceIdentifier.instance =
12345;
value.type.Device_Object_Property_Reference.objectIdentifier.type =
OBJECT_ANALOG_OUTPUT;
value.type.Device_Object_Property_Reference.objectIdentifier.instance = 1;
value.type.Device_Object_Property_Reference.propertyIdentifier =
PROP_PRESENT_VALUE;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, "%s", bactext_error_code_name(wp_data.error_code));
/* add list element */
value.tag = BACNET_APPLICATION_TAG_DEVICE_OBJECT_PROPERTY_REFERENCE;
value.type.Device_Object_Property_Reference.arrayIndex = BACNET_ARRAY_ALL;
value.type.Device_Object_Property_Reference.deviceIdentifier.type =
OBJECT_DEVICE;
value.type.Device_Object_Property_Reference.deviceIdentifier.instance =
12345;
value.type.Device_Object_Property_Reference.objectIdentifier.type =
OBJECT_ANALOG_OUTPUT;
value.type.Device_Object_Property_Reference.objectIdentifier.instance = 1;
value.type.Device_Object_Property_Reference.propertyIdentifier =
PROP_PRESENT_VALUE;
list_element.application_data_len =
bacapp_encode_application_data(apdu, &value);
list_element.object_property = PROP_LIST_OF_OBJECT_PROPERTY_REFERENCES;
list_element.array_index = BACNET_ARRAY_ALL;
list_element.error_class = ERROR_CLASS_PROPERTY;
list_element.error_code = ERROR_CODE_SUCCESS;
err = Timer_Add_List_Element(&list_element);
zassert_equal(err, BACNET_STATUS_OK, "err=%d", err);
zassert_equal(
list_element.error_code, ERROR_CODE_SUCCESS, "%s",
bactext_error_code_name(list_element.error_code));
err = Timer_Remove_List_Element(&list_element);
zassert_equal(err, BACNET_STATUS_OK, "err=%d", err);
zassert_equal(
list_element.error_code, ERROR_CODE_SUCCESS, "%s",
bactext_error_code_name(list_element.error_code));
/* Add/RemoveListElement negative tests */
list_element.object_property = PROP_ALL;
err = Timer_Add_List_Element(&list_element);
zassert_equal(err, BACNET_STATUS_ERROR, "err=%d", err);
zassert_equal(
list_element.error_code, ERROR_CODE_WRITE_ACCESS_DENIED, "%s",
bactext_error_code_name(list_element.error_code));
err = Timer_Remove_List_Element(&list_element);
zassert_equal(err, BACNET_STATUS_ERROR, "err=%d", err);
zassert_equal(
list_element.error_code, ERROR_CODE_WRITE_ACCESS_DENIED, "%s",
bactext_error_code_name(list_element.error_code));
err = Timer_Add_List_Element(NULL);
zassert_equal(err, BACNET_STATUS_ABORT, "err=%d", err);
err = Timer_Remove_List_Element(NULL);
zassert_equal(err, BACNET_STATUS_ABORT, "err=%d", err);
/* default-timeout - out of range error */
wp_data.object_property = PROP_DEFAULT_TIMEOUT;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 1000;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
value.type.Unsigned_Int = UINT32_MAX + 1ULL;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_VALUE_OUT_OF_RANGE, NULL);
/* min-pres-value - out of range error */
wp_data.object_property = PROP_MIN_PRES_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 1;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
value.type.Unsigned_Int = UINT32_MAX + 1ULL;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_VALUE_OUT_OF_RANGE, NULL);
/* max-pres-value - out of range error */
wp_data.object_property = PROP_MAX_PRES_VALUE;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = UINT32_MAX;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
value.type.Unsigned_Int = UINT32_MAX + 1ULL;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_VALUE_OUT_OF_RANGE, NULL);
/* resolution - out of range error */
wp_data.object_property = PROP_RESOLUTION;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 1;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
value.type.Unsigned_Int = UINT32_MAX + 1ULL;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_VALUE_OUT_OF_RANGE, NULL);
/* priority-for-writing - out of range error */
wp_data.object_property = PROP_PRIORITY_FOR_WRITING;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = BACNET_MIN_PRIORITY;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
value.type.Unsigned_Int = BACNET_MAX_PRIORITY + 1ULL;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_VALUE_OUT_OF_RANGE, NULL);
value.type.Unsigned_Int = UINT8_MAX + 1ULL;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_VALUE_OUT_OF_RANGE, NULL);
/* state-change-values */
wp_data.object_property = PROP_STATE_CHANGE_VALUES;
wp_data.array_index = 1;
value.tag = BACNET_APPLICATION_TAG_TIMER_VALUE;
value.type.Timer_Value.tag = BACNET_APPLICATION_TAG_REAL;
value.type.Timer_Value.type.Real = 1.0f;
value.type.Timer_Value.next = NULL;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_true(status, NULL);
wp_data.array_index = BACNET_ARRAY_ALL - 1;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_INVALID_ARRAY_INDEX, NULL);
/* write to all elements, but only include one element */
wp_data.array_index = BACNET_ARRAY_ALL;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_VALUE_OUT_OF_RANGE, NULL);
/* state-change-values - wrong datatype */
wp_data.array_index = 1;
wp_data.application_data_len =
encode_context_real(wp_data.application_data, 42, 1.0f);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(
wp_data.error_code, ERROR_CODE_VALUE_OUT_OF_RANGE, "%s",
bactext_error_code_name(wp_data.error_code));
/* write to the size, but the size is read-only */
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 42;
wp_data.array_index = 0;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_false(status, NULL);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_WRITE_ACCESS_DENIED, NULL);
/* read-only property */
wp_data.array_index = BACNET_ARRAY_ALL;
wp_data.priority = BACNET_MAX_PRIORITY;
wp_data.object_property = PROP_OBJECT_TYPE;
value.tag = BACNET_APPLICATION_TAG_ENUMERATED;
value.type.Enumerated = OBJECT_ANALOG_INPUT;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Timer_Write_Property(&wp_data);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_WRITE_ACCESS_DENIED, NULL);
zassert_false(status, NULL);
/* present-value API */
status = Timer_Present_Value_Set(instance, 0);
zassert_true(status, NULL);
status = Timer_Min_Pres_Value_Set(instance, 100);
zassert_true(status, NULL);
status = Timer_Present_Value_Set(instance, 1);
zassert_false(status, NULL);
status = Timer_Max_Pres_Value_Set(instance, 9999);
zassert_true(status, NULL);
status = Timer_Present_Value_Set(instance, 10000);
zassert_false(status, NULL);
status = Timer_Present_Value_Set(instance, Timer_Min_Pres_Value(instance));
zassert_true(status, NULL);
status = Timer_Present_Value_Set(instance, Timer_Max_Pres_Value(instance));
zassert_true(status, NULL);
/* negative testing of API */
test_member = Timer_Reference_List_Member_Element(instance + 1, 0);
zassert_true(test_member == NULL, NULL);
/* reliability and status flags */
status = Timer_Reliability_Set(instance, RELIABILITY_PROCESS_ERROR);
zassert_true(status, NULL);
/* context API */
Timer_Context_Set(instance, sample_context);
zassert_true(sample_context == Timer_Context_Get(instance), NULL);
zassert_true(NULL == Timer_Context_Get(instance + 1), NULL);
/* description API */
status = Timer_Description_Set(instance, sample_description);
zassert_true(status, NULL);
zassert_equal(sample_description, Timer_Description_ANSI(instance), NULL);
status = Timer_Description(instance, &cstring);
zassert_true(status, NULL);
status = characterstring_ansi_same(&cstring, sample_description);
zassert_true(status, NULL);
status = Timer_Description_Set(instance, NULL);
zassert_true(status, NULL);
status = characterstring_init_ansi(&cstring, "");
zassert_true(status, NULL);
status =
characterstring_ansi_same(&cstring, Timer_Description_ANSI(instance));
zassert_true(status, NULL);
/* cleanup */
status = Timer_Delete(instance);
zassert_true(status, NULL);
Timer_Cleanup();
}
static void test_Timer_Operation_Transition_Default(
const uint32_t instance,
BACNET_TIMER_STATE test_state,
BACNET_TIMER_TRANSITION test_transition)
{
bool status = false;
BACNET_TIMER_STATE_CHANGE_VALUE *value = NULL;
BACNET_TIMER_STATE state = TIMER_STATE_IDLE;
BACNET_TIMER_TRANSITION transition = TIMER_TRANSITION_NONE;
uint32_t timeout = 0, test_timeout = 0;
BACNET_DATE_TIME bdatetime = { 0 }, test_bdatetime = { 0 };
BACNET_APPLICATION_DATA_VALUE test_value = { 0 };
int diff = 0, len = 0;
state = Timer_State(instance);
zassert_equal(state, test_state, NULL);
transition = Timer_Last_State_Change(instance);
zassert_equal(transition, test_transition, NULL);
if (Timer_Running(instance)) {
timeout = Timer_Default_Timeout(instance);
test_timeout = Timer_Initial_Timeout(instance);
zassert_equal(timeout, test_timeout, NULL);
status = Timer_Initial_Timeout_Set(instance, timeout);
zassert_true(status, NULL);
test_timeout = Timer_Initial_Timeout(instance);
zassert_equal(timeout, test_timeout, NULL);
test_timeout = Timer_Present_Value(instance);
zassert_equal(timeout, test_timeout, NULL);
}
datetime_local(&bdatetime.date, &bdatetime.time, NULL, NULL);
status = Timer_Update_Time(instance, &test_bdatetime);
zassert_true(status, NULL);
diff = datetime_compare(&bdatetime, &test_bdatetime);
zassert_equal(diff, 0, "diff=%d", diff);
status = Timer_Update_Time_Set(instance, &bdatetime);
zassert_true(status, NULL);
status = Timer_Update_Time(instance, &test_bdatetime);
zassert_true(status, NULL);
diff = datetime_compare(&bdatetime, &test_bdatetime);
zassert_equal(diff, 0, "diff=%d", diff);
status = Timer_Expiration_Time(instance, &test_bdatetime);
zassert_true(status, NULL);
diff = datetime_compare(&bdatetime, &test_bdatetime);
zassert_true(diff < 0, "diff=%d", diff);
zassert_equal(
Write_Property_Internal_Data.object_property, PROP_PRESENT_VALUE, NULL);
len = bacapp_decode_application_data(
Write_Property_Internal_Data.application_data,
Write_Property_Internal_Data.application_data_len, &test_value);
zassert_true(len > 0, "len=%d", len);
value = Timer_State_Change_Value(instance, test_transition);
zassert_equal(test_value.tag, value->tag, NULL);
zassert_equal(test_value.type.Enumerated, value->type.Enumerated, NULL);
}
/**
* @brief Test
*/
static void test_Timer_Operation(void)
{
const uint32_t instance = 123;
uint32_t test_instance = 0;
bool status = false;
BACNET_DEVICE_OBJECT_PROPERTY_REFERENCE member = { 0 };
BACNET_TIMER_STATE_CHANGE_VALUE *value = NULL;
BACNET_TIMER_STATE test_state = TIMER_STATE_IDLE;
BACNET_DATE_TIME bdatetime = { 0 };
uint32_t elapsed_time = 0;
unsigned members = 0, i = 0;
/* init */
Timer_Init();
Timer_Create(instance);
status = Timer_Valid_Instance(instance);
zassert_true(status, NULL);
/* set the local time */
datetime_set_values(&bdatetime, 2025, 10, 24, 10, 50, 42, 42);
datetime_timesync(&bdatetime.date, &bdatetime.time, false);
/* configure the reference members and the write property values */
Timer_Write_Property_Internal_Callback_Set(Write_Property_Internal);
members = Timer_Reference_List_Member_Capacity(instance);
for (i = 0; i < members; i++) {
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_BINARY_VALUE;
member.objectIdentifier.instance = 1 + i;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
status = Timer_Reference_List_Member_Element_Set(instance, i, &member);
}
/* check the transitions boundaries */
value = Timer_State_Change_Value(instance, TIMER_TRANSITION_NONE);
zassert_true(value == NULL, NULL);
value = Timer_State_Change_Value(instance, TIMER_TRANSITION_MAX);
zassert_true(value == NULL, NULL);
/* configure the transitions */
value =
Timer_State_Change_Value(instance, TIMER_TRANSITION_IDLE_TO_RUNNING);
value->tag = BACNET_APPLICATION_TAG_ENUMERATED;
value->type.Enumerated = BINARY_ACTIVE;
value =
Timer_State_Change_Value(instance, TIMER_TRANSITION_RUNNING_TO_IDLE);
value->tag = BACNET_APPLICATION_TAG_ENUMERATED;
value->type.Enumerated = BINARY_INACTIVE;
value =
Timer_State_Change_Value(instance, TIMER_TRANSITION_EXPIRED_TO_IDLE);
value->tag = BACNET_APPLICATION_TAG_ENUMERATED;
value->type.Enumerated = BINARY_INACTIVE;
value =
Timer_State_Change_Value(instance, TIMER_TRANSITION_RUNNING_TO_EXPIRED);
value->tag = BACNET_APPLICATION_TAG_ENUMERATED;
value->type.Enumerated = BINARY_INACTIVE;
value =
Timer_State_Change_Value(instance, TIMER_TRANSITION_FORCED_TO_EXPIRED);
value->tag = BACNET_APPLICATION_TAG_ENUMERATED;
value->type.Enumerated = BINARY_INACTIVE;
value =
Timer_State_Change_Value(instance, TIMER_TRANSITION_EXPIRED_TO_RUNNING);
value->tag = BACNET_APPLICATION_TAG_ENUMERATED;
value->type.Enumerated = BINARY_ACTIVE;
/* alternate API */
status = Timer_State_Change_Value_Set(
instance, TIMER_TRANSITION_EXPIRED_TO_RUNNING, value);
zassert_true(status, NULL);
/* start timer using a write to timer-running property to use defaults */
/* IDLE_TO_RUNNING */
status = Timer_State_Set(instance, TIMER_STATE_IDLE);
zassert_true(status, NULL);
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_IDLE, NULL);
status = Timer_Running_Set(instance, true);
zassert_true(status, NULL);
status = Timer_Running(instance);
zassert_true(status, NULL);
test_Timer_Operation_Transition_Default(
instance, TIMER_STATE_RUNNING, TIMER_TRANSITION_IDLE_TO_RUNNING);
/* RUNNING_TO_RUNNING */
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_RUNNING, NULL);
status = Timer_Running_Set(instance, true);
zassert_true(status, NULL);
status = Timer_Running(instance);
zassert_true(status, NULL);
test_Timer_Operation_Transition_Default(
instance, TIMER_STATE_RUNNING, TIMER_TRANSITION_RUNNING_TO_RUNNING);
/* EXPIRED_TO_RUNNING */
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_RUNNING, NULL);
elapsed_time = Timer_Present_Value(instance);
Timer_Task(instance, elapsed_time - 1);
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_RUNNING, NULL);
Timer_Task(instance, elapsed_time);
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_EXPIRED, NULL);
status = Timer_Running_Set(instance, true);
zassert_true(status, NULL);
status = Timer_Running(instance);
zassert_true(status, NULL);
test_Timer_Operation_Transition_Default(
instance, TIMER_STATE_RUNNING, TIMER_TRANSITION_EXPIRED_TO_RUNNING);
/* EXPIRED_TO_IDLE */
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_RUNNING, NULL);
elapsed_time = Timer_Present_Value(instance);
Timer_Task(instance, elapsed_time);
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_EXPIRED, NULL);
status = Timer_State_Set(instance, TIMER_STATE_IDLE);
zassert_true(status, NULL);
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_IDLE, NULL);
test_Timer_Operation_Transition_Default(
instance, TIMER_STATE_IDLE, TIMER_TRANSITION_EXPIRED_TO_IDLE);
/* start timer using a write to timer-state property to use defaults */
/* RUNNING_TO_IDLE */
status = Timer_Running_Set(instance, true);
zassert_true(status, NULL);
status = Timer_Running(instance);
zassert_true(status, NULL);
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_RUNNING, NULL);
status = Timer_State_Set(instance, TIMER_STATE_IDLE);
zassert_true(status, NULL);
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_IDLE, NULL);
test_Timer_Operation_Transition_Default(
instance, TIMER_STATE_IDLE, TIMER_TRANSITION_RUNNING_TO_IDLE);
Timer_Task(instance, elapsed_time);
/* RUNNING_TO_EXPIRED */
status = Timer_Running_Set(instance, true);
zassert_true(status, NULL);
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_RUNNING, NULL);
status = Timer_Running_Set(instance, false);
zassert_true(status, NULL);
test_state = Timer_State(instance);
zassert_equal(test_state, TIMER_STATE_EXPIRED, NULL);
test_Timer_Operation_Transition_Default(
instance, TIMER_STATE_EXPIRED, TIMER_TRANSITION_FORCED_TO_EXPIRED);
Timer_Task(instance, elapsed_time);
/* cleanup instance */
status = Timer_Delete(instance);
zassert_true(status, NULL);
/* test create of next instance */
test_instance = Timer_Create(BACNET_MAX_INSTANCE);
zassert_not_equal(test_instance, BACNET_MAX_INSTANCE, NULL);
test_instance = Timer_Create(test_instance);
zassert_not_equal(test_instance, BACNET_MAX_INSTANCE, NULL);
test_instance = Timer_Create(BACNET_MAX_INSTANCE + 1);
zassert_equal(test_instance, BACNET_MAX_INSTANCE, NULL);
/* cleanup all */
Timer_Cleanup();
}
/**
* @}
*/
void test_main(void)
{
ztest_test_suite(
timer_tests, ztest_unit_test(test_Timer_Read_Write),
ztest_unit_test(test_Timer_Operation));
ztest_run_test_suite(timer_tests);
}
test/bacnet/basic/object/trendlog/CMakeLists.txt
+1
View File
@@ -55,6 +55,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
test/bacnet/basic/server/bacnet_device/CMakeLists.txt
+2
View File
@@ -83,6 +83,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/basic/object/schedule.c
${SRC_DIR}/bacnet/basic/object/structured_view.c
${SRC_DIR}/bacnet/basic/object/time_value.c
${SRC_DIR}/bacnet/basic/object/timer.c
${SRC_DIR}/bacnet/basic/object/trendlog.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
@@ -103,6 +104,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/property.c
${SRC_DIR}/bacnet/reject.c
${SRC_DIR}/bacnet/timer_value.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c