Secure ReadProperty decoding and BACnetActionCommand (#702)
* Refactored and secured BACnetActionCommand codec into bacaction.c module for command object and added to bacapp module encode/decode with define for enabling and pseudo application tag for internal use. * Simplified bacapp_data_len() and moved into bacdcode module as bacnet_enclosed_data_len() function. * Secured ReadProperty-REQUEST and -ACK decoding. * Removed deprecated Keylist_Key() functions from usage. * Removed pseudo application datatypes from bacapp_data_decode() which only uses primitive application tag encoded values. * Defined INT_MAX when it is not already defined by compiler or libc. * Deprecated bacapp_decode_application_data_len() and bacapp_decode_context_data_len() as they are no longer used in any code in the library. * Added BACnetScale to bacapp module. Improved complex property value decoding. Refactored bacapp_decode_known_property() function. * Refactored and improved the bacapp_snprintf() function for printing EPICS. * Fixed Lighting Output WriteProperty to handle known property decoding.
This commit is contained in:
+1
-3
@@ -208,7 +208,6 @@ int cov_notify_decode_service_request(
|
||||
BACNET_UNSIGNED_INTEGER decoded_value = 0;
|
||||
BACNET_OBJECT_TYPE decoded_type = OBJECT_NONE;
|
||||
uint32_t decoded_instance = 0;
|
||||
BACNET_PROPERTY_ID property_identifier = PROP_ALL;
|
||||
BACNET_PROPERTY_VALUE *value = NULL;
|
||||
|
||||
/* subscriber-process-identifier [0] Unsigned32 */
|
||||
@@ -292,8 +291,7 @@ int cov_notify_decode_service_request(
|
||||
/* this len function needs to start at the opening tag
|
||||
to match opening/closing tags like a stack.
|
||||
However, it returns the len between the tags. */
|
||||
value_len = bacapp_data_len(&apdu[len], apdu_size - len,
|
||||
(BACNET_PROPERTY_ID)property_identifier);
|
||||
value_len = bacnet_enclosed_data_length(&apdu[len], apdu_size - len);
|
||||
len += value_len;
|
||||
/* add the opening tag length to the totals */
|
||||
len += tag_len;
|
||||
|
||||
Reference in New Issue
Block a user