Strip tabs and trailing white spaces, and fix end of files (#748)

* format: Strip trailing whitespaces

We want to get rid of trailing whitespaces completly as they make just git
noice. Much better to start using automated tools to get rid of them once and
not getting them back again. This way git history will be cleaner and review
easier.

Commit was generated with:

    pre-commit run --all-files trailing-whitespace

* format: Files should have exactly one new line end of them

It is good practice that every file has one new line. It is not now days so
mandatory but it also is not nice if file has lot of newlines end of it. We will
use pre-commit which takes automatically care about this so let's fix all.

Commit was generated with:

    pre-commit run --all-files end-of-file-fixer

* format: Convert tabs to spaces

Project mostly use spaces over tabs. When mixing tabs and spaces this usually
makes formatting issues and also when changing those in commits it will make lot
of git noise. We will force spaces most of the time and use pre-commit to fix.

Commit was generated with:

    pre-commit run --all-files remove-tabs

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>

Dockerfile

@@ -50,4 +50,3 @@ COPY --from=builder /build/bin/* /opt/bacnet/bin/
 EXPOSE 47808/udp
 ENTRYPOINT ["/opt/bacnet/bin/bacserv"]
 CMD ["1234", "test_server"]
-

apps/Makefile

@@ -459,4 +459,3 @@ fuzz-afl: $(BACNET_LIB_TARGET)
 .PHONY: writepropm
 writepropm: $(BACNET_LIB_TARGET)
 	$(MAKE) -B -C $@
-

apps/abort/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/ack-alarm/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/apdu/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/blinkt/Makefile

@@ -53,4 +53,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/blinkt/README.md

@@ -90,4 +90,3 @@ A simplistic bacnet.sh script will look like this (with stdout/stderr to /dev/nu
 
     #!/bin/bash
     /home/pi/bacnet-stack/bin/bacblinkt 9009 > /dev/null 2>&1
-

apps/dcc/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/epics/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/error/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/event/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/fuzz-afl/README.md

@@ -19,6 +19,3 @@ Caveats:
 
 * This builds the target with ASAN (Address Sanitizer). This makes AFL require the `-m none` to not interpret ASAN's behavior as a crash
 * AFL uses a fork/exec model to launch the target. This is nice because each testcase is from a clean state. But this also brings in a lot of overhead. If you need something faster, check out ../fuzz-libfuzzer/
-
-
-

apps/fuzz-libfuzzer/README.md

@@ -48,4 +48,3 @@ READ of size 1 at 0x60200003b656 thread T0
 Caveat:
 
 * Libfuzzer does not reinitialize the target on each testcase. This means that it will be much quicker than ../fuzz-afl/, BUT it will also be a little less stable. It also will not continue to fuzz after a crash is found (since the libfuzzer runtime shares a process with the target that just crashed). There may be some command line options to adopt a fork model.
-

apps/getevent/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/iam/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/iamrouter/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/initrouter/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/netnumis/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/perl/Documentation/syntax.js

@@ -134,4 +134,3 @@ $(document).ready(function(){
         HighlightCode(this);
      });
 });
-

apps/perl/bacnet.pl

@@ -866,4 +866,3 @@ sub LogAnswer {
     $answer = '' unless $append;
     $answer .= $newAnswer;
 }
-

apps/perl/readme.txt

@@ -16,5 +16,3 @@ The BACnet Scriptable (using Perl) Tool.
   Value) for Device at instance 1234 run the following command
 
   perl bacnet.pl --script example_readprop.pl -- 1234
-
-

apps/piface/Makefile

@@ -56,4 +56,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/piface/configure.sh

@@ -17,4 +17,3 @@ fi
 
 make -C libmcp23s17
 make -C libpifacedigital
-

apps/piface/readme.txt

@@ -6,5 +6,3 @@ To build, start with the configure script:
 
 $ ./configure.sh
 $ make clean all
-
-

apps/ptransfer/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/readbdt/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/readfdt/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/readfile/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/readprop/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/readpropm/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/readrange/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/reinit/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/router/readme.txt

@@ -127,6 +127,3 @@ mstp arguments:
 
 5.2. Passing params in command line
 1. sudo ./router -D "mstp" "/dev/ttyS0" --mac 1 127 1 --baud 38400 --network 4 -D "bip" "eth0" --network 1
-
-
-

apps/scov/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/server-client/Makefile

@@ -42,4 +42,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/server-discover/Makefile

@@ -42,4 +42,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/server/Makefile

@@ -75,4 +75,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/server/epics_vts3.tpi

@@ -755,5 +755,3 @@ List of Objects in test device:
 }
 
 End of BACnet Protocol Implementation Conformance Statement
-
-

apps/timesync/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/ucov/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/uevent/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/uptransfer/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/whatisnetnum/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/whohas/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/whois/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/whoisrouter/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/writebdt/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/writefile/Makefile

@@ -37,4 +37,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/writeprop/Makefile

@@ -40,4 +40,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

apps/writepropm/Makefile

@@ -40,4 +40,3 @@ clean:
 
 .PHONY: include
 include: .depend
-

aptfile

@@ -51,4 +51,3 @@ package "codespell"
 
 # you can also execute arbitrary bash
 echo "🚀  ALL GOOD TO GO"
-

bin/bacrpd.sh

@@ -143,5 +143,3 @@ while [ $# -gt 0 ] ; do
     fi
     run_test $ID
 done
-
-

bin/bbmdepics.sh

@@ -42,4 +42,3 @@ for pid in ${pids[*]}; do
 done
 
 killall bacserv
-

bin/bvlc.bat

@@ -11,4 +11,3 @@ echo they register as a Foreign Device to it.
 @echo on
 set BACNET_BBMD_PORT=47808
 set BACNET_BBMD_ADDRESS=%1
-

comment.sh

@@ -23,4 +23,3 @@ do
   ${CONVERTER} ${filename} > ${TEMPFILE}
   mv ${TEMPFILE} ${filename}
 done
-

configure

@@ -1,3 +1,2 @@
 #!/bin/sh
 # Nothing to do
-

doc/README.faq

@@ -158,4 +158,3 @@ Q-18: I have downloaded the BACnet stack but can't get Who-Is or EPICS applicati
 A-18: Firewalls on modern OS block incoming and outgoing network traffic and require you to 'allow' the port that BACnet/IP uses.  To allow the default BACnet/IP UDP port 47808 Linux with UFW:
 
 $ sudo ufw allow 47808/udp
-

doc/README.msvs

@@ -5,4 +5,3 @@ Q1: Cannot open include file: 'winsock2.h'
 
 A1: Install the Microsoft Platform SDK:
 http://msdn.microsoft.com/vstudio/express/visualc/usingpsdk/default.aspx
-

doc/README.utils

@@ -45,4 +45,3 @@ AC:10:56:06:BA:C0=MAC address (router address) in hex
 26001=DNET network number in decimal
 19=DADR MAC address in hex.  Use colon to separate multibyte address.
 50=Max APDU
-

license/GPL-2.0

@@ -74,7 +74,7 @@ patent must be licensed for everyone's free use or not licensed at all.
 
   The precise terms and conditions for copying, distribution and
 modification follow.
-
+
             GNU GENERAL PUBLIC LICENSE
    TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
 
@@ -129,7 +129,7 @@ above, provided that you also meet all of these conditions:
     License.  (Exception: if the Program itself is interactive but
     does not normally print such an announcement, your work based on
     the Program is not required to print an announcement.)
-
+
 These requirements apply to the modified work as a whole.  If
 identifiable sections of that work are not derived from the Program,
 and can be reasonably considered independent and separate works in
@@ -187,7 +187,7 @@ access to copy from a designated place, then offering equivalent
 access to copy the source code from the same place counts as
 distribution of the source code, even though third parties are not
 compelled to copy the source along with the object code.
-
+
   4. You may not copy, modify, sublicense, or distribute the Program
 except as expressly provided under this License.  Any attempt
 otherwise to copy, modify, sublicense or distribute the Program is
@@ -244,7 +244,7 @@ impose that choice.
 
 This section is intended to make thoroughly clear what is believed to
 be a consequence of the rest of this License.
-
+
   8. If the distribution and/or use of the Program is restricted in
 certain countries either by patents or by copyrighted interfaces, the
 original copyright holder who places the Program under this License
@@ -297,7 +297,7 @@ PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGES.
 
              END OF TERMS AND CONDITIONS
-
+
         How to Apply These Terms to Your New Programs
 
   If you develop a new program, and you want it to be of the greatest

ports/at91sam7s/.gdbinit

@@ -13,4 +13,3 @@ monitor long 0xfffffc30 0x7
 monitor sleep 100
 monitor long 0xfffffd08 0xa5000401
 monitor sleep 100
-

ports/at91sam7s/at91sam7s256.ld

@@ -153,4 +153,3 @@ SECTIONS
     _bss_end = . ;                      /* define a global symbol marking the end of the .bss section */
 }
     _end = .;                           /* define a global symbol marking the end of application RAM */
-	

ports/at91sam7s/bacnet.eww

@@ -6,5 +6,3 @@
   </project>
   <batchBuild/>
 </workspace>
-
-

ports/atmega168/bacnet.eww

@@ -6,5 +6,3 @@
   </project>
   <batchBuild/>
 </workspace>
-
-

ports/bdk-atxx4-mstp/bacnet.eww

@@ -6,5 +6,3 @@
   </project>
   <batchBuild/>
 </workspace>
-
-

ports/pic18f6720/readme.txt

@@ -40,4 +40,3 @@ DATABANK   NAME=stackreg   START=0xC00          END=0xDFF          PROTECTED
 
 //STACK SIZE=0x100 RAM=gpr13
 STACK SIZE=0x200 RAM=stackreg
-

ports/pic18f97j60/readme.txt

@@ -40,4 +40,3 @@ DATABANK   NAME=stackreg   START=0xC00          END=0xDFF          PROTECTED
 
 //STACK SIZE=0x100 RAM=gpr13
 STACK SIZE=0x200 RAM=stackreg
-

ports/stm32f10x/bacnet.eww

@@ -6,5 +6,3 @@
   </project>
   <batchBuild/>
 </workspace>
-
-

ports/win32/borland.bat

@@ -3,5 +3,3 @@ echo Build for Borland 5.5 tools
 set BORLAND_DIR=c:\borland\bcc55
 %BORLAND_DIR%\bin\make -f makefile.mak clean
 %BORLAND_DIR%\bin\make -f makefile.mak all
-
-

ports/win32/setvars.bat

@@ -1,2 +1 @@
 set BORLAND_DIR=\bcc55
-

ports/zephyr/mstimer-init.c

@@ -28,4 +28,3 @@ void mstimer_init(void)
 {
 
 }
-

src/bacnet/authentication_factor.h

@@ -48,4 +48,3 @@ extern "C" {
 }
 #endif /* __cplusplus */
 #endif
-

src/bacnet/basic/object/acc.h

@@ -112,6 +112,3 @@ extern "C" {
     Accumulator_Name, Accumulator_Read_Property, Accumulator_Write_Property, \
     Accumulator_Property_Lists, NULL, NULL
 #endif
-
-
-

src/bacnet/basic/object/iv.c

@@ -708,4 +708,3 @@ void Integer_Value_Init(void)
         Object_List = Keylist_Create();
     }
 }
-

src/bacnet/basic/object/objects.h

@@ -69,4 +69,3 @@ extern "C" {
 #endif /* __cplusplus */
 
 #endif
-

src/bacnet/basic/tsm/tsm.c

@@ -388,4 +388,3 @@ bool tsm_invoke_id_failed(uint8_t invokeID)
     return status;
 }
 #endif
-

src/bacnet/calendar_entry.h

@@ -75,4 +75,3 @@ bool bacnet_calendar_entry_same(
 }
 #endif /* __cplusplus */
 #endif
-

src/bacnet/create_object.h

@@ -87,4 +87,3 @@ int create_object_error_ack_encode(
 #endif /* __cplusplus */
 
 #endif
-

src/bacnet/delete_object.h

@@ -57,4 +57,3 @@ int delete_object_decode_service_request(
 #endif /* __cplusplus */
 
 #endif
-

src/bacnet/list_element.h

@@ -80,4 +80,3 @@ int list_element_error_ack_decode(
 #endif /* __cplusplus */
 
 #endif
-

test/bacnet/abort/CMakeLists.txt

@@ -38,4 +38,3 @@ add_executable(${PROJECT_NAME}
     ${ZTST_DIR}/ztest_mock.c
     ${ZTST_DIR}/ztest.c
     )
-

test/bacnet/bacreal/Makefile

@@ -449,4 +449,3 @@ help:
 cmake_check_build_system:
 	cd /home/skarg/Projects/bacnet-stack && $(CMAKE_COMMAND) -S$(CMAKE_SOURCE_DIR) -B$(CMAKE_BINARY_DIR) --check-build-system CMakeFiles/Makefile.cmake 0
 .PHONY : cmake_check_build_system
-

zephyr/CMakeLists.txt

@@ -532,4 +532,3 @@ zephyr_compile_definitions(
   $<$<BOOL:${CONFIG_BACAPP_SCALE}>:BACAPP_SCALE>
   $<$<BOOL:${CONFIG_BACAPP_SHED_LEVEL}>:BACAPP_SHED_LEVEL>
   )
-  

zephyr/subsys/object/bacfile.c

@@ -8,4 +8,3 @@
 #include "bacnet/basic/object/bacfile.h"
 
 OBJECT_FUNCTIONS(Bacfile, BACNET_FILE_LISTING);
-

zephyr/subsys/object/mso.c

@@ -10,4 +10,3 @@
 #include "bacnet/basic/object/mso.h"
 
 OBJECT_FUNCTIONS(Multistate_Output, MULTISTATE_OUTPUT_DESCR);
-

zephyr/tests/unit/bacnet/bits/CMakeLists.txt

@@ -29,4 +29,3 @@ target_include_directories(testbinary PRIVATE
     CONFIG_ZTEST_NEW_API
     BACNET_STACK_DEPRECATED_DISABLE
     )
-