Added WriteGroup service and Channel object interfaces (#829)

This commit is contained in:
Steve Karg
2024-10-25 10:43:29 -05:00
committed by GitHub
parent 9397cfaafb
commit 3329dff337
89 changed files with 4334 additions and 1022 deletions
+1
View File
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -60,6 +60,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -57,6 +57,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -57,6 +57,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -57,6 +57,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/property_test.c
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -62,6 +62,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/keylist.c
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
@@ -65,6 +65,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/apdu_mock.c
@@ -62,6 +62,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
@@ -62,6 +62,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/property_test.c
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/device_mock.c
@@ -60,6 +60,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
@@ -60,6 +60,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/weeklyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/bactimevalue.c
${SRC_DIR}/bacnet/dailyschedule.c
# Test and test library files
@@ -27,6 +27,7 @@ add_compile_definitions(
include_directories(
${SRC_DIR}
${TST_DIR}/bacnet/basic/object/test
${TST_DIR}/ztest/include
)
@@ -48,19 +49,24 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/bactimevalue.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
${SRC_DIR}/bacnet/basic/sys/keylist.c
${SRC_DIR}/bacnet/datetime.c
${SRC_DIR}/bacnet/indtext.c
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/property.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/property_test.c
${TST_DIR}/bacnet/basic/object/test/device_mock.c
${ZTST_DIR}/ztest_mock.c
${ZTST_DIR}/ztest.c
+196 -103
View File
@@ -10,6 +10,7 @@
#include <zephyr/ztest.h>
#include <bacnet/basic/object/channel.h>
#include <bacnet/bactext.h>
#include <property_test.h>
/**
* @addtogroup bacnet_tests
@@ -19,122 +20,91 @@
/**
* @brief Test
*/
static void test_Channel_ReadProperty(void)
static void test_Channel_Property_Read_Write(void)
{
uint8_t apdu[MAX_APDU] = { 0 };
int len = 0;
int test_len = 0;
BACNET_READ_PROPERTY_DATA rpdata = { 0 };
BACNET_APPLICATION_DATA_VALUE value = { 0 };
BACNET_WRITE_PROPERTY_DATA wpdata = { 0 };
const uint32_t instance = 123;
const int *pRequired = NULL;
const int *pOptional = NULL;
const int *pProprietary = NULL;
unsigned count = 0;
bool status = false;
unsigned index;
unsigned index = 0;
const char *sample_name = "Channel:0";
const char *test_name = NULL;
char *sample_name = "sample";
uint32_t test_instance = 0;
bool status = false;
const int skip_fail_property_list[] = { -1 };
BACNET_CHANNEL_VALUE channel_value = { 0 };
BACNET_WRITE_PROPERTY_DATA wp_data = { 0 };
BACNET_APPLICATION_DATA_VALUE value = { 0 };
BACNET_DEVICE_OBJECT_PROPERTY_REFERENCE member = { 0 };
Channel_Init();
Channel_Create(instance);
status = Channel_Valid_Instance(instance);
zassert_true(status, NULL);
status = Channel_Valid_Instance(instance - 1);
zassert_false(status, NULL);
index = Channel_Instance_To_Index(instance);
zassert_equal(index, 0, NULL);
test_instance = Channel_Index_To_Instance(index);
zassert_equal(instance, test_instance, NULL);
count = Channel_Count();
zassert_true(count > 0, NULL);
rpdata.application_data = &apdu[0];
rpdata.application_data_len = sizeof(apdu);
rpdata.object_type = OBJECT_CHANNEL;
rpdata.object_instance = Channel_Index_To_Instance(0);
status = Channel_Valid_Instance(rpdata.object_instance);
/* configure the instance property values and test API for lists */
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_ANALOG_OUTPUT;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
index = Channel_Reference_List_Member_Element_Add(instance, &member);
zassert_not_equal(index, 0, NULL);
status =
Channel_Reference_List_Member_Element_Set(instance, index, &member);
zassert_true(status, NULL);
Channel_Property_Lists(&pRequired, &pOptional, &pProprietary);
while ((*pRequired) != -1) {
rpdata.object_property = *pRequired;
rpdata.array_index = BACNET_ARRAY_ALL;
len = Channel_Read_Property(&rpdata);
zassert_not_equal(
len, BACNET_STATUS_ERROR,
"property '%s': failed to ReadProperty!\n",
bactext_property_name(rpdata.object_property));
if (len > 0) {
test_len = bacapp_decode_application_data(
rpdata.application_data, (uint8_t)rpdata.application_data_len,
&value);
if ((rpdata.object_property == PROP_PRIORITY_ARRAY) ||
(rpdata.object_property == PROP_CONTROL_GROUPS) ||
(rpdata.object_property ==
PROP_LIST_OF_OBJECT_PROPERTY_REFERENCES)) {
/* FIXME: known fail to decode */
len = test_len;
}
zassert_equal(
len, test_len, "property '%s': failed to decode!\n",
bactext_property_name(rpdata.object_property));
/* check WriteProperty properties */
wpdata.object_type = rpdata.object_type;
wpdata.object_instance = rpdata.object_instance;
wpdata.object_property = rpdata.object_property;
wpdata.array_index = rpdata.array_index;
memcpy(&wpdata.application_data, rpdata.application_data, MAX_APDU);
wpdata.application_data_len = len;
wpdata.error_code = ERROR_CODE_SUCCESS;
status = Channel_Write_Property(&wpdata);
if (!status) {
/* verify WriteProperty property is known */
zassert_not_equal(
wpdata.error_code, ERROR_CODE_UNKNOWN_PROPERTY,
"property '%s': WriteProperty Unknown!\n",
bactext_property_name(rpdata.object_property));
}
}
pRequired++;
}
while ((*pOptional) != -1) {
rpdata.object_property = *pOptional;
rpdata.array_index = BACNET_ARRAY_ALL;
len = Channel_Read_Property(&rpdata);
zassert_not_equal(
len, BACNET_STATUS_ERROR,
"property '%s': failed to ReadProperty!\n",
bactext_property_name(rpdata.object_property));
if (len > 0) {
test_len = bacapp_decode_application_data(
rpdata.application_data, (uint8_t)rpdata.application_data_len,
&value);
zassert_equal(
len, test_len, "property '%s': failed to decode!\n",
bactext_property_name(rpdata.object_property));
/* check WriteProperty properties */
wpdata.object_type = rpdata.object_type;
wpdata.object_instance = rpdata.object_instance;
wpdata.object_property = rpdata.object_property;
wpdata.array_index = rpdata.array_index;
memcpy(&wpdata.application_data, rpdata.application_data, MAX_APDU);
wpdata.application_data_len = len;
wpdata.error_code = ERROR_CODE_SUCCESS;
status = Channel_Write_Property(&wpdata);
if (!status) {
/* verify WriteProperty property is known */
zassert_not_equal(
wpdata.error_code, ERROR_CODE_UNKNOWN_PROPERTY,
"property '%s': WriteProperty Unknown!\n",
bactext_property_name(rpdata.object_property));
}
}
pOptional++;
}
/* check for unsupported property - use ALL */
rpdata.object_property = PROP_ALL;
len = Channel_Read_Property(&rpdata);
zassert_equal(len, BACNET_STATUS_ERROR, NULL);
wpdata.object_property = PROP_ALL;
status = Channel_Write_Property(&wpdata);
zassert_false(status, NULL);
status = Channel_Control_Groups_Element_Set(instance, 1, 1);
zassert_true(status, NULL);
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_BINARY_OUTPUT;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
index = Channel_Reference_List_Member_Element_Add(instance, &member);
zassert_not_equal(index, 0, NULL);
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_MULTI_STATE_OUTPUT;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
index = Channel_Reference_List_Member_Element_Add(instance, &member);
zassert_not_equal(index, 0, NULL);
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_LIGHTING_OUTPUT;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
index = Channel_Reference_List_Member_Element_Add(instance, &member);
zassert_not_equal(index, 0, NULL);
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_COLOR;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
index = Channel_Reference_List_Member_Element_Add(instance, &member);
zassert_not_equal(index, 0, NULL);
member.deviceIdentifier.type = OBJECT_DEVICE;
member.deviceIdentifier.instance = 0;
member.objectIdentifier.type = OBJECT_COLOR_TEMPERATURE;
member.objectIdentifier.instance = 1;
member.propertyIdentifier = PROP_PRESENT_VALUE;
member.arrayIndex = BACNET_ARRAY_ALL;
index = Channel_Reference_List_Member_Element_Add(instance, &member);
zassert_not_equal(index, 0, NULL);
/* perform a general test for RP/WP */
bacnet_object_properties_read_write_test(
OBJECT_CHANNEL, instance, Channel_Property_Lists, Channel_Read_Property,
Channel_Write_Property, skip_fail_property_list);
/* test the ASCII name get/set */
status = Channel_Name_Set(instance, sample_name);
zassert_true(status, NULL);
@@ -144,9 +114,131 @@ static void test_Channel_ReadProperty(void)
zassert_true(status, NULL);
test_name = Channel_Name_ASCII(instance);
zassert_equal(test_name, NULL, NULL);
/* test specific WriteProperty values - common configuration */
wp_data.object_type = OBJECT_CHANNEL;
wp_data.object_instance = instance;
wp_data.array_index = BACNET_ARRAY_ALL;
wp_data.priority = BACNET_MAX_PRIORITY;
/* specific WriteProperty value */
wp_data.object_property = PROP_PRESENT_VALUE;
value.tag = BACNET_APPLICATION_TAG_CHANNEL_VALUE;
value.type.Channel_Value.tag = BACNET_APPLICATION_TAG_REAL;
value.type.Channel_Value.type.Real = 3.14159;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_true(status, NULL);
/* specific WriteProperty value */
wp_data.object_property = PROP_OUT_OF_SERVICE;
value.tag = BACNET_APPLICATION_TAG_BOOLEAN;
value.type.Boolean = true;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_true(status, NULL);
/* specific WriteProperty value */
wp_data.object_property = PROP_CHANNEL_NUMBER;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 123;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_true(status, NULL);
value.type.Unsigned_Int = UINT16_MAX + 1;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_false(status, NULL);
/* specific WriteProperty value */
wp_data.object_property = PROP_CONTROL_GROUPS;
wp_data.array_index = 1;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
/* min valid value */
value.type.Unsigned_Int = 0;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_true(status, NULL);
/* max valid value */
value.type.Unsigned_Int = UINT16_MAX;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_true(status, NULL);
/* array size - read-only */
wp_data.array_index = 0;
status = Channel_Write_Property(&wp_data);
zassert_false(status, NULL);
/* out-of-range value */
wp_data.array_index = 1;
value.type.Unsigned_Int = UINT16_MAX + 1;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_false(status, NULL);
/* invalid data type for Array element */
wp_data.array_index = 1;
value.type.Real = 3.14159f;
value.tag = BACNET_APPLICATION_TAG_REAL;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_false(status, NULL);
/* invalid data type for Array size */
wp_data.array_index = 0;
status = Channel_Write_Property(&wp_data);
zassert_false(status, NULL);
/* invalid array-index - probably */
wp_data.array_index = BACNET_ARRAY_ALL - 1;
value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value.type.Unsigned_Int = 0;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_false(status, NULL);
/* specific WriteProperty value */
wp_data.array_index = 1;
wp_data.priority = BACNET_MAX_PRIORITY;
wp_data.object_property = PROP_LIST_OF_OBJECT_PROPERTY_REFERENCES;
value.tag = BACNET_APPLICATION_TAG_DEVICE_OBJECT_PROPERTY_REFERENCE;
value.type.Device_Object_Property_Reference.objectIdentifier.type =
OBJECT_ANALOG_OUTPUT;
value.type.Device_Object_Property_Reference.objectIdentifier.instance = 1;
value.type.Device_Object_Property_Reference.propertyIdentifier =
PROP_PRESENT_VALUE;
value.type.Device_Object_Property_Reference.arrayIndex = BACNET_ARRAY_ALL;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_true(status, NULL);
wp_data.array_index = 0;
status = Channel_Write_Property(&wp_data);
zassert_false(status, NULL);
wp_data.array_index = BACNET_ARRAY_ALL - 1;
status = Channel_Write_Property(&wp_data);
zassert_false(status, NULL);
/* read-only property */
wp_data.array_index = BACNET_ARRAY_ALL;
wp_data.priority = BACNET_MAX_PRIORITY;
wp_data.object_property = PROP_OBJECT_TYPE;
value.tag = BACNET_APPLICATION_TAG_ENUMERATED;
value.type.Enumerated = OBJECT_ANALOG_INPUT;
wp_data.application_data_len =
bacapp_encode_application_data(wp_data.application_data, &value);
status = Channel_Write_Property(&wp_data);
zassert_equal(wp_data.error_class, ERROR_CLASS_PROPERTY, NULL);
zassert_equal(wp_data.error_code, ERROR_CODE_WRITE_ACCESS_DENIED, NULL);
zassert_false(status, NULL);
/* present-value API */
channel_value.tag = BACNET_APPLICATION_TAG_REAL;
channel_value.type.Real = 3.14159f;
status = Channel_Present_Value_Set(instance, 1, &channel_value);
zassert_true(status, NULL);
/* cleanup */
status = Channel_Delete(instance);
zassert_true(status, NULL);
Channel_Cleanup();
}
/**
* @}
@@ -154,7 +246,8 @@ static void test_Channel_ReadProperty(void)
void test_main(void)
{
ztest_test_suite(channel_tests, ztest_unit_test(test_Channel_ReadProperty));
ztest_test_suite(
channel_tests, ztest_unit_test(test_Channel_Property_Read_Write));
ztest_run_test_suite(channel_tests);
}
@@ -62,6 +62,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/device_mock.c
@@ -62,6 +62,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/device_mock.c
@@ -60,6 +60,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/property_test.c
@@ -63,6 +63,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/property_test.c
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/memcopy.c
# Test and test library files
./src/main.c
@@ -106,6 +106,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
./stubs.c
# Test and test library files
./src/main.c
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
@@ -69,6 +69,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/datetime_local.c
@@ -63,6 +63,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/device_mock.c
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/property_test.c
@@ -63,6 +63,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
${SRC_DIR}/bacnet/basic/sys/keylist.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/property_test.c
@@ -60,6 +60,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/basic/sys/debug.c
@@ -63,6 +63,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./stubs.c
./src/main.c
@@ -55,6 +55,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/proplist.c
${SRC_DIR}/bacnet/property.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/wp.c
${SRC_DIR}/bacnet/weeklyschedule.c
@@ -62,6 +63,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/property_test.c
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -60,6 +60,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/property_test.c
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/basic/sys/debug.c
${SRC_DIR}/bacnet/basic/sys/keylist.c
@@ -63,6 +63,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/datetime_local.c
@@ -60,6 +60,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${TST_DIR}/bacnet/basic/object/test/device_mock.c
+50
View File
@@ -0,0 +1,50 @@
# SPDX-License-Identifier: MIT
cmake_minimum_required(VERSION 3.10 FATAL_ERROR)
get_filename_component(basename ${CMAKE_CURRENT_SOURCE_DIR} NAME)
project(test_${basename}
VERSION 1.0.0
LANGUAGES C)
string(REGEX REPLACE
"/test/bacnet/[a-zA-Z_/-]*$"
"/src"
SRC_DIR
${CMAKE_CURRENT_SOURCE_DIR})
string(REGEX REPLACE
"/test/bacnet/[a-zA-Z_/-]*$"
"/test"
TST_DIR
${CMAKE_CURRENT_SOURCE_DIR})
set(ZTST_DIR "${TST_DIR}/ztest/src")
add_compile_definitions(
BIG_ENDIAN=0
CONFIG_ZTEST=1
BACAPP_ALL
)
include_directories(
${SRC_DIR}
${TST_DIR}/ztest/include
)
add_executable(${PROJECT_NAME}
# File(s) under test
${SRC_DIR}/bacnet/channel_value.c
# Support files and stubs (pathname alphabetical)
${SRC_DIR}/bacnet/bacdcode.c
${SRC_DIR}/bacnet/bacint.c
${SRC_DIR}/bacnet/bacreal.c
${SRC_DIR}/bacnet/bacstr.c
${SRC_DIR}/bacnet/bactext.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/indtext.c
${SRC_DIR}/bacnet/lighting.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
${ZTST_DIR}/ztest.c
)
+147
View File
@@ -0,0 +1,147 @@
/**
* @file
* @brief Unit test for BACnetChannelValue.
* @author Steve Karg <skarg@users.sourceforge.net>
* @date October 2024
* @copyright SPDX-License-Identifier: MIT
*/
#include <stdint.h>
#include <stdbool.h>
#include <string.h>
#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>
#include <zephyr/ztest.h>
#include "bacnet/bactext.h"
#include "bacnet/channel_value.h"
/**
* @addtogroup bacnet_tests
* @{
*/
/** @brief try decoding a real sample from Siemens, captured with wireshark */
#if defined(CONFIG_ZTEST_NEW_API)
ZTEST(BACnetChannelValue_Tests, test_BACnetChannelValue)
#else
static void test_BACnetChannelValue(void)
#endif
{
uint8_t apdu[MAX_APDU];
int apdu_len, test_len, null_len;
bool status;
BACNET_CHANNEL_VALUE *value;
BACNET_CHANNEL_VALUE case_value[] = {
{ .tag = BACNET_APPLICATION_TAG_NULL, .type.Real = 0.0f, .next = NULL },
{ .tag = BACNET_APPLICATION_TAG_BOOLEAN,
.type.Boolean = false,
.next = NULL },
{ .tag = BACNET_APPLICATION_TAG_UNSIGNED_INT,
.type.Unsigned_Int = 0xDEADBEEF,
.next = NULL },
{ .tag = BACNET_APPLICATION_TAG_SIGNED_INT,
.type.Signed_Int = 0x00C0FFEE,
.next = NULL },
{ .tag = BACNET_APPLICATION_TAG_REAL,
.type.Real = 3.141592654f,
.next = NULL },
{ .tag = BACNET_APPLICATION_TAG_DOUBLE,
.type.Double = 2.32323232323,
.next = NULL },
{ .tag = BACNET_APPLICATION_TAG_ENUMERATED,
.type.Enumerated = 0x0BADF00D,
.next = NULL },
{ .tag = BACNET_APPLICATION_TAG_LIGHTING_COMMAND,
.type.Lighting_Command.operation = BACNET_LIGHTS_NONE,
.next = NULL },
{ .tag = BACNET_APPLICATION_TAG_COLOR_COMMAND,
.type.Color_Command.operation = BACNET_COLOR_OPERATION_NONE,
.next = NULL },
{ .tag = BACNET_APPLICATION_TAG_XY_COLOR,
.type.XY_Color.x_coordinate = 0.0f,
.type.XY_Color.y_coordinate = 0.0f,
.next = NULL },
};
struct ascii_channel_value {
const char *string;
BACNET_APPLICATION_TAG tag;
} ascii_values[] = {
{ "NULL", BACNET_APPLICATION_TAG_NULL },
{ "FALSE", BACNET_APPLICATION_TAG_BOOLEAN },
{ "1234567890", BACNET_APPLICATION_TAG_UNSIGNED_INT },
{ "-1234567890", BACNET_APPLICATION_TAG_SIGNED_INT },
{ "3.141592654", BACNET_APPLICATION_TAG_REAL },
{ "-3.141592654", BACNET_APPLICATION_TAG_REAL },
{ "F1.21", BACNET_APPLICATION_TAG_REAL },
{ "f1.21", BACNET_APPLICATION_TAG_REAL },
{ "D1.21", BACNET_APPLICATION_TAG_DOUBLE },
{ "d1.21", BACNET_APPLICATION_TAG_DOUBLE },
{ "L0", BACNET_APPLICATION_TAG_LIGHTING_COMMAND },
{ "l0", BACNET_APPLICATION_TAG_LIGHTING_COMMAND },
{ "C0", BACNET_APPLICATION_TAG_COLOR_COMMAND },
{ "c0", BACNET_APPLICATION_TAG_COLOR_COMMAND },
{ "X0.0,0.0", BACNET_APPLICATION_TAG_XY_COLOR },
{ "x0.0,0.0", BACNET_APPLICATION_TAG_XY_COLOR },
};
size_t i;
BACNET_CHANNEL_VALUE test_value = { 0 };
bacnet_channel_value_link_array(case_value, ARRAY_SIZE(case_value));
value = &case_value[0];
while (value) {
null_len = bacnet_channel_value_encode(NULL, sizeof(apdu), value);
if (value->tag != BACNET_APPLICATION_TAG_NULL) {
zassert_not_equal(null_len, 0, NULL);
}
apdu_len = bacnet_channel_value_encode(apdu, sizeof(apdu), value);
zassert_equal(
apdu_len, null_len, "value->tag: %s len=%d null_len=%d",
bactext_application_tag_name(value->tag), apdu_len, null_len);
test_len = bacnet_channel_value_decode(apdu, apdu_len, &test_value);
zassert_not_equal(
test_len, BACNET_STATUS_ERROR, "value->tag: %s test_len=%d",
bactext_application_tag_name(value->tag), test_len);
zassert_equal(test_len, apdu_len, NULL);
zassert_equal(
value->tag, test_value.tag, "value->tag: %s test_tag=%s",
bactext_application_tag_name(value->tag),
bactext_application_tag_name(test_value.tag));
status = bacnet_channel_value_same(value, &test_value);
zassert_true(
status, "decode: different: %s",
bactext_application_tag_name(value->tag));
status = bacnet_channel_value_copy(&test_value, value);
zassert_true(
status, "copy: failed: %s",
bactext_application_tag_name(value->tag));
status = bacnet_channel_value_same(value, &test_value);
zassert_true(
status, "copy: different: %s",
bactext_application_tag_name(value->tag));
value = value->next;
}
for (i = 0; i < ARRAY_SIZE(ascii_values); i++) {
status = bacnet_channel_value_from_ascii(
&test_value, ascii_values[i].string);
zassert_true(status, "from_ascii: failed: %s", ascii_values[i].string);
zassert_equal(
test_value.tag, ascii_values[i].tag, "from_ascii: %s",
ascii_values[i].string);
}
}
/**
* @}
*/
#if defined(CONFIG_ZTEST_NEW_API)
ZTEST_SUITE(BACnetChannelValue_Tests, NULL, NULL, NULL, NULL, NULL);
#else
void test_main(void)
{
ztest_test_suite(
BACnetChannelValue_Tests, ztest_unit_test(test_BACnetChannelValue));
ztest_run_test_suite(BACnetChannelValue_Tests);
}
#endif
+1
View File
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -61,6 +61,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -60,6 +60,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1 -1
View File
@@ -57,7 +57,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/weeklyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
@@ -57,6 +57,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -58,6 +58,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+1
View File
@@ -59,6 +59,7 @@ add_executable(${PROJECT_NAME}
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
+66
View File
@@ -0,0 +1,66 @@
# SPDX-License-Identifier: MIT
cmake_minimum_required(VERSION 3.10 FATAL_ERROR)
get_filename_component(basename ${CMAKE_CURRENT_SOURCE_DIR} NAME)
project(test_${basename}
VERSION 1.0.0
LANGUAGES C)
string(REGEX REPLACE
"/test/bacnet/[a-zA-Z_/-]*$"
"/src"
SRC_DIR
${CMAKE_CURRENT_SOURCE_DIR})
string(REGEX REPLACE
"/test/bacnet/[a-zA-Z_/-]*$"
"/test"
TST_DIR
${CMAKE_CURRENT_SOURCE_DIR})
set(ZTST_DIR "${TST_DIR}/ztest/src")
add_compile_definitions(
BIG_ENDIAN=0
CONFIG_ZTEST=1
)
include_directories(
${SRC_DIR}
${TST_DIR}/ztest/include
)
add_executable(${PROJECT_NAME}
# File(s) under test
${SRC_DIR}/bacnet/write_group.c
# Support files and stubs (pathname alphabetical)
${SRC_DIR}/bacnet/access_rule.c
${SRC_DIR}/bacnet/bacaction.c
${SRC_DIR}/bacnet/bacaddr.c
${SRC_DIR}/bacnet/bacapp.c
${SRC_DIR}/bacnet/bacdcode.c
${SRC_DIR}/bacnet/bacdest.c
${SRC_DIR}/bacnet/bacdevobjpropref.c
${SRC_DIR}/bacnet/bacerror.c
${SRC_DIR}/bacnet/bacint.c
${SRC_DIR}/bacnet/bacreal.c
${SRC_DIR}/bacnet/bacstr.c
${SRC_DIR}/bacnet/bactext.c
${SRC_DIR}/bacnet/basic/sys/bigend.c
${SRC_DIR}/bacnet/datetime.c
${SRC_DIR}/bacnet/basic/sys/days.c
${SRC_DIR}/bacnet/hostnport.c
${SRC_DIR}/bacnet/lighting.c
${SRC_DIR}/bacnet/timestamp.c
${SRC_DIR}/bacnet/indtext.c
${SRC_DIR}/bacnet/weeklyschedule.c
${SRC_DIR}/bacnet/bactimevalue.c
${SRC_DIR}/bacnet/dailyschedule.c
${SRC_DIR}/bacnet/calendar_entry.c
${SRC_DIR}/bacnet/special_event.c
${SRC_DIR}/bacnet/channel_value.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
${ZTST_DIR}/ztest.c
)
+292
View File
@@ -0,0 +1,292 @@
/**
* @file
* @brief Unit test for WriteGroup service
* @author Steve Karg <skarg@users.sourceforge.net>
* @date October 2024
*
* SPDX-License-Identifier: MIT
*/
#include <zephyr/ztest.h>
#include <bacnet/write_group.h>
#define WRITE_GROUP_CHANNEL_LIST_MAX 8
/**
* @addtogroup bacnet_tests
* @{
*/
static void test_WriteGroup_Postive(BACNET_WRITE_GROUP_DATA *data)
{
int len = 0;
int apdu_len = 0;
bool status;
uint8_t apdu[480] = { 0 };
BACNET_WRITE_GROUP_DATA test_data = { 0 };
/* positive test */
len =
bacnet_write_group_service_request_encode(&apdu[0], sizeof(apdu), data);
zassert_true(len > 0, NULL);
apdu_len = len;
len = bacnet_write_group_service_request_decode(
&apdu[0], apdu_len, &test_data);
zassert_not_equal(len, BACNET_STATUS_ERROR, NULL);
zassert_equal(len, apdu_len, NULL);
status = bacnet_write_group_same(data, &test_data);
zassert_true(status, NULL);
/* negative decoding test */
while (--apdu_len) {
len = bacnet_write_group_service_request_decode(
apdu, apdu_len, &test_data);
/* inhibit delay is an optional element at the end of the
construction and the APDU is valid without it */
if (data->inhibit_delay == WRITE_GROUP_INHIBIT_DELAY_NONE) {
zassert_true(len <= 0, NULL);
}
}
/* negative encoding test */
len =
bacnet_write_group_service_request_encode(&apdu[0], sizeof(apdu), data);
zassert_true(len > 0, NULL);
apdu_len = len;
while (--apdu_len) {
len =
bacnet_write_group_service_request_encode(&apdu[0], apdu_len, data);
zassert_equal(len, 0, NULL);
}
}
/**
* @addtogroup bacnet_tests
* @{
*/
static void test_WriteGroup_Negative(BACNET_WRITE_GROUP_DATA *data)
{
int len = 0;
int apdu_len = 0;
uint8_t apdu[480] = { 0 };
BACNET_WRITE_GROUP_DATA test_data = { 0 };
len =
bacnet_write_group_service_request_encode(&apdu[0], sizeof(apdu), data);
zassert_true(len > 0, NULL);
apdu_len = len;
len = bacnet_write_group_service_request_decode(
&apdu[0], apdu_len, &test_data);
zassert_true(len < 0, NULL);
}
/**
* @brief callback for WriteGroup-Request iterator
* @param data [in] The contents of the WriteGroup-Request message
* @param change_list_index [in] The index of the current value in the change
* list
* @param change_list [in] The current value in the change list
*/
static void test_WriteGroup_Iterate_Value(
BACNET_WRITE_GROUP_DATA *data,
uint32_t change_list_index,
BACNET_GROUP_CHANNEL_VALUE *change_list)
{
BACNET_GROUP_CHANNEL_VALUE *value = NULL;
value = bacnet_write_group_change_list_element(data, change_list_index);
zassert_not_null(value, NULL);
zassert_true(bacnet_group_channel_value_same(value, change_list), NULL);
}
#if defined(CONFIG_ZTEST_NEW_API)
ZTEST(write_group_tests, test_WriteGroup_Iterate)
#else
static void test_WriteGroup_Iterate(void)
#endif
{
int len, test_len;
uint8_t apdu[480] = { 0 };
BACNET_WRITE_GROUP_DATA data = {
/* initial test values for sunny day use-case */
.group_number = 1,
.write_priority = BACNET_MIN_PRIORITY,
.change_list = { 0 },
.inhibit_delay = WRITE_GROUP_INHIBIT_DELAY_NONE,
.next = NULL
};
BACNET_GROUP_CHANNEL_VALUE value[WRITE_GROUP_CHANNEL_LIST_MAX] = { 0 };
BACNET_GROUP_CHANNEL_VALUE value_append = { 0 };
BACNET_GROUP_CHANNEL_VALUE *value_element = NULL;
unsigned count = 0;
unsigned index = 0;
bool status;
/* link the array of change-list to our data */
status = bacnet_write_group_change_list_array_link(
&data, value, ARRAY_SIZE(value));
zassert_true(status, NULL);
/* note: array + head */
for (index = 0; index < ARRAY_SIZE(value) + 1; index++) {
value_element = bacnet_write_group_change_list_element(&data, index);
zassert_not_null(value_element, NULL);
/* set some predictable values to be tested */
value_element->channel = index;
value_element->overriding_priority = index;
value_element->value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value_element->value.type.Unsigned_Int = index;
}
len = bacnet_write_group_service_request_encode(
&apdu[0], sizeof(apdu), &data);
zassert_true(len > 0, NULL);
test_len = bacnet_write_group_service_request_decode_iterate(
&apdu[0], len, &data, test_WriteGroup_Iterate_Value);
count = bacnet_write_group_change_list_count(&data);
zassert_equal(count, WRITE_GROUP_CHANNEL_LIST_MAX + 1, NULL);
/* validate append API */
value_append.channel = count;
value_append.overriding_priority = count;
value_append.value.tag = BACNET_APPLICATION_TAG_UNSIGNED_INT;
value_append.value.type.Unsigned_Int = count;
status = bacnet_write_group_change_list_append(&data, &value_append);
zassert_true(status, NULL);
count = bacnet_write_group_change_list_count(&data);
zassert_equal(count, WRITE_GROUP_CHANNEL_LIST_MAX + 2, NULL);
len = bacnet_write_group_service_request_encode(
&apdu[0], sizeof(apdu), &data);
zassert_true(len > 0, NULL);
test_len = bacnet_write_group_service_request_decode_iterate(
&apdu[0], len, &data, test_WriteGroup_Iterate_Value);
/* some negative testing for coverage */
count = bacnet_write_group_change_list_count(NULL);
zassert_equal(count, 0, NULL);
value_element = bacnet_write_group_change_list_element(NULL, 0);
zassert_true(value_element == NULL, NULL);
status = bacnet_write_group_change_list_array_link(NULL, NULL, 0);
zassert_false(status, NULL);
status = bacnet_write_group_change_list_append(NULL, NULL);
zassert_false(status, NULL);
status = bacnet_write_group_change_list_append(&data, NULL);
zassert_false(status, NULL);
status = bacnet_write_group_change_list_append(NULL, &value_append);
zassert_false(status, NULL);
}
#if defined(CONFIG_ZTEST_NEW_API)
ZTEST(write_group_tests, test_WriteGroup)
#else
static void test_WriteGroup(void)
#endif
{
int len = 0;
uint8_t apdu[480] = { 0 };
BACNET_WRITE_GROUP_DATA data = {
/* initial test values for sunny day use-case */
.group_number = 1,
.write_priority = BACNET_MIN_PRIORITY,
.change_list = { 0 },
.inhibit_delay = WRITE_GROUP_INHIBIT_DELAY_NONE,
.next = NULL
};
/* negative test */
len =
bacnet_write_group_service_request_encode(&apdu[0], sizeof(apdu), NULL);
zassert_false(len > 0, NULL);
/* positive tests */
data.inhibit_delay = WRITE_GROUP_INHIBIT_DELAY_TRUE;
test_WriteGroup_Postive(&data);
data.inhibit_delay = WRITE_GROUP_INHIBIT_DELAY_FALSE;
test_WriteGroup_Postive(&data);
data.inhibit_delay = WRITE_GROUP_INHIBIT_DELAY_NONE;
test_WriteGroup_Postive(&data);
data.write_priority = 0;
test_WriteGroup_Negative(&data);
data.write_priority = BACNET_MAX_PRIORITY + 1;
test_WriteGroup_Negative(&data);
data.write_priority = BACNET_MAX_PRIORITY;
test_WriteGroup_Postive(&data);
data.group_number = 0;
test_WriteGroup_Negative(&data);
data.group_number = 1;
}
/**
* @}
*/
#if defined(CONFIG_ZTEST_NEW_API)
ZTEST(write_group_tests, test_WriteGroup_Same)
#else
static void test_WriteGroup_Same(void)
#endif
{
bool status;
BACNET_WRITE_GROUP_DATA data = {
/* initial test values for sunny day use-case */
.group_number = 1,
.write_priority = BACNET_MIN_PRIORITY,
.change_list = { 0 },
.inhibit_delay = WRITE_GROUP_INHIBIT_DELAY_NONE,
.next = NULL
};
BACNET_WRITE_GROUP_DATA test_data = { 0 };
status = bacnet_write_group_same(&data, &test_data);
zassert_false(status, NULL);
status = bacnet_write_group_copy(NULL, &data);
zassert_false(status, NULL);
status = bacnet_write_group_copy(&test_data, NULL);
zassert_false(status, NULL);
status = bacnet_write_group_copy(&test_data, &data);
zassert_true(status, NULL);
status = bacnet_write_group_same(&data, &test_data);
zassert_true(status, NULL);
status = bacnet_write_group_same(NULL, &test_data);
zassert_false(status, NULL);
status = bacnet_write_group_same(&data, NULL);
zassert_false(status, NULL);
status = bacnet_write_group_copy(&test_data, &data);
test_data.group_number = 0;
status = bacnet_write_group_same(&data, &test_data);
zassert_false(status, NULL);
status = bacnet_write_group_copy(&test_data, &data);
test_data.write_priority = BACNET_MAX_PRIORITY;
status = bacnet_write_group_same(&data, &test_data);
zassert_false(status, NULL);
status = bacnet_write_group_copy(&test_data, &data);
test_data.inhibit_delay = WRITE_GROUP_INHIBIT_DELAY_TRUE;
status = bacnet_write_group_same(&data, &test_data);
zassert_false(status, NULL);
status = bacnet_write_group_copy(&test_data, &data);
test_data.change_list.channel = 1;
status = bacnet_write_group_same(&data, &test_data);
zassert_false(status, NULL);
status = bacnet_write_group_copy(&test_data, &data);
test_data.change_list.overriding_priority = 1;
status = bacnet_write_group_same(&data, &test_data);
zassert_false(status, NULL);
status = bacnet_write_group_copy(&test_data, &data);
test_data.change_list.value.tag = BACNET_APPLICATION_TAG_BOOLEAN;
test_data.change_list.value.type.Boolean = true;
status = bacnet_write_group_same(&data, &test_data);
zassert_false(status, NULL);
}
#if defined(CONFIG_ZTEST_NEW_API)
ZTEST_SUITE(write_group_tests, NULL, NULL, NULL, NULL, NULL);
#else
void test_main(void)
{
ztest_test_suite(
write_group_tests, ztest_unit_test(test_WriteGroup),
ztest_unit_test(test_WriteGroup_Same),
ztest_unit_test(test_WriteGroup_Iterate));
ztest_run_test_suite(write_group_tests);
}
#endif