dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix keylist signed integer wraparound (#179)

Browse Source 
* Fix keylist signed integer wraparound

Fix the keylist to handle large number of nodes where the signed integer
would wrap around.

* Add explict keylist new size case for less than zero

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
Co-authored-by: Steve Karg <steve.karg@legrand.us>
This commit is contained in:
Steve Karg
2021-06-12 22:37:51 -05:00
committed by GitHub
parent 89d7af707e
commit 31b7fb3c40
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bacnet/basic/sys/keylist.c
+4 -1
View File
@@ -101,7 +101,7 @@ static int CheckArraySize(OS_Keylist list)
} else if ((list->size > chunk) && (list->count < (list->size - chunk))) { } else if ((list->size > chunk) && (list->count < (list->size - chunk))) {
new_size = list->size - chunk; new_size = list->size - chunk;
} }
if (new_size) { if (new_size > 0) {
/* Allocate more room for node pointer array */ /* Allocate more room for node pointer array */
new_array = calloc((size_t)new_size, sizeof(struct Keylist_Node *)); new_array = calloc((size_t)new_size, sizeof(struct Keylist_Node *));
@@ -119,7 +119,10 @@ static int CheckArraySize(OS_Keylist list)
} }
list->array = new_array; list->array = new_array;
list->size = new_size; list->size = new_size;
} else if (new_size < 0) {
return FALSE;
} }
return TRUE; return TRUE;
} }