From 28644040e79259915cb7ccd5e59a96093f28820a Mon Sep 17 00:00:00 2001 From: Kari Argillander Date: Tue, 29 Nov 2022 22:31:26 +0200 Subject: [PATCH] Fix: Use memmove with overlapping data (#361) We should use memmove instead of memcpy when things can overlap. I was looking little bit whole repo and this got my eye. --- apps/epics/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/epics/main.c b/apps/epics/main.c index 52c69699..78cea5ac 100644 --- a/apps/epics/main.c +++ b/apps/epics/main.c @@ -678,7 +678,7 @@ static void PrintReadPropertyData(BACNET_OBJECT_TYPE object_type, int iLast15idx = value->type.Character_String.length - 15; value->type.Character_String.value[15] = '-'; - memcpy(&value->type.Character_String.value[16], + memmove(&value->type.Character_String.value[16], &value->type.Character_String.value[iLast15idx], 15); value->type.Character_String.value[31] = 0;