dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed BACnet/SC secure connect VMAC, UUID, and initialization sequence (#1142)

Browse Source 
* Refactored the BACnet/SC datalink initialization order by moving certificate file checks and hub connection registration to occur after datalink initialization
* Replaced stdlib rand() with platform-specific cryptographically secure random functions (RtlGenRandom for Windows, getrandom for Linux, arc4random_buf for BSD) to generate UUID and VMAC addresses, preventing duplicates that broke connections
* Enabled conditional debug output in BACnet/SC components when BUILD=debug is specified
This commit is contained in:
Steve Karg
2025-11-14 15:41:17 -06:00
committed by GitHub
parent 74972bd025
commit 25d14c7c15
30 changed files with 672 additions and 339 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/bacnet/basic/object/netport/CMakeLists.txt
+1
View File
@@ -35,6 +35,7 @@ add_compile_definitions(
BACNET_SC_DIRECT_ACCEPT_URI_MAX=6
MAX_TSM_TRANSACTIONS=0
BSC_CONF_TX_PRE=0
BACFILE=1
)
include_directories(
test/bacnet/datalink/bsc-datalink/src/main.c
+2 -2
View File
@@ -10169,7 +10169,7 @@ static void test_sc_datalink(void)
init_node_ev(&node_ev2);
init_node_ev(&node_ev3);
zassert_equal(bsc_cert_files_check(), true, NULL);
zassert_equal(bsc_cert_files_check(SC_DATALINK_INSTANCE), true, NULL);
zassert_equal(bsc_init(NULL), true, NULL);
zassert_equal(bsc_init(NULL), false, NULL);
memset(broadcast, 0xFF, sizeof(broadcast));
@@ -10432,7 +10432,7 @@ static void test_sc_datalink_properties(void)
init_node_ev(&node_ev2);
init_node_ev(&node_ev3);
init_node_ev(&node_ev4);
zassert_equal(bsc_cert_files_check(), true, NULL);
zassert_equal(bsc_cert_files_check(SC_DATALINK_INSTANCE), true, NULL);
zassert_equal(bsc_init(NULL), true, NULL);
conf2.ca_cert_chain = ca_cert;