Fixed BACnet/SC secure connect VMAC, UUID, and initialization sequence (#1142)

* Refactored the BACnet/SC datalink initialization order by moving certificate file checks and hub connection registration to occur after datalink initialization
* Replaced stdlib rand() with platform-specific cryptographically secure random functions (RtlGenRandom for Windows, getrandom for Linux, arc4random_buf for BSD) to generate UUID and VMAC addresses, preventing duplicates that broke connections
* Enabled conditional debug output in BACnet/SC components when BUILD=debug is specified

ports/linux/bsc-event.c

@@ -1,6 +1,6 @@
 /**
  * @file
- * @brief  Implementation of mutex abstraction used in BACNet secure connect.
+ * @brief Implementation of port specific API used in BACNet secure connect.
  * @author Kirill Neznamov <kirill.neznamov@dsr-corporation.com>
  * @date August 2022
  * @copyright SPDX-License-Identifier: GPL-2.0-or-later WITH GCC-exception-2.0
@@ -11,13 +11,12 @@
 #include <pthread.h>
 #include <stdbool.h>
 #include <unistd.h>
+#include <sys/random.h>
 #include "bacnet/basic/sys/debug.h"
 #include "bacnet/datalink/bsc/bsc-event.h"
 
-#define DEBUG_BSC_EVENT 0
-
 #undef DEBUG_PRINTF
-#if DEBUG_BSC_EVENT == 1
+#if DEBUG_BSC_EVENT
 #define DEBUG_PRINTF printf
 #else
 #undef DEBUG_ENABLED
@@ -179,3 +178,25 @@ void bsc_wait_ms(int mseconds)
 {
     usleep(mseconds * 1000);
 }
+
+void bsc_generate_random_vmac(BACNET_SC_VMAC_ADDRESS *p)
+{
+    getrandom(p->address, BVLC_SC_VMAC_SIZE, 0);
+
+    /* According H.7.3 EUI-48 and Random-48 VMAC Address:
+       The Random-48 VMAC is a 6-octet VMAC address in which the least
+       significant 4 bits (Bit 3 to Bit 0) in the first octet shall be
+       B'0010' (X'2'), and all other 44 bits are randomly selected to be
+       0 or 1. */
+    p->address[0] = (p->address[0] & 0xF0) | 0x02;
+
+    debug_printf_hex(
+        0, p->address, BVLC_SC_VMAC_SIZE, "bsc_generate_random_vmac:");
+}
+
+void bsc_generate_random_uuid(BACNET_SC_UUID *p)
+{
+    getrandom(p->uuid, BVLC_SC_UUID_SIZE, 0);
+    debug_printf_hex(
+        0, p->uuid, BVLC_SC_UUID_SIZE, "bsc_generate_random_uuid:");
+}

ports/linux/websocket-cli.c

@@ -15,10 +15,8 @@
 #include "bacnet/basic/sys/debug.h"
 #include "websocket-global.h"
 
-#define DEBUG_WEBSOCKET_CLIENT 0
-
 #undef DEBUG_PRINTF
-#if DEBUG_WEBSOCKET_CLIENT == 1
+#if DEBUG_WEBSOCKET_CLIENT
 #define DEBUG_PRINTF debug_printf
 #else
 #undef DEBUG_ENABLED

ports/linux/websocket-srv.c

@@ -16,10 +16,8 @@
 #include "websocket-global.h"
 #include <arpa/inet.h>
 
-#define DEBUG_WEBSOCKET_SERVER 0
-
 #undef DEBUG_PRINTF
-#if DEBUG_WEBSOCKET_SERVER == 1
+#if DEBUG_WEBSOCKET_SERVER
 #define DEBUG_PRINTF debug_printf
 #else
 #undef DEBUG_ENABLED