dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor BACnet Address utility functions (#390)

Browse Source 
* refactor BACnet Address utility functions

---------

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
This commit is contained in:
Steve Karg
2023-02-04 08:46:31 -06:00
committed by GitHub
parent 85976ee1f8
commit 236c2d1003
17 changed files with 490 additions and 221 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/CMakeLists.txt
+1
View File
@@ -41,6 +41,7 @@ list(APPEND testdirs
bacnet/alarm_ack
bacnet/arf
bacnet/awf
bacnet/bacaddr
bacnet/bacapp
bacnet/bacdcode
bacnet/bacdevobjpropref
test/bacnet/bacaddr/CMakeLists.txt
+43
View File
@@ -0,0 +1,43 @@
# SPDX-License-Identifier: MIT
cmake_minimum_required(VERSION 3.10 FATAL_ERROR)
get_filename_component(basename ${CMAKE_CURRENT_SOURCE_DIR} NAME)
project(test_${basename}
VERSION 1.0.0
LANGUAGES C)
string(REGEX REPLACE
"/test/bacnet/[a-zA-Z_/-]*$"
"/src"
SRC_DIR
${CMAKE_CURRENT_SOURCE_DIR})
string(REGEX REPLACE
"/test/bacnet/[a-zA-Z_/-]*$"
"/test"
TST_DIR
${CMAKE_CURRENT_SOURCE_DIR})
set(ZTST_DIR "${TST_DIR}/ztest/src")
add_compile_definitions(
BIG_ENDIAN=0
CONFIG_ZTEST=1
BACAPP_ALL
)
include_directories(
${SRC_DIR}
${TST_DIR}/ztest/include
)
add_executable(${PROJECT_NAME}
# File(s) under test
${SRC_DIR}/bacnet/bacaddr.c
# Support files and stubs (pathname alphabetical)
${SRC_DIR}/bacnet/bacint.c
# Test and test library files
./src/main.c
${ZTST_DIR}/ztest_mock.c
${ZTST_DIR}/ztest.c
)
test/bacnet/bacaddr/src/main.c
+186
View File
@@ -0,0 +1,186 @@
/**
* @file
* @brief Unit test for BACNET_ADDRESS copy, init, compare
* @author Steve Karg <skarg@users.sourceforge.net>
* @date January 2023
*
* SPDX-License-Identifier: MIT
*/
#include <zephyr/ztest.h>
#include <bacnet/bacaddr.h>
/**
* @addtogroup bacnet_tests
* @{
*/
static void test_BACNET_ADDRESS(void)
{
BACNET_ADDRESS src = { 0 }, dest = { 0 };
BACNET_ADDRESS test_src = { 0 }, test_dest = { 0 };
BACNET_MAC_ADDRESS mac = { 0 }, adr = { 0 };
uint16_t dnet = 0;
bool status = false;
/* invalid parameters */
status = bacnet_address_same(NULL, &dest);
zassert_false(status, NULL);
status = bacnet_address_same(&dest, NULL);
zassert_false(status, NULL);
status = bacnet_address_same(NULL, NULL);
zassert_false(status, NULL);
/* happy day cases */
status = bacnet_address_same(&dest, &dest);
zassert_true(status, NULL);
bacnet_address_copy(&dest, &src);
status = bacnet_address_same(&dest, &src);
zassert_true(status, NULL);
status = bacnet_address_init(&dest, &mac, dnet, &adr);
zassert_true(status, NULL);
status = bacnet_address_init(&src, &mac, dnet, &adr);
zassert_true(status, NULL);
status = bacnet_address_same(&dest, &src);
zassert_true(status, NULL);
/* remote dnet is non-zero */
dnet = 1;
status = bacnet_address_init(&dest, &mac, dnet, &adr);
zassert_true(status, NULL);
status = bacnet_address_init(&src, &mac, dnet, &adr);
zassert_true(status, NULL);
status = bacnet_address_same(&dest, &src);
zassert_true(status, NULL);
/* different src->len */
bacnet_address_copy(&dest, &src);
src.len = 4;
status = bacnet_address_same(&dest, &src);
zassert_false(status, NULL);
/* large src->len */
src.len = MAX_MAC_LEN;
status = bacnet_address_same(&dest, &src);
zassert_false(status, NULL);
bacnet_address_copy(&dest, &src);
/* different src->dnet */
dnet = 12;
status = bacnet_address_init(&src, &mac, dnet, &adr);
zassert_true(status, NULL);
status = bacnet_address_same(&dest, &src);
zassert_false(status, NULL);
/* init checking */
status = bacnet_address_init(NULL, &mac, dnet, &adr);
zassert_false(status, NULL);
mac.len = MAX_MAC_LEN;
status = bacnet_address_init(&dest, &mac, dnet, &adr);
zassert_true(status, NULL);
adr.len = MAX_MAC_LEN;
status = bacnet_address_init(&dest, &mac, dnet, &adr);
zassert_true(status, NULL);
/* remote dnet adr is different */
dnet = 1;
status = bacnet_address_init(&dest, &mac, dnet, &adr);
zassert_true(status, NULL);
status = bacnet_address_init(&src, &mac, dnet, &adr);
src.adr[MAX_MAC_LEN-1] = 1;
status = bacnet_address_same(&dest, &src);
zassert_false(status, NULL);
/* mac_len is different */
dnet = 0;
status = bacnet_address_init(&dest, &mac, dnet, &adr);
zassert_true(status, NULL);
status = bacnet_address_init(&src, &mac, dnet, &adr);
src.mac_len = MAX_MAC_LEN;
dest.mac_len = MAX_MAC_LEN;
status = bacnet_address_same(&dest, &src);
zassert_true(status, NULL);
dest.mac_len = 1;
status = bacnet_address_same(&dest, &src);
zassert_false(status, NULL);
}
static void test_BACNET_MAC_ADDRESS(void)
{
BACNET_MAC_ADDRESS dest = { 0 }, src = { 0 };
uint8_t adr[MAX_MAC_LEN] = { 0 };
uint8_t len = MAX_MAC_LEN;
bool status = false;
const char *bip_ascii = "255.255.255.255:47808";
const char *bip_ascii_no_port = "255.255.255.255";
const char *ethernet_ascii = "f0:f1:f2:f3:f4:f5";
const char *mstp_ascii = "7F";
const char *vmac_ascii = "12:34:56";
bacnet_address_mac_init(&src, adr, len);
bacnet_address_mac_init(&dest, adr, len);
status = bacnet_address_mac_same(&dest, &src);
zassert_true(status, NULL);
status = bacnet_address_mac_same(NULL, &src);
zassert_false(status, NULL);
status = bacnet_address_mac_same(&dest, NULL);
zassert_false(status, NULL);
bacnet_address_mac_init(&src, NULL, 0);
bacnet_address_mac_init(&dest, NULL, 0);
status = bacnet_address_mac_same(&dest, &src);
zassert_true(status, NULL);
bacnet_address_mac_init(&src, adr, 1);
bacnet_address_mac_init(&dest, adr, 2);
status = bacnet_address_mac_same(&dest, &src);
zassert_false(status, NULL);
status = bacnet_address_mac_from_ascii(&dest, bip_ascii);
zassert_true(status, NULL);
zassert_equal(dest.len, 6, NULL);
zassert_equal(dest.adr[0], 255, NULL);
zassert_equal(dest.adr[1], 255, NULL);
zassert_equal(dest.adr[2], 255, NULL);
zassert_equal(dest.adr[3], 255, NULL);
status = bacnet_address_mac_from_ascii(&dest, bip_ascii_no_port);
zassert_true(status, NULL);
status = bacnet_address_mac_from_ascii(&dest, ethernet_ascii);
zassert_equal(dest.len, 6, NULL);
zassert_equal(dest.adr[0], 0xf0, NULL);
zassert_equal(dest.adr[1], 0xf1, NULL);
zassert_equal(dest.adr[2], 0xf2, NULL);
zassert_equal(dest.adr[3], 0xf3, NULL);
zassert_equal(dest.adr[4], 0xf4, NULL);
zassert_equal(dest.adr[5], 0xf5, NULL);
zassert_true(status, NULL);
status = bacnet_address_mac_from_ascii(&dest, mstp_ascii);
zassert_true(status, NULL);
zassert_equal(dest.len, 1, NULL);
zassert_equal(dest.adr[0], 0x7f, NULL);
status = bacnet_address_mac_from_ascii(&dest, vmac_ascii);
zassert_true(status, NULL);
zassert_equal(dest.len, 3, NULL);
zassert_equal(dest.adr[0], 0x12, NULL);
zassert_equal(dest.adr[1], 0x34, NULL);
zassert_equal(dest.adr[2], 0x56, NULL);
/* different MAC of same len */
status = bacnet_address_mac_from_ascii(&src, vmac_ascii);
zassert_true(status, NULL);
dest.adr[1] = 0x11;
dest.adr[2] = 0x22;
dest.adr[3] = 0x33;
status = bacnet_address_mac_same(&dest, &src);
zassert_false(status, NULL);
/* NULL parameters */
status = bacnet_address_mac_from_ascii(NULL, vmac_ascii);
zassert_false(status, NULL);
status = bacnet_address_mac_from_ascii(&dest, NULL);
zassert_false(status, NULL);
}
/**
* @}
*/
void test_main(void)
{
ztest_test_suite(bacnet_address_tests,
ztest_unit_test(test_BACNET_ADDRESS),
ztest_unit_test(test_BACNET_MAC_ADDRESS)
);
ztest_run_test_suite(bacnet_address_tests);
}