dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed off-by-one bug in gateway main() causing duplicate I-Am broadcast (#1289)

Browse Source 
When Routed_Device_Index reached MAX_NUM_DEVICES, Get_Routed_Device_Object()
returned NULL without updating iCurrent_Device_Idx, causing Send_I_Am() to
broadcast the previous device's I-Am again.

* Initialize Routed_Device_Index to 1 (first routed device index)
* Move increment after Send_I_Am() to prevent out-of-bounds access

Signed-off-by: kimhyeongjun <hjun1.kim@samsung.com>
This commit is contained in:
Hyeongjun Kim
2026-03-31 22:44:08 +09:00
committed by GitHub
parent f408b6eb7f
commit 236250492e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/gateway/main.c
+2 -2
View File
@@ -61,7 +61,7 @@ int DNET_list[2] = {
static const char *BACnet_Version = BACNET_VERSION_TEXT; static const char *BACnet_Version = BACNET_VERSION_TEXT;
/* routed devices - I-Am on startup */ /* routed devices - I-Am on startup */
static unsigned Routed_Device_Index; static unsigned Routed_Device_Index = 1;
/** Initialize the Device Objects and each of the child Object instances. /** Initialize the Device Objects and each of the child Object instances.
* @param first_object_instance Set the first (gateway) Device to this * @param first_object_instance Set the first (gateway) Device to this
@@ -278,10 +278,10 @@ int main(int argc, char *argv[])
} }
handler_cov_task(); handler_cov_task();
if (Routed_Device_Index < MAX_NUM_DEVICES) { if (Routed_Device_Index < MAX_NUM_DEVICES) {
Routed_Device_Index++;
Get_Routed_Device_Object(Routed_Device_Index); Get_Routed_Device_Object(Routed_Device_Index);
/* broadcast an I-Am for each routed Device now */ /* broadcast an I-Am for each routed Device now */
Send_I_Am(&Handler_Transmit_Buffer[0]); Send_I_Am(&Handler_Transmit_Buffer[0]);
Routed_Device_Index++;
} }
} }
/* Dummy return */ /* Dummy return */