Nikola noticed that error reporting for Write-Property-Multiple is different in a sense that WPM sends three more parameters: object_id, property and array index. However, in demo/handlers/h_wpm.c, error reporting is done through bacerror_encode_apdu instead of wpm_error_ack_encode_apdu. Nikola suggests that this should be changed. Thank you, Nikola!
This commit is contained in:
@@ -174,10 +174,10 @@ void handler_write_property_multiple(
|
|||||||
fprintf(stderr, "WPM: Sending Abort!\n");
|
fprintf(stderr, "WPM: Sending Abort!\n");
|
||||||
#endif
|
#endif
|
||||||
} else if (len == BACNET_STATUS_ERROR) {
|
} else if (len == BACNET_STATUS_ERROR) {
|
||||||
apdu_len =
|
apdu_len = wpm_error_ack_encode_apdu(
|
||||||
bacerror_encode_apdu(&Handler_Transmit_Buffer[npdu_len],
|
&Handler_Transmit_Buffer[npdu_len],
|
||||||
service_data->invoke_id, SERVICE_CONFIRMED_WRITE_PROP_MULTIPLE,
|
service_data->invoke_id,
|
||||||
wp_data.error_class, wp_data.error_code);
|
&wp_data);
|
||||||
#if PRINT_ENABLED
|
#if PRINT_ENABLED
|
||||||
fprintf(stderr, "WPM: Sending Error!\n");
|
fprintf(stderr, "WPM: Sending Error!\n");
|
||||||
#endif
|
#endif
|
||||||
|
|||||||
Reference in New Issue
Block a user