dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged revision(s) 2706 from branches/obvius/bacnet-stack:

Browse Source 
Fix: BVLC-Delete-Foreign-Device always returns NAK.
    uninitialized 'port' var. Use sin.sin_port instead.

........
This commit is contained in:
skarg
2014-01-16 20:01:18 +00:00
parent 563665dfe7
commit 1738701f81
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bacnet-stack/src/bvlc.c
+1 -2
View File
@@ -626,11 +626,10 @@ static bool bvlc_delete_foreign_device(
uint8_t * pdu) uint8_t * pdu)
{ {
struct sockaddr_in sin = { 0 }; /* the ip address */ struct sockaddr_in sin = { 0 }; /* the ip address */
uint16_t port = 0; /* the decoded port */
bool status = false; /* return value */ bool status = false; /* return value */
unsigned i = 0; unsigned i = 0;
bvlc_decode_bip_address(pdu, &sin.sin_addr, &port); bvlc_decode_bip_address(pdu, &sin.sin_addr, &sin.sin_port);
for (i = 0; i < MAX_FD_ENTRIES; i++) { for (i = 0; i < MAX_FD_ENTRIES; i++) {
if (FD_Table[i].valid) { if (FD_Table[i].valid) {
if ((FD_Table[i].dest_address.s_addr == sin.sin_addr.s_addr) && if ((FD_Table[i].dest_address.s_addr == sin.sin_addr.s_addr) &&