writing unit tests

bacnet-stack/bacenum.h

@@ -186,9 +186,6 @@ typedef enum
   PROP_MAXIMUM_VALUE_TIMESTAMP = 149,
   PROP_MINIMUM_VALUE_TIMESTAMP = 150,
   PROP_VARIANCE_VALUE = 151,
-  PROP_MAXIMUM_VALUE_TIMESTAMP = 149,
-  PROP_MINIMUM_VALUE_TIMESTAMP = 150,
-  PROP_VARIANCE_VALUE = 151,
   PROP_ACTIVE_COV_SUBSCRIPTIONS = 152,
   PROP_BACKUP_FAILURE_TIMEOUT = 153,
   PROP_CONFIGURATION_FILES = 154,
@@ -476,7 +473,7 @@ typedef enum
   LIFE_SAFETY_MODE_DISCONNECTED = 10,
   LIFE_SAFETY_MODE_ENABLED = 11,
   LIFE_SAFETY_MODE_DISABLED = 12,
-  LIFE_SAFETY_MODE_AUTOMATIC-RELEASE-DISABLED = 13,
+  LIFE_SAFETY_MODE_AUTOMATIC_RELEASE_DISABLED = 13,
   LIFE_SAFETY_MODE_DEFAULT = 14,
   // Enumerated values 0-255 are reserved for definition by ASHRAE. 
   // Enumerated values 256-65535 may be used by others subject to 
@@ -608,18 +605,30 @@ typedef enum
   CHARACTER_ISO8859 = 5,
 } BACNET_CHARACTER_STRING;
 
-typedef enum
-{
-  SERVICE_SUBSCRIBE_COV = 5,
-  SERVICE_READ_PROPERTY = 12,
-  SERVICE_WRITE_PROPERTY = 15,
-} BACNET_SERVICE_IDENTIFIER;
+typedef enum {
+    BACNET_APPLICATION_TAG_NULL = 0,
+    BACNET_APPLICATION_TAG_BOOLEAN = 1,
+    BACNET_APPLICATION_TAG_UNSIGNED_INT = 2,
+    BACNET_APPLICATION_TAG_SIGNED_INT = 3,
+    BACNET_APPLICATION_TAG_REAL = 4,
+    BACNET_APPLICATION_TAG_DOUBLE = 5,
+    BACNET_APPLICATION_TAG_OCTET_STRING = 6,
+    BACNET_APPLICATION_TAG_CHARACTER_STRING = 7,
+    BACNET_APPLICATION_TAG_BIT_STRING = 8,
+    BACNET_APPLICATION_TAG_ENUMERATED = 9,
+    BACNET_APPLICATION_TAG_DATE = 10,
+    BACNET_APPLICATION_TAG_TIME = 11,
+    BACNET_APPLICATION_TAG_OBJECT_ID = 12,
+    BACNET_APPLICATION_TAG_RESERVED1 = 13,
+    BACNET_APPLICATION_TAG_RESERVED2 = 14,
+    BACNET_APPLICATION_TAG_RESERVED3 = 15,
+} BACNET_APPLICATION_TAG;
 
 typedef enum
 {
    // Alarm and Event Services
    SERVICE_CONFIRMED_ACKNOWLEDGE_ALARM = 0,
-   SERVICE_CONFIRMED_COV_NOTIFICATION (1),
+   SERVICE_CONFIRMED_COV_NOTIFICATION = 1,
    SERVICE_CONFIRMED_EVENT_NOTIFICATION = 2,
    SERVICE_CONFIRMED_GET_ALARM_SUMMARY = 3,
    SERVICE_CONFIRMED_GET_ENROLLMENT_SUMMARY = 4,
@@ -700,11 +709,11 @@ typedef enum {
 
 typedef enum {
    RELATION_SPECIFIER_EQUAL = 0,
-   RELATION_SPECIFIER_NOT-EQUAL = 1,
-   RELATION_SPECIFIER_LESS-THAN = 2,
-   RELATION_SPECIFIER_GREATER-THAN = 3,
-   RELATION_SPECIFIER_LESS-THAN-OR-EQUAL = 4,
-   RELATION_SPECIFIER_GREATER-THAN-OR-EQUAL = 5
+   RELATION_SPECIFIER_NOT_EQUAL = 1,
+   RELATION_SPECIFIER_LESS_THAN = 2,
+   RELATION_SPECIFIER_GREATER_THAN = 3,
+   RELATION_SPECIFIER_LESS_THAN_OR_EQUAL = 4,
+   RELATION_SPECIFIER_GREATER_THAN_OR_EQUAL = 5
 } BACNET_RELATION_SPECIFIER;
 
 typedef enum {
@@ -729,26 +738,26 @@ typedef enum {
 
 typedef enum {
    ABORT_REASON_OTHER = 0,
-   ABORT_REASON_BUFFER-OVERFLOW = 1,
-   ABORT_REASON_INVALID-APDU-IN-THIS-STATE = 2,
-   ABORT_REASON_PREEMPTED-BY-HIGHER-PRIORITY-TASK = 3,
-   ABORT_REASON_SEGMENTATION-NOT-SUPPORTED = 4,
+   ABORT_REASON_BUFFER_OVERFLOW = 1,
+   ABORT_REASON_INVALID_APDU_IN_THIS_STATE = 2,
+   ABORT_REASON_PREEMPTED_BY_HIGHER_PRIORITY_TASK = 3,
+   ABORT_REASON_SEGMENTATION_NOT_SUPPORTED = 4,
    // Enumerated values 0-63 are reserved for definition by ASHRAE.
    // Enumerated values 64-65535 may be used by others subject to
    // the procedures and constraints described in Clause 23.
 } BACNET_ABORT_REASON;
 
 typedef enum {
-   OTHER = 0,
-   BUFFER-OVERFLOW = 1,
-   INCONSISTENT-PARAMETERS = 2,
-   INVALID-PARAMETER-DATA-TYPE = 3,
-   INVALID-TAG = 4,
-   MISSING-REQUIRED-PARAMETER = 5,
-   PARAMETER-OUT-OF-RANGE = 6,
-   TOO-MANY-ARGUMENTS = 7,
-   UNDEFINED-ENUMERATION = 8,
-   UNRECOGNIZED-SERVICE = 9,
+    REJECT_REASON_OTHER = 0,
+    REJECT_REASON_BUFFER_OVERFLOW = 1,
+    REJECT_REASON_INCONSISTENT_PARAMETERS = 2,
+    REJECT_REASON_INVALID_PARAMETER_DATA_TYPE = 3,
+    REJECT_REASON_INVALID_TAG = 4,
+    REJECT_REASON_MISSING_REQUIRED_PARAMETER = 5,
+    REJECT_REASON_PARAMETER_OUT_OF_RANGE = 6,
+    REJECT_REASON_TOO_MANY_ARGUMENTS = 7,
+    REJECT_REASON_UNDEFINED_ENUMERATION = 8,
+    REJECT_REASON_UNRECOGNIZED_SERVICE = 9,
    // Enumerated values 0-63 are reserved for definition by ASHRAE.
    // Enumerated values 64-65535 may be used by others subject to
    // the procedures and constraints described in Clause 23.
@@ -796,7 +805,7 @@ typedef enum {
    ERROR_CODE_OBJECT_DELETION_NOT_PERMITTED = 23,
    ERROR_CODE_OBJECT_IDENTIFIER_ALREADY_EXISTS = 24,
    ERROR_CODE_OPERATIONAL_PROBLEM = 25,
-   ERROR_CODE_OPTIONAL_FUNCTIONALITY_NOT_SUPPORTED, = 45,
+   ERROR_CODE_OPTIONAL_FUNCTIONALITY_NOT_SUPPORTED = 45,
    ERROR_CODE_PASSWORD_FAILURE = 26,
    ERROR_CODE_PROPERTY_IS_NOT_A_LIST = 22,
    ERROR_CODE_READ_ACCESS_DENIED = 27,
@@ -805,7 +814,7 @@ typedef enum {
    ERROR_CODE_TIMEOUT = 30,
    ERROR_CODE_UNKNOWN_OBJECT = 31,
    ERROR_CODE_UNKNOWN_PROPERTY = 32,
-   // this enumeration was removed = 33,
+   ERROR_CODE_RESERVED1 = 33,
    ERROR_CODE_UNKNOWN_VT_CLASS = 34,
    ERROR_CODE_UNKNOWN_VT_SESSION = 35,
    ERROR_CODE_UNSUPPORTED_OBJECT_TYPE = 36,