Added functions to the analog output demo object to get and set the Present_Value.

bacnet-stack/demo/object/ao.c

@@ -117,7 +117,7 @@ unsigned Analog_Output_Instance_To_Index(uint32_t object_instance)
     return index;
 }
 
-static float Analog_Output_Present_Value(uint32_t object_instance)
+float Analog_Output_Present_Value(uint32_t object_instance)
 {
     float value = AO_RELINQUISH_DEFAULT;
     unsigned index = 0;
@@ -137,6 +137,78 @@ static float Analog_Output_Present_Value(uint32_t object_instance)
     return value;
 }
 
+unsigned Analog_Output_Present_Value_Priority(uint32_t object_instance)
+{
+    unsigned index = 0; /* instance to index conversion */
+    unsigned i = 0; /* loop counter */
+    unsigned priority = 0; /* return value */
+
+    Analog_Output_Init();
+    index = Analog_Output_Instance_To_Index(object_instance);
+    if (index < MAX_ANALOG_OUTPUTS) {
+        for (i = 0; i < BACNET_MAX_PRIORITY; i++) {
+            if (Analog_Output_Level[index][i] != AO_LEVEL_NULL) {
+                priority = i + 1;
+                break;
+            }
+        }
+    }
+
+    return priority;
+}
+
+bool Analog_Output_Present_Value_Set(
+    uint32_t object_instance, 
+    float value, 
+    unsigned priority)
+{
+    unsigned index = 0;
+    bool status = false;
+    
+    index = Analog_Output_Instance_To_Index(object_instance);
+    if (index < MAX_ANALOG_OUTPUTS) {
+        if (priority && (priority <= BACNET_MAX_PRIORITY) &&
+            (priority != 6 /* reserved */ ) &&
+            (value >= 0.0) && (value <= 100.0)) {
+            Analog_Output_Level[index][priority] = value;
+            /* Note: you could set the physical output here to the next
+               highest priority, or to the relinquish default if no
+               priorities are set.
+               However, if Out of Service is TRUE, then don't set the 
+               physical output.  This comment may apply to the 
+               main loop (i.e. check out of service before changing output) */
+            status = true;
+        }
+    }
+    
+    return status;
+}
+
+bool Analog_Output_Present_Value_Relinquish(
+    uint32_t object_instance, 
+    int priority)
+{
+    unsigned index = 0;
+    bool status = false;
+    
+    index = Analog_Output_Instance_To_Index(object_instance);
+    if (index < MAX_ANALOG_OUTPUTS) {
+        if (priority && (priority <= BACNET_MAX_PRIORITY) &&
+            (priority != 6 /* reserved */ )) {
+            Analog_Output_Level[index][priority] = AO_LEVEL_NULL;
+            /* Note: you could set the physical output here to the next
+               highest priority, or to the relinquish default if no
+               priorities are set.
+               However, if Out of Service is TRUE, then don't set the 
+               physical output.  This comment may apply to the 
+               main loop (i.e. check out of service before changing output) */
+            status = true;
+        }
+    }
+    
+    return status;
+}
+
 /* note: the object name must be unique within this device */
 char *Analog_Output_Name(uint32_t object_instance)
 {
@@ -273,7 +345,6 @@ bool Analog_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA * wp_data,
 {
     bool status = false;        /* return value */
     unsigned int object_index = 0;
-    unsigned int priority = 0;
     uint8_t level = AO_LEVEL_NULL;
     int len = 0;
     BACNET_APPLICATION_DATA_VALUE value;
@@ -292,32 +363,20 @@ bool Analog_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA * wp_data,
     switch (wp_data->object_property) {
     case PROP_PRESENT_VALUE:
         if (value.tag == BACNET_APPLICATION_TAG_REAL) {
-            priority = wp_data->priority;
             /* Command priority 6 is reserved for use by Minimum On/Off
                algorithm and may not be used for other purposes in any
                object. */
-            if (priority && (priority <= BACNET_MAX_PRIORITY) &&
+            status = Analog_Output_Present_Value_Set(
-                (priority != 6 /* reserved */ ) &&
+                wp_data->object_instance, 
-                (value.type.Real >= 0.0) && (value.type.Real <= 100.0)) {
+                value.type.Real, 
-                level = (uint8_t) value.type.Real;
+                wp_data->priority);
-                object_index =
+            if (wp_data->priority == 6) {
-                    Analog_Output_Instance_To_Index(wp_data->
-                    object_instance);
-                priority--;
-                Analog_Output_Level[object_index][priority] = level;
-                /* Note: you could set the physical output here if we
-                   are the highest priority.
-                   However, if Out of Service is TRUE, then don't set the 
-                   physical output.  This comment may apply to the 
-                   main loop (i.e. check out of service before changing output) */
-                status = true;
-            } else if (priority == 6) {
                 /* Command priority 6 is reserved for use by Minimum On/Off
                    algorithm and may not be used for other purposes in any
                    object. */
                 *error_class = ERROR_CLASS_PROPERTY;
                 *error_code = ERROR_CODE_WRITE_ACCESS_DENIED;
-            } else {
+            } else if (!status) {
                 *error_class = ERROR_CLASS_PROPERTY;
                 *error_code = ERROR_CODE_VALUE_OUT_OF_RANGE;
             }
@@ -325,18 +384,10 @@ bool Analog_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA * wp_data,
             level = AO_LEVEL_NULL;
             object_index =
                 Analog_Output_Instance_To_Index(wp_data->object_instance);
-            priority = wp_data->priority;
+            status = Analog_Output_Present_Value_Relinquish(
-            if (priority && (priority <= BACNET_MAX_PRIORITY)) {
+                wp_data->object_instance, 
-                priority--;
+                wp_data->priority);
-                Analog_Output_Level[object_index][priority] = level;
+            if (!status) {
-                /* Note: you could set the physical output here to the next
-                   highest priority, or to the relinquish default if no
-                   priorities are set.
-                   However, if Out of Service is TRUE, then don't set the 
-                   physical output.  This comment may apply to the 
-                   main loop (i.e. check out of service before changing output) */
-                status = true;
-            } else {
                 *error_class = ERROR_CLASS_PROPERTY;
                 *error_code = ERROR_CODE_VALUE_OUT_OF_RANGE;
             }

bacnet-stack/demo/object/ao.h

@@ -39,6 +39,16 @@ extern "C" {
     unsigned Analog_Output_Count(void);
     uint32_t Analog_Output_Index_To_Instance(unsigned index);
     char *Analog_Output_Name(uint32_t object_instance);
+    float Analog_Output_Present_Value(uint32_t object_instance);
+    unsigned Analog_Output_Present_Value_Priority(uint32_t object_instance);
+    bool Analog_Output_Present_Value_Set(
+        uint32_t object_instance, 
+        float value, 
+        unsigned priority);
+    bool Analog_Output_Present_Value_Relinquish(
+        uint32_t object_instance, 
+        int priority);
+ 
 
     int Analog_Output_Encode_Property_APDU(uint8_t * apdu,
         uint32_t object_instance,