From 0cebc83d8838e14a0d6f01e8d13ff58868200bb7 Mon Sep 17 00:00:00 2001 From: Steve Karg Date: Thu, 4 Apr 2024 10:58:44 -0500 Subject: [PATCH] Enable example apps to bind to device 4194303 (#615) --- apps/add-list-element/main.c | 8 ++++---- apps/blinkt/main.c | 2 +- apps/create-object/main.c | 8 ++++---- apps/dcc/main.c | 6 +++--- apps/delete-object/main.c | 8 ++++---- apps/epics/main.c | 4 ++-- apps/gateway/main.c | 4 ++-- apps/ptransfer/main.c | 2 +- apps/readfile/main.c | 10 +++++----- apps/readprop/main.c | 2 +- apps/readpropm/main.c | 8 ++++---- apps/readrange/main.c | 2 +- apps/reinit/main.c | 4 ++-- apps/remove-list-element/main.c | 8 ++++---- apps/scov/main.c | 8 ++++---- apps/server-client/main.c | 4 ++-- apps/server-discover/main.c | 2 +- apps/ucov/main.c | 12 ++++++------ apps/uptransfer/main.c | 2 +- apps/whohas/main.c | 16 ++++++++-------- apps/whois/main.c | 8 ++++---- apps/writefile/main.c | 10 +++++----- apps/writeprop/main.c | 8 ++++---- apps/writepropm/main.c | 8 ++++---- 24 files changed, 77 insertions(+), 77 deletions(-) diff --git a/apps/add-list-element/main.c b/apps/add-list-element/main.c index 23c8ee3e..ce419f6c 100644 --- a/apps/add-list-element/main.c +++ b/apps/add-list-element/main.c @@ -286,9 +286,9 @@ int main(int argc, char *argv[]) } else { if (target_args == 0) { object_instance = strtoul(argv[argi], NULL, 0); - if (object_instance >= BACNET_MAX_INSTANCE) { + if (object_instance > BACNET_MAX_INSTANCE) { fprintf(stderr, - "device-instance=%u - it must be less than %u\n", + "device-instance=%u - not greater than %u\n", object_instance, BACNET_MAX_INSTANCE); return 1; } @@ -304,9 +304,9 @@ int main(int argc, char *argv[]) target_args++; } else if (target_args == 2) { object_instance = strtoul(argv[argi], NULL, 0); - if (object_instance >= BACNET_MAX_INSTANCE) { + if (object_instance > BACNET_MAX_INSTANCE) { fprintf(stderr, - "device-instance=%u - it must be less than %u\n", + "device-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/blinkt/main.c b/apps/blinkt/main.c index 68e69e0f..7a743403 100644 --- a/apps/blinkt/main.c +++ b/apps/blinkt/main.c @@ -393,7 +393,7 @@ int main(int argc, char *argv[]) } } if (device_id > BACNET_MAX_INSTANCE) { - fprintf(stderr, "device=%u - it must be less than %u\n", device_id, + fprintf(stderr, "device=%u - not greater than %u\n", device_id, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/create-object/main.c b/apps/create-object/main.c index 357c240e..0813eab1 100644 --- a/apps/create-object/main.c +++ b/apps/create-object/main.c @@ -274,9 +274,9 @@ int main(int argc, char *argv[]) } else { if (target_args == 0) { object_instance = strtoul(argv[argi], NULL, 0); - if (object_instance >= BACNET_MAX_INSTANCE) { + if (object_instance > BACNET_MAX_INSTANCE) { fprintf(stderr, - "device-instance=%u - it must be less than %u\n", + "device-instance=%u - not greater than %u\n", object_instance, BACNET_MAX_INSTANCE); return 1; } @@ -292,9 +292,9 @@ int main(int argc, char *argv[]) target_args++; } else if (target_args == 2) { object_instance = strtoul(argv[argi], NULL, 0); - if (object_instance >= BACNET_MAX_INSTANCE) { + if (object_instance > BACNET_MAX_INSTANCE) { fprintf(stderr, - "object-instance=%u - it must be less than %u\n", + "object-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/dcc/main.c b/apps/dcc/main.c index 4592efa2..77c0ce49 100644 --- a/apps/dcc/main.c +++ b/apps/dcc/main.c @@ -157,7 +157,7 @@ static void print_help(char *filename) "If you want disable Device Communications in Device 123\n" "for 60 minutes with password 'filister', use the following command:\n" "%s 123 1 60 filister\n", - (unsigned long)(BACNET_MAX_INSTANCE - 1), filename); + (unsigned long)BACNET_MAX_INSTANCE, filename); } int main(int argc, char *argv[]) @@ -207,8 +207,8 @@ int main(int argc, char *argv[]) if (argc > 4) { Communication_Password = argv[4]; } - if (Target_Device_Object_Instance >= BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\n", + if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { + fprintf(stderr, "device-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/delete-object/main.c b/apps/delete-object/main.c index a1883d22..236841f6 100644 --- a/apps/delete-object/main.c +++ b/apps/delete-object/main.c @@ -235,9 +235,9 @@ int main(int argc, char *argv[]) } else { if (target_args == 0) { object_instance = strtoul(argv[argi], NULL, 0); - if (object_instance >= BACNET_MAX_INSTANCE) { + if (object_instance > BACNET_MAX_INSTANCE) { fprintf(stderr, - "device-instance=%u - it must be less than %u\n", + "device-instance=%u - not greater than %u\n", object_instance, BACNET_MAX_INSTANCE); return 1; } @@ -253,9 +253,9 @@ int main(int argc, char *argv[]) target_args++; } else if (target_args == 2) { object_instance = strtoul(argv[argi], NULL, 0); - if (object_instance >= BACNET_MAX_INSTANCE) { + if (object_instance > BACNET_MAX_INSTANCE) { fprintf(stderr, - "object-instance=%u - it must be less than %u\n", + "object-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/epics/main.c b/apps/epics/main.c index 88629c23..7d73e82f 100644 --- a/apps/epics/main.c +++ b/apps/epics/main.c @@ -1135,8 +1135,8 @@ static int CheckCommandLineArgs(int argc, char *argv[]) Target_Device_Object_Instance = strtol(anArg, NULL, 0); if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { fprintf(stdout, - "Error: device-instance=%u - it must be less than %u\n", - Target_Device_Object_Instance, BACNET_MAX_INSTANCE + 1); + "Error: device-instance=%u - not greater than %u\n", + Target_Device_Object_Instance, BACNET_MAX_INSTANCE); print_usage(filename); exit(0); } diff --git a/apps/gateway/main.c b/apps/gateway/main.c index b81b5613..53188e98 100644 --- a/apps/gateway/main.c +++ b/apps/gateway/main.c @@ -247,10 +247,10 @@ int main(int argc, char *argv[]) if (argc > 1) { first_object_instance = strtol(argv[1], NULL, 0); if ((first_object_instance == 0) || - (first_object_instance >= BACNET_MAX_INSTANCE)) { + (first_object_instance > BACNET_MAX_INSTANCE)) { printf("Error: Invalid Object Instance %s \n", argv[1]); printf( - "Provide a number from 1 to %ul \n", BACNET_MAX_INSTANCE - 1); + "Provide a number from 1 to %ul \n", BACNET_MAX_INSTANCE); exit(1); } } diff --git a/apps/ptransfer/main.c b/apps/ptransfer/main.c index 7e5fe64e..d11ec410 100644 --- a/apps/ptransfer/main.c +++ b/apps/ptransfer/main.c @@ -237,7 +237,7 @@ int main(int argc, char *argv[]) Target_Device_Object_Instance = strtol(argv[1 + Target_Mode], NULL, 0); if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\r\n", + fprintf(stderr, "device-instance=%u - not greater than %u\r\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/readfile/main.c b/apps/readfile/main.c index 61b9644c..143aedb8 100644 --- a/apps/readfile/main.c +++ b/apps/readfile/main.c @@ -297,14 +297,14 @@ int main(int argc, char *argv[]) Target_Device_Object_Instance = strtol(argv[1], NULL, 0); Target_File_Object_Instance = strtol(argv[2], NULL, 0); Local_File_Name = argv[3]; - if (Target_Device_Object_Instance >= BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\n", + if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { + fprintf(stderr, "device-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } - if (Target_File_Object_Instance >= BACNET_MAX_INSTANCE) { - fprintf(stderr, "file-instance=%u - it must be less than %u\n", - Target_File_Object_Instance, BACNET_MAX_INSTANCE + 1); + if (Target_File_Object_Instance > BACNET_MAX_INSTANCE) { + fprintf(stderr, "file-instance=%u - not greater than %u\n", + Target_File_Object_Instance, BACNET_MAX_INSTANCE); return 1; } /* setup my info */ diff --git a/apps/readprop/main.c b/apps/readprop/main.c index d45916a5..a7461ce0 100644 --- a/apps/readprop/main.c +++ b/apps/readprop/main.c @@ -345,7 +345,7 @@ int main(int argc, char *argv[]) return 0; } if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\n", + fprintf(stderr, "device-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/readpropm/main.c b/apps/readpropm/main.c index a57b14c3..cbe222bc 100644 --- a/apps/readpropm/main.c +++ b/apps/readpropm/main.c @@ -406,9 +406,9 @@ int main(int argc, char *argv[]) } else { if (target_args == 0) { Target_Device_Object_Instance = strtol(argv[argi], NULL, 0); - if (Target_Device_Object_Instance >= BACNET_MAX_INSTANCE) { + if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { fprintf(stderr, - "device-instance=%u - it must be less than %u\n", + "device-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } @@ -445,9 +445,9 @@ int main(int argc, char *argv[]) rpm_object->object_instance = strtol(argv[argi], NULL, 0); if (rpm_object->object_instance > BACNET_MAX_INSTANCE) { fprintf(stderr, - "object-instance=%u - it must be less than %u\n", + "object-instance=%u - not greater than %u\n", rpm_object->object_instance, - BACNET_MAX_INSTANCE + 1); + BACNET_MAX_INSTANCE); return 1; } tag_value_arg++; diff --git a/apps/readrange/main.c b/apps/readrange/main.c index 8ea0dde1..fa959154 100644 --- a/apps/readrange/main.c +++ b/apps/readrange/main.c @@ -255,7 +255,7 @@ int main(int argc, char *argv[]) Target_Object_Range_Type = strtol(argv[5], NULL, 0); /* some bounds checking */ if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\r\n", + fprintf(stderr, "device-instance=%u - not greater than %u\r\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/reinit/main.c b/apps/reinit/main.c index 7d4b4aa3..795acf36 100644 --- a/apps/reinit/main.c +++ b/apps/reinit/main.c @@ -167,8 +167,8 @@ int main(int argc, char *argv[]) Reinitialize_Password = argv[3]; } - if (Target_Device_Object_Instance >= BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\r\n", + if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { + fprintf(stderr, "device-instance=%u - not greater than %u\r\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/remove-list-element/main.c b/apps/remove-list-element/main.c index dc5d2de8..f9a99c00 100644 --- a/apps/remove-list-element/main.c +++ b/apps/remove-list-element/main.c @@ -286,9 +286,9 @@ int main(int argc, char *argv[]) } else { if (target_args == 0) { object_instance = strtoul(argv[argi], NULL, 0); - if (object_instance >= BACNET_MAX_INSTANCE) { + if (object_instance > BACNET_MAX_INSTANCE) { fprintf(stderr, - "device-instance=%u - it must be less than %u\n", + "device-instance=%u - not greater than %u\n", object_instance, BACNET_MAX_INSTANCE); return 1; } @@ -304,9 +304,9 @@ int main(int argc, char *argv[]) target_args++; } else if (target_args == 2) { object_instance = strtoul(argv[argi], NULL, 0); - if (object_instance >= BACNET_MAX_INSTANCE) { + if (object_instance > BACNET_MAX_INSTANCE) { fprintf(stderr, - "device-instance=%u - it must be less than %u\n", + "device-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/scov/main.c b/apps/scov/main.c index 07c62b30..a04a0a95 100644 --- a/apps/scov/main.c +++ b/apps/scov/main.c @@ -267,8 +267,8 @@ int main(int argc, char *argv[]) } /* decode the command line parameters */ Target_Device_Object_Instance = strtol(argv[1], NULL, 0); - if (Target_Device_Object_Instance >= BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\n", + if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { + fprintf(stderr, "device-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } @@ -294,9 +294,9 @@ int main(int argc, char *argv[]) strtol(argv[argi], NULL, 0); if (cov_data->monitoredObjectIdentifier.instance > BACNET_MAX_INSTANCE) { - fprintf(stderr, "object-instance=%u - it must be less than %u\n", + fprintf(stderr, "object-instance=%u - not greater than %u\n", cov_data->monitoredObjectIdentifier.instance, - BACNET_MAX_INSTANCE + 1); + BACNET_MAX_INSTANCE); return 1; } argi++; diff --git a/apps/server-client/main.c b/apps/server-client/main.c index 1ba57cf1..bcaeb835 100644 --- a/apps/server-client/main.c +++ b/apps/server-client/main.c @@ -125,7 +125,7 @@ int main(int argc, char *argv[]) if (++argi < argc) { device_id = strtol(argv[argi], NULL, 0); if (device_id > BACNET_MAX_INSTANCE) { - fprintf(stderr, "device=%u - it must be less than %u\n", + fprintf(stderr, "device=%u - not greater than %u\n", device_id, BACNET_MAX_INSTANCE); return 1; } @@ -161,7 +161,7 @@ int main(int argc, char *argv[]) } Device_Set_Object_Instance_Number(device_id); if (target_device_object_instance > BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\n", + fprintf(stderr, "device-instance=%u - not greater than %u\n", target_device_object_instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/server-discover/main.c b/apps/server-discover/main.c index 435a9eae..43d192d0 100644 --- a/apps/server-discover/main.c +++ b/apps/server-discover/main.c @@ -254,7 +254,7 @@ int main(int argc, char *argv[]) } } if (device_id > BACNET_MAX_INSTANCE) { - debug_perror("device-instance=%u - it must be less than %u\n", + debug_perror("device-instance=%u - not greater than %u\n", device_id, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/ucov/main.c b/apps/ucov/main.c index 220d3016..49cc1108 100644 --- a/apps/ucov/main.c +++ b/apps/ucov/main.c @@ -176,8 +176,8 @@ int main(int argc, char *argv[]) value_list.propertyArrayIndex = BACNET_ARRAY_ALL; } - if (cov_data.initiatingDeviceIdentifier >= BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\n", + if (cov_data.initiatingDeviceIdentifier > BACNET_MAX_INSTANCE) { + fprintf(stderr, "device-instance=%u - not greater than %u\n", cov_data.initiatingDeviceIdentifier, BACNET_MAX_INSTANCE); return 1; } @@ -187,15 +187,15 @@ int main(int argc, char *argv[]) return 1; } if (cov_data.monitoredObjectIdentifier.instance > BACNET_MAX_INSTANCE) { - fprintf(stderr, "object-instance=%u - it must be less than %u\n", + fprintf(stderr, "object-instance=%u - not greater than %u\n", cov_data.monitoredObjectIdentifier.instance, - BACNET_MAX_INSTANCE + 1); + BACNET_MAX_INSTANCE); return 1; } if (cov_data.listOfValues->propertyIdentifier > MAX_BACNET_PROPERTY_ID) { - fprintf(stderr, "property-identifier=%u - it must be less than %u\n", + fprintf(stderr, "property-identifier=%u - not greater than %u\n", cov_data.listOfValues->propertyIdentifier, - MAX_BACNET_PROPERTY_ID + 1); + MAX_BACNET_PROPERTY_ID); return 1; } if (tag >= MAX_BACNET_APPLICATION_TAG) { diff --git a/apps/uptransfer/main.c b/apps/uptransfer/main.c index 95764a81..94b0633e 100644 --- a/apps/uptransfer/main.c +++ b/apps/uptransfer/main.c @@ -229,7 +229,7 @@ int main(int argc, char *argv[]) Target_Service_Number = strtol(argv[3], NULL, 0); if ((!Target_Broadcast) && (Target_Device_Object_Instance > BACNET_MAX_INSTANCE)) { - fprintf(stderr, "device-instance=%u - it must be less than %u\n", + fprintf(stderr, "device-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } diff --git a/apps/whohas/main.c b/apps/whohas/main.c index eef912e7..40b8664d 100644 --- a/apps/whohas/main.c +++ b/apps/whohas/main.c @@ -196,24 +196,24 @@ int main(int argc, char *argv[]) } } else { if (Target_Object_Instance > BACNET_MAX_INSTANCE) { - fprintf(stderr, "object-instance=%u - it must be less than %u\r\n", - Target_Object_Instance, BACNET_MAX_INSTANCE + 1); + fprintf(stderr, "object-instance=%u - not greater than %u\r\n", + Target_Object_Instance, BACNET_MAX_INSTANCE); return 1; } if (Target_Object_Type > BACNET_MAX_OBJECT) { - fprintf(stderr, "object-type=%u - it must be less than %u\r\n", - Target_Object_Type, BACNET_MAX_OBJECT + 1); + fprintf(stderr, "object-type=%u - not greater than %u\r\n", + Target_Object_Type, BACNET_MAX_OBJECT); return 1; } } if (Target_Object_Instance_Min > BACNET_MAX_INSTANCE) { - fprintf(stderr, "object-instance-min=%u - it must be less than %u\r\n", - Target_Object_Instance_Min, BACNET_MAX_INSTANCE + 1); + fprintf(stderr, "object-instance-min=%u - not greater than %u\r\n", + Target_Object_Instance_Min, BACNET_MAX_INSTANCE); return 1; } if (Target_Object_Instance_Max > BACNET_MAX_INSTANCE) { - fprintf(stderr, "object-instance-max=%u - it must be less than %u\r\n", - Target_Object_Instance_Max, BACNET_MAX_INSTANCE + 1); + fprintf(stderr, "object-instance-max=%u - not greater than %u\r\n", + Target_Object_Instance_Max, BACNET_MAX_INSTANCE); return 1; } /* setup my info */ diff --git a/apps/whois/main.c b/apps/whois/main.c index 59ba6e09..368c8bd4 100644 --- a/apps/whois/main.c +++ b/apps/whois/main.c @@ -462,13 +462,13 @@ int main(int argc, char *argv[]) } } if (Target_Object_Instance_Min > BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance-min=%u - it must be less than %u\n", - Target_Object_Instance_Min, BACNET_MAX_INSTANCE + 1); + fprintf(stderr, "device-instance-min=%u - not greater than %u\n", + Target_Object_Instance_Min, BACNET_MAX_INSTANCE); return 1; } if (Target_Object_Instance_Max > BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance-max=%u - it must be less than %u\n", - Target_Object_Instance_Max, BACNET_MAX_INSTANCE + 1); + fprintf(stderr, "device-instance-max=%u - not greater than %u\n", + Target_Object_Instance_Max, BACNET_MAX_INSTANCE); return 1; } /* setup my info */ diff --git a/apps/writefile/main.c b/apps/writefile/main.c index eff18cf1..1b9fe06c 100644 --- a/apps/writefile/main.c +++ b/apps/writefile/main.c @@ -174,14 +174,14 @@ int main(int argc, char *argv[]) Target_Device_Object_Instance = strtol(argv[1], NULL, 0); Target_File_Object_Instance = strtol(argv[2], NULL, 0); Local_File_Name = argv[3]; - if (Target_Device_Object_Instance >= BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\r\n", + if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { + fprintf(stderr, "device-instance=%u - not greater than %u\r\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } - if (Target_File_Object_Instance >= BACNET_MAX_INSTANCE) { - fprintf(stderr, "file-instance=%u - it must be less than %u\r\n", - Target_File_Object_Instance, BACNET_MAX_INSTANCE + 1); + if (Target_File_Object_Instance > BACNET_MAX_INSTANCE) { + fprintf(stderr, "file-instance=%u - not greater than %u\r\n", + Target_File_Object_Instance, BACNET_MAX_INSTANCE); return 1; } if (argc > 4) { diff --git a/apps/writeprop/main.c b/apps/writeprop/main.c index 01a85428..fefbac60 100644 --- a/apps/writeprop/main.c +++ b/apps/writeprop/main.c @@ -304,8 +304,8 @@ int main(int argc, char *argv[]) Target_Object_Property_Index = BACNET_ARRAY_ALL; } if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\n", - Target_Device_Object_Instance, BACNET_MAX_INSTANCE + 1); + fprintf(stderr, "device-instance=%u - not greater than %u\n", + Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } if (Target_Object_Type > MAX_BACNET_OBJECT_TYPE) { @@ -314,8 +314,8 @@ int main(int argc, char *argv[]) return 1; } if (Target_Object_Instance > BACNET_MAX_INSTANCE) { - fprintf(stderr, "object-instance=%u - it must be less than %u\n", - Target_Object_Instance, BACNET_MAX_INSTANCE + 1); + fprintf(stderr, "object-instance=%u - not greater than %u\n", + Target_Object_Instance, BACNET_MAX_INSTANCE); return 1; } if (Target_Object_Property > MAX_BACNET_PROPERTY_ID) { diff --git a/apps/writepropm/main.c b/apps/writepropm/main.c index be2d8fbf..b7ab9747 100644 --- a/apps/writepropm/main.c +++ b/apps/writepropm/main.c @@ -313,8 +313,8 @@ int main(int argc, char *argv[]) } /* decode the command line parameters */ Target_Device_Object_Instance = strtol(argv[1], NULL, 0); - if (Target_Device_Object_Instance >= BACNET_MAX_INSTANCE) { - fprintf(stderr, "device-instance=%u - it must be less than %u\n", + if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) { + fprintf(stderr, "device-instance=%u - not greater than %u\n", Target_Device_Object_Instance, BACNET_MAX_INSTANCE); return 1; } @@ -357,8 +357,8 @@ int main(int argc, char *argv[]) return 1; } if (wpm_object->object_instance > BACNET_MAX_INSTANCE) { - fprintf(stderr, "object-instance=%u - it must be less than %u\n", - wpm_object->object_instance, BACNET_MAX_INSTANCE + 1); + fprintf(stderr, "object-instance=%u - not greater than %u\n", + wpm_object->object_instance, BACNET_MAX_INSTANCE); return 1; } do {