dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature/app data buffer check (#79)

Browse Source 
* Added comments and buffer overflow checks

* Removed backslashs from C-code.
This commit is contained in:
Roy Schneider
2020-04-28 15:45:03 +02:00
committed by GitHub
parent 89929ee802
commit 0abcbea971
20 changed files with 1588 additions and 635 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bacnet/bacstr.c
+6 -5
View File
@@ -723,22 +723,23 @@ bool octetstring_init(
{
bool status = false; /* return value */
size_t i; /* counter */
uint8_t *pb = NULL;
if (octet_string && (length <= MAX_OCTET_STRING_BYTES)) {
octet_string->length = 0;
if (value) {
pb = octet_string->value;
for (i = 0; i < MAX_OCTET_STRING_BYTES; i++) {
if (i < length) {
octet_string->value[i] = value[i];
*pb = value[i];
} else {
octet_string->value[i] = 0;
*pb = 0;
}
pb++;
}
octet_string->length = length;
} else {
for (i = 0; i < MAX_OCTET_STRING_BYTES; i++) {
octet_string->value[i] = 0;
}
memset(octet_string->value, 0, MAX_OCTET_STRING_BYTES);
}
status = true;
}