From 07d194ab053dca68310bbf72525210f013564ad0 Mon Sep 17 00:00:00 2001 From: Tomasz Kazimierz Motyl Date: Wed, 11 Sep 2024 14:02:24 +0100 Subject: [PATCH] Merge pull request #66 from se-apc/bugfix/cob_subscriptions_destination_indexing (#761) Fixing order of operations so the dest_index gets written to the right slot instead of an initial MAX_COV_SUBSCRIPTIONS-1 Co-authored-by: Tomasz Kazimierz Motyl --- src/bacnet/basic/service/h_cov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bacnet/basic/service/h_cov.c b/src/bacnet/basic/service/h_cov.c index 33c24694..673fd5e9 100644 --- a/src/bacnet/basic/service/h_cov.c +++ b/src/bacnet/basic/service/h_cov.c @@ -393,9 +393,9 @@ static bool cov_list_subscribe( *error_code = ERROR_CODE_NO_SPACE_TO_ADD_LIST_ELEMENT; found = false; } else { - COV_Subscriptions[index].dest_index = addr_add_ret; index = first_invalid_index; found = true; + COV_Subscriptions[index].dest_index = addr_add_ret; COV_Subscriptions[index].flag.valid = true; COV_Subscriptions[index].monitoredObjectIdentifier.type = cov_data->monitoredObjectIdentifier.type;